Commit f2b86781 authored by Julia Lawall's avatar Julia Lawall Committed by Lee Jones

mfd: twl6040: Fix error return code

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 6052d83e
...@@ -679,6 +679,7 @@ static int twl6040_probe(struct i2c_client *client, ...@@ -679,6 +679,7 @@ static int twl6040_probe(struct i2c_client *client,
if (twl6040->rev < 0) { if (twl6040->rev < 0) {
dev_err(&client->dev, "Failed to read revision register: %d\n", dev_err(&client->dev, "Failed to read revision register: %d\n",
twl6040->rev); twl6040->rev);
ret = twl6040->rev;
goto gpio_err; goto gpio_err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment