Commit f2e72a0b authored by Daniel Borkmann's avatar Daniel Borkmann

Merge branch 'bpf-bpftool-fixes'

Jakub Kicinski says:

====================
Two small fixes for error handling in bpftool prog load, first patch
removes a duplicated message, second one frees resources correctly.
Multiple error messages break JSON:

{
    "error": "can't pin the object (/sys/fs/bpf/a): File exists"
},{
    "error": "failed to pin program"
}
====================
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parents 3739a21e bfee71fb
...@@ -694,15 +694,19 @@ static int do_load(int argc, char **argv) ...@@ -694,15 +694,19 @@ static int do_load(int argc, char **argv)
return -1; return -1;
} }
if (do_pin_fd(prog_fd, argv[1])) { if (do_pin_fd(prog_fd, argv[1]))
p_err("failed to pin program"); goto err_close_obj;
return -1;
}
if (json_output) if (json_output)
jsonw_null(json_wtr); jsonw_null(json_wtr);
bpf_object__close(obj);
return 0; return 0;
err_close_obj:
bpf_object__close(obj);
return -1;
} }
static int do_help(int argc, char **argv) static int do_help(int argc, char **argv)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment