Commit f3e83131 authored by Luca Barbieri's avatar Luca Barbieri Committed by H. Peter Anvin

x86-32: Fix atomic64_inc_not_zero return value convention

atomic64_inc_not_zero must return 1 if it perfomed the add and 0 otherwise.
It was doing the opposite thing.
Signed-off-by: default avatarLuca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-6-git-send-email-luca@luca-barbieri.com>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent 25a304f2
...@@ -153,13 +153,12 @@ BEGIN inc_not_zero %esi ...@@ -153,13 +153,12 @@ BEGIN inc_not_zero %esi
adcl $0, %edx adcl $0, %edx
movl %eax, ($v) movl %eax, ($v)
movl %edx, 4($v) movl %edx, 4($v)
xorl %eax, %eax movl $1, %eax
2: 2:
RETURN RETURN
3: 3:
testl %edx, %edx testl %edx, %edx
jne 1b jne 1b
movl $1, %eax
jmp 2b jmp 2b
END_ END_
......
...@@ -212,14 +212,13 @@ ENTRY(atomic64_inc_not_zero_cx8) ...@@ -212,14 +212,13 @@ ENTRY(atomic64_inc_not_zero_cx8)
cmpxchg8b (%esi) cmpxchg8b (%esi)
jne 1b jne 1b
xorl %eax, %eax movl $1, %eax
3: 3:
RESTORE ebx RESTORE ebx
ret ret
4: 4:
testl %edx, %edx testl %edx, %edx
jne 2b jne 2b
movl $1, %eax
jmp 3b jmp 3b
CFI_ENDPROC CFI_ENDPROC
ENDPROC(atomic64_inc_not_zero_cx8) ENDPROC(atomic64_inc_not_zero_cx8)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment