Commit f40e0638 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

drivers/net/hamradio: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f162e97d
...@@ -846,12 +846,13 @@ static int mkiss_ioctl(struct tty_struct *tty, struct file *file, ...@@ -846,12 +846,13 @@ static int mkiss_ioctl(struct tty_struct *tty, struct file *file,
unsigned int cmd, unsigned long arg) unsigned int cmd, unsigned long arg)
{ {
struct mkiss *ax = mkiss_get(tty); struct mkiss *ax = mkiss_get(tty);
struct net_device *dev = ax->dev; struct net_device *dev;
unsigned int tmp, err; unsigned int tmp, err;
/* First make sure we're connected. */ /* First make sure we're connected. */
if (ax == NULL) if (ax == NULL)
return -ENXIO; return -ENXIO;
dev = ax->dev;
switch (cmd) { switch (cmd) {
case SIOCGIFNAME: case SIOCGIFNAME:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment