Commit f51fac68 authored by Darrick J. Wong's avatar Darrick J. Wong

xfs: zero initialize highstale and lowstale in xfs_dir2_leaf_addname

Smatch complains about the following:

fs/xfs/libxfs/xfs_dir2_leaf.c:848 xfs_dir2_leaf_addname() error:
uninitialized symbol 'lowstale'.

fs/xfs/libxfs/xfs_dir2_leaf.c:849 xfs_dir2_leaf_addname() error:
uninitialized symbol 'highstale'.

I don't think there's any incorrect behavior associated with the
uninitialized variable, but as the author of the previous zero-init
patch points out, it's best not to be passing around pointers to
uninitialized stack areas.
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarAllison Henderson <allison.henderson@oracle.com>
Reviewed-by: default avatarBill O'Donnell <billodo@redhat.com>
parent 79622c7c
...@@ -574,7 +574,7 @@ xfs_dir2_leaf_addname( ...@@ -574,7 +574,7 @@ xfs_dir2_leaf_addname(
xfs_dir2_data_unused_t *dup; /* data unused entry */ xfs_dir2_data_unused_t *dup; /* data unused entry */
int error; /* error return value */ int error; /* error return value */
int grown; /* allocated new data block */ int grown; /* allocated new data block */
int highstale; /* index of next stale leaf */ int highstale = 0; /* index of next stale leaf */
int i; /* temporary, index */ int i; /* temporary, index */
int index; /* leaf table position */ int index; /* leaf table position */
struct xfs_buf *lbp; /* leaf's buffer */ struct xfs_buf *lbp; /* leaf's buffer */
...@@ -583,7 +583,7 @@ xfs_dir2_leaf_addname( ...@@ -583,7 +583,7 @@ xfs_dir2_leaf_addname(
xfs_dir2_leaf_entry_t *lep; /* leaf entry table pointer */ xfs_dir2_leaf_entry_t *lep; /* leaf entry table pointer */
int lfloglow; /* low leaf logging index */ int lfloglow; /* low leaf logging index */
int lfloghigh; /* high leaf logging index */ int lfloghigh; /* high leaf logging index */
int lowstale; /* index of prev stale leaf */ int lowstale = 0; /* index of prev stale leaf */
xfs_dir2_leaf_tail_t *ltp; /* leaf tail pointer */ xfs_dir2_leaf_tail_t *ltp; /* leaf tail pointer */
int needbytes; /* leaf block bytes needed */ int needbytes; /* leaf block bytes needed */
int needlog; /* need to log data header */ int needlog; /* need to log data header */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment