Commit f54fa84d authored by Orjan Friberg's avatar Orjan Friberg Committed by Greg Kroah-Hartman

USB: usbtest.c: unsigned retval makes ctrl_out return 0 in case of error

In my quest to try and figure out why test 14 (control write) doesn't
work with my EZ-USB board, I noticed that sometimes testusb reported
no error even though the kernel log complained "byte 0 is 0 not 2" etc.
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 2011e924
...@@ -1242,11 +1242,12 @@ static int halt_simple (struct usbtest_dev *dev) ...@@ -1242,11 +1242,12 @@ static int halt_simple (struct usbtest_dev *dev)
static int ctrl_out (struct usbtest_dev *dev, static int ctrl_out (struct usbtest_dev *dev,
unsigned count, unsigned length, unsigned vary) unsigned count, unsigned length, unsigned vary)
{ {
unsigned i, j, len, retval; unsigned i, j, len;
int retval;
u8 *buf; u8 *buf;
char *what = "?"; char *what = "?";
struct usb_device *udev; struct usb_device *udev;
if (length < 1 || length > 0xffff || vary >= length) if (length < 1 || length > 0xffff || vary >= length)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment