Commit f68c5301 authored by Changli Gao's avatar Changli Gao Committed by Patrick McHardy

netfilter: unregister nf hooks, matches and targets in the reverse order

Since we register nf hooks, matches and targets in order, we'd better
unregister them in the reverse order.
Signed-off-by: default avatarChangli Gao <xiaosuo@gmail.com>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
parent e55df53d
...@@ -105,10 +105,8 @@ EXPORT_SYMBOL(nf_register_hooks); ...@@ -105,10 +105,8 @@ EXPORT_SYMBOL(nf_register_hooks);
void nf_unregister_hooks(struct nf_hook_ops *reg, unsigned int n) void nf_unregister_hooks(struct nf_hook_ops *reg, unsigned int n)
{ {
unsigned int i; while (n-- > 0)
nf_unregister_hook(&reg[n]);
for (i = 0; i < n; i++)
nf_unregister_hook(&reg[i]);
} }
EXPORT_SYMBOL(nf_unregister_hooks); EXPORT_SYMBOL(nf_unregister_hooks);
......
...@@ -116,10 +116,8 @@ EXPORT_SYMBOL(xt_register_targets); ...@@ -116,10 +116,8 @@ EXPORT_SYMBOL(xt_register_targets);
void void
xt_unregister_targets(struct xt_target *target, unsigned int n) xt_unregister_targets(struct xt_target *target, unsigned int n)
{ {
unsigned int i; while (n-- > 0)
xt_unregister_target(&target[n]);
for (i = 0; i < n; i++)
xt_unregister_target(&target[i]);
} }
EXPORT_SYMBOL(xt_unregister_targets); EXPORT_SYMBOL(xt_unregister_targets);
...@@ -174,10 +172,8 @@ EXPORT_SYMBOL(xt_register_matches); ...@@ -174,10 +172,8 @@ EXPORT_SYMBOL(xt_register_matches);
void void
xt_unregister_matches(struct xt_match *match, unsigned int n) xt_unregister_matches(struct xt_match *match, unsigned int n)
{ {
unsigned int i; while (n-- > 0)
xt_unregister_match(&match[n]);
for (i = 0; i < n; i++)
xt_unregister_match(&match[i]);
} }
EXPORT_SYMBOL(xt_unregister_matches); EXPORT_SYMBOL(xt_unregister_matches);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment