Commit f6c179b5 authored by Nikhil Badola's avatar Nikhil Badola Committed by Luis Henriques

drivers: usb: fsl: Workaround for USB erratum-A005275

commit f8786a91 upstream.

Incoming packets in high speed are randomly corrupted by h/w
resulting in multiple errors. This workaround makes FS as
default mode in all affected socs by disabling HS chirp
signalling.This errata does not affect FS and LS mode.

Forces all HS devices to connect in FS mode for all socs
affected by this erratum:
P3041 and P2041 rev 1.0 and 1.1
P5020 and P5010 rev 1.0 and 2.0
P5040, P1010 and T4240 rev 1.0
Signed-off-by: default avatarRamneek Mehresh <ramneek.mehresh@freescale.com>
Signed-off-by: default avatarNikhil Badola <nikhil.badola@freescale.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 7ec9b7fb
...@@ -298,6 +298,10 @@ static int ehci_fsl_usb_setup(struct ehci_hcd *ehci) ...@@ -298,6 +298,10 @@ static int ehci_fsl_usb_setup(struct ehci_hcd *ehci)
out_be32(non_ehci + FSL_SOC_USB_SNOOP2, 0x80000000 | SNOOP_SIZE_2GB); out_be32(non_ehci + FSL_SOC_USB_SNOOP2, 0x80000000 | SNOOP_SIZE_2GB);
} }
/* Deal with USB erratum A-005275 */
if (pdata->has_fsl_erratum_a005275 == 1)
ehci->has_fsl_hs_errata = 1;
if ((pdata->operating_mode == FSL_USB2_DR_HOST) || if ((pdata->operating_mode == FSL_USB2_DR_HOST) ||
(pdata->operating_mode == FSL_USB2_DR_OTG)) (pdata->operating_mode == FSL_USB2_DR_OTG))
if (ehci_fsl_setup_phy(hcd, pdata->phy_mode, 0)) if (ehci_fsl_setup_phy(hcd, pdata->phy_mode, 0))
......
...@@ -1218,6 +1218,13 @@ int ehci_hub_control( ...@@ -1218,6 +1218,13 @@ int ehci_hub_control(
*/ */
ehci->reset_done [wIndex] = jiffies ehci->reset_done [wIndex] = jiffies
+ msecs_to_jiffies (50); + msecs_to_jiffies (50);
/*
* Force full-speed connect for FSL high-speed
* erratum; disable HS Chirp by setting PFSC bit
*/
if (ehci_has_fsl_hs_errata(ehci))
temp |= (1 << PORTSC_FSL_PFSC);
} }
ehci_writel(ehci, temp, status_reg); ehci_writel(ehci, temp, status_reg);
break; break;
......
...@@ -215,6 +215,7 @@ struct ehci_hcd { /* one per controller */ ...@@ -215,6 +215,7 @@ struct ehci_hcd { /* one per controller */
/* SILICON QUIRKS */ /* SILICON QUIRKS */
unsigned no_selective_suspend:1; unsigned no_selective_suspend:1;
unsigned has_fsl_port_bug:1; /* FreeScale */ unsigned has_fsl_port_bug:1; /* FreeScale */
unsigned has_fsl_hs_errata:1; /* Freescale HS quirk */
unsigned big_endian_mmio:1; unsigned big_endian_mmio:1;
unsigned big_endian_desc:1; unsigned big_endian_desc:1;
unsigned big_endian_capbase:1; unsigned big_endian_capbase:1;
...@@ -686,6 +687,17 @@ ehci_port_speed(struct ehci_hcd *ehci, unsigned int portsc) ...@@ -686,6 +687,17 @@ ehci_port_speed(struct ehci_hcd *ehci, unsigned int portsc)
#define ehci_has_fsl_portno_bug(e) (0) #define ehci_has_fsl_portno_bug(e) (0)
#endif #endif
#define PORTSC_FSL_PFSC 24 /* Port Force Full-Speed Connect */
#if defined(CONFIG_PPC_85xx)
/* Some Freescale processors have an erratum (USB A-005275) in which
* incoming packets get corrupted in HS mode
*/
#define ehci_has_fsl_hs_errata(e) ((e)->has_fsl_hs_errata)
#else
#define ehci_has_fsl_hs_errata(e) (0)
#endif
/* /*
* While most USB host controllers implement their registers in * While most USB host controllers implement their registers in
* little-endian format, a minority (celleb companion chip) implement * little-endian format, a minority (celleb companion chip) implement
......
...@@ -211,6 +211,10 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev) ...@@ -211,6 +211,10 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
pdata->has_fsl_erratum_a007792 = 1; pdata->has_fsl_erratum_a007792 = 1;
else else
pdata->has_fsl_erratum_a007792 = 0; pdata->has_fsl_erratum_a007792 = 0;
if (of_get_property(np, "fsl,usb-erratum-a005275", NULL))
pdata->has_fsl_erratum_a005275 = 1;
else
pdata->has_fsl_erratum_a005275 = 0;
if (pdata->have_sysif_regs) { if (pdata->have_sysif_regs) {
if (pdata->controller_ver < 0) { if (pdata->controller_ver < 0) {
......
...@@ -93,6 +93,7 @@ struct fsl_usb2_platform_data { ...@@ -93,6 +93,7 @@ struct fsl_usb2_platform_data {
unsigned suspended:1; unsigned suspended:1;
unsigned already_suspended:1; unsigned already_suspended:1;
unsigned has_fsl_erratum_a007792:1; unsigned has_fsl_erratum_a007792:1;
unsigned has_fsl_erratum_a005275:1;
/* register save area for suspend/resume */ /* register save area for suspend/resume */
u32 pm_command; u32 pm_command;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment