Commit f763fd44 authored by Dave Chinner's avatar Dave Chinner Committed by Ben Myers

xfs: disable noattr2/attr2 mount options for CRC enabled filesystems

attr2 format is always enabled for v5 superblock filesystems, so the
mount options to enable or disable it need to be cause mount errors.
Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>

(cherry picked from commit d3eaace8)
parent ad868afd
...@@ -33,6 +33,9 @@ When mounting an XFS filesystem, the following options are accepted. ...@@ -33,6 +33,9 @@ When mounting an XFS filesystem, the following options are accepted.
removing extended attributes) the on-disk superblock feature removing extended attributes) the on-disk superblock feature
bit field will be updated to reflect this format being in use. bit field will be updated to reflect this format being in use.
CRC enabled filesystems always use the attr2 format, and so
will reject the noattr2 mount option if it is set.
barrier barrier
Enables the use of block layer write barriers for writes into Enables the use of block layer write barriers for writes into
the journal and unwritten extent conversion. This allows for the journal and unwritten extent conversion. This allows for
......
...@@ -1372,6 +1372,17 @@ xfs_finish_flags( ...@@ -1372,6 +1372,17 @@ xfs_finish_flags(
} }
} }
/*
* V5 filesystems always use attr2 format for attributes.
*/
if (xfs_sb_version_hascrc(&mp->m_sb) &&
(mp->m_flags & XFS_MOUNT_NOATTR2)) {
xfs_warn(mp,
"Cannot mount a V5 filesystem as %s. %s is always enabled for V5 filesystems.",
MNTOPT_NOATTR2, MNTOPT_ATTR2);
return XFS_ERROR(EINVAL);
}
/* /*
* mkfs'ed attr2 will turn on attr2 mount unless explicitly * mkfs'ed attr2 will turn on attr2 mount unless explicitly
* told by noattr2 to turn it off * told by noattr2 to turn it off
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment