Commit f88ba6a2 authored by Hidetoshi Seto's avatar Hidetoshi Seto Committed by Josef Bacik

Btrfs: skip submitting barrier for missing device

I got an error on v3.13:
 BTRFS error (device sdf1) in write_all_supers:3378: errno=-5 IO failure (errors while submitting device barriers.)

how to reproduce:
  > mkfs.btrfs -f -d raid1 /dev/sdf1 /dev/sdf2
  > wipefs -a /dev/sdf2
  > mount -o degraded /dev/sdf1 /mnt
  > btrfs balance start -f -sconvert=single -mconvert=single -dconvert=single /mnt

The reason of the error is that barrier_all_devices() failed to submit
barrier to the missing device.  However it is clear that we cannot do
anything on missing device, and also it is not necessary to care chunks
on the missing device.

This patch stops sending/waiting barrier if device is missing.
Signed-off-by: default avatarHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJosef Bacik <jbacik@fb.com>
parent 29bce2f3
...@@ -3256,6 +3256,8 @@ static int barrier_all_devices(struct btrfs_fs_info *info) ...@@ -3256,6 +3256,8 @@ static int barrier_all_devices(struct btrfs_fs_info *info)
/* send down all the barriers */ /* send down all the barriers */
head = &info->fs_devices->devices; head = &info->fs_devices->devices;
list_for_each_entry_rcu(dev, head, dev_list) { list_for_each_entry_rcu(dev, head, dev_list) {
if (dev->missing)
continue;
if (!dev->bdev) { if (!dev->bdev) {
errors_send++; errors_send++;
continue; continue;
...@@ -3270,6 +3272,8 @@ static int barrier_all_devices(struct btrfs_fs_info *info) ...@@ -3270,6 +3272,8 @@ static int barrier_all_devices(struct btrfs_fs_info *info)
/* wait for all the barriers */ /* wait for all the barriers */
list_for_each_entry_rcu(dev, head, dev_list) { list_for_each_entry_rcu(dev, head, dev_list) {
if (dev->missing)
continue;
if (!dev->bdev) { if (!dev->bdev) {
errors_wait++; errors_wait++;
continue; continue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment