Commit f892e66f authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown

ASoC: rt-sdw*: add __func__ to all error logs

The drivers for Realtek SoundWire codecs use similar logs, which is
problematic to analyze problems reported by CI tools, e.g. "Failed to
get private value: 752001 => 0000 ret=-5". It's not uncommon to have
several Realtek devices on the same platform, having the same log
thrown makes support difficult.

This patch adds __func__ to all error logs which didn't already
include it.

No functionality change, only error logs are modified.
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Link: https://msgid.link/r/20240325221817.206465-7-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent adb354bb
...@@ -537,7 +537,7 @@ static int rt1316_sdw_hw_params(struct snd_pcm_substream *substream, ...@@ -537,7 +537,7 @@ static int rt1316_sdw_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt1316->sdw_slave, &stream_config, retval = sdw_stream_add_slave(rt1316->sdw_slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
...@@ -577,12 +577,12 @@ static int rt1316_sdw_parse_dt(struct rt1316_sdw_priv *rt1316, struct device *de ...@@ -577,12 +577,12 @@ static int rt1316_sdw_parse_dt(struct rt1316_sdw_priv *rt1316, struct device *de
if (rt1316->bq_params_cnt) { if (rt1316->bq_params_cnt) {
rt1316->bq_params = devm_kzalloc(dev, rt1316->bq_params_cnt, GFP_KERNEL); rt1316->bq_params = devm_kzalloc(dev, rt1316->bq_params_cnt, GFP_KERNEL);
if (!rt1316->bq_params) { if (!rt1316->bq_params) {
dev_err(dev, "Could not allocate bq_params memory\n"); dev_err(dev, "%s: Could not allocate bq_params memory\n", __func__);
ret = -ENOMEM; ret = -ENOMEM;
} else { } else {
ret = device_property_read_u8_array(dev, "realtek,bq-params", rt1316->bq_params, rt1316->bq_params_cnt); ret = device_property_read_u8_array(dev, "realtek,bq-params", rt1316->bq_params, rt1316->bq_params_cnt);
if (ret < 0) if (ret < 0)
dev_err(dev, "Could not read list of realtek,bq-params\n"); dev_err(dev, "%s: Could not read list of realtek,bq-params\n", __func__);
} }
} }
...@@ -759,7 +759,7 @@ static int __maybe_unused rt1316_dev_resume(struct device *dev) ...@@ -759,7 +759,7 @@ static int __maybe_unused rt1316_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT1316_PROBE_TIMEOUT)); msecs_to_jiffies(RT1316_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
sdw_show_ping_status(slave->bus, true); sdw_show_ping_status(slave->bus, true);
return -ETIMEDOUT; return -ETIMEDOUT;
......
...@@ -606,7 +606,7 @@ static int rt1318_sdw_hw_params(struct snd_pcm_substream *substream, ...@@ -606,7 +606,7 @@ static int rt1318_sdw_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt1318->sdw_slave, &stream_config, retval = sdw_stream_add_slave(rt1318->sdw_slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
...@@ -631,8 +631,8 @@ static int rt1318_sdw_hw_params(struct snd_pcm_substream *substream, ...@@ -631,8 +631,8 @@ static int rt1318_sdw_hw_params(struct snd_pcm_substream *substream,
sampling_rate = RT1318_SDCA_RATE_192000HZ; sampling_rate = RT1318_SDCA_RATE_192000HZ;
break; break;
default: default:
dev_err(component->dev, "Rate %d is not supported\n", dev_err(component->dev, "%s: Rate %d is not supported\n",
params_rate(params)); __func__, params_rate(params));
return -EINVAL; return -EINVAL;
} }
...@@ -835,7 +835,7 @@ static int __maybe_unused rt1318_dev_resume(struct device *dev) ...@@ -835,7 +835,7 @@ static int __maybe_unused rt1318_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT1318_PROBE_TIMEOUT)); msecs_to_jiffies(RT1318_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
...@@ -132,7 +132,7 @@ static int rt5682_sdw_hw_params(struct snd_pcm_substream *substream, ...@@ -132,7 +132,7 @@ static int rt5682_sdw_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt5682->slave, &stream_config, retval = sdw_stream_add_slave(rt5682->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
...@@ -315,8 +315,8 @@ static int rt5682_sdw_init(struct device *dev, struct regmap *regmap, ...@@ -315,8 +315,8 @@ static int rt5682_sdw_init(struct device *dev, struct regmap *regmap,
&rt5682_sdw_indirect_regmap); &rt5682_sdw_indirect_regmap);
if (IS_ERR(rt5682->regmap)) { if (IS_ERR(rt5682->regmap)) {
ret = PTR_ERR(rt5682->regmap); ret = PTR_ERR(rt5682->regmap);
dev_err(dev, "Failed to allocate register map: %d\n", dev_err(dev, "%s: Failed to allocate register map: %d\n",
ret); __func__, ret);
return ret; return ret;
} }
...@@ -400,7 +400,7 @@ static int rt5682_io_init(struct device *dev, struct sdw_slave *slave) ...@@ -400,7 +400,7 @@ static int rt5682_io_init(struct device *dev, struct sdw_slave *slave)
} }
if (val != DEVICE_ID) { if (val != DEVICE_ID) {
dev_err(dev, "Device with ID register %x is not rt5682\n", val); dev_err(dev, "%s: Device with ID register %x is not rt5682\n", __func__, val);
ret = -ENODEV; ret = -ENODEV;
goto err_nodev; goto err_nodev;
} }
...@@ -648,7 +648,7 @@ static int rt5682_bus_config(struct sdw_slave *slave, ...@@ -648,7 +648,7 @@ static int rt5682_bus_config(struct sdw_slave *slave,
ret = rt5682_clock_config(&slave->dev); ret = rt5682_clock_config(&slave->dev);
if (ret < 0) if (ret < 0)
dev_err(&slave->dev, "Invalid clk config"); dev_err(&slave->dev, "%s: Invalid clk config", __func__);
return ret; return ret;
} }
...@@ -775,7 +775,7 @@ static int __maybe_unused rt5682_dev_resume(struct device *dev) ...@@ -775,7 +775,7 @@ static int __maybe_unused rt5682_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT5682_PROBE_TIMEOUT)); msecs_to_jiffies(RT5682_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
sdw_show_ping_status(slave->bus, true); sdw_show_ping_status(slave->bus, true);
return -ETIMEDOUT; return -ETIMEDOUT;
......
...@@ -37,8 +37,8 @@ static int rt700_index_write(struct regmap *regmap, ...@@ -37,8 +37,8 @@ static int rt700_index_write(struct regmap *regmap,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
pr_err("Failed to set private value: %06x <= %04x ret=%d\n", pr_err("%s: Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -52,8 +52,8 @@ static int rt700_index_read(struct regmap *regmap, ...@@ -52,8 +52,8 @@ static int rt700_index_read(struct regmap *regmap,
*value = 0; *value = 0;
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
pr_err("Failed to get private value: %06x => %04x ret=%d\n", pr_err("%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -930,14 +930,14 @@ static int rt700_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -930,14 +930,14 @@ static int rt700_pcm_hw_params(struct snd_pcm_substream *substream,
port_config.num += 2; port_config.num += 2;
break; break;
default: default:
dev_err(component->dev, "Invalid DAI id %d\n", dai->id); dev_err(component->dev, "%s: Invalid DAI id %d\n", __func__, dai->id);
return -EINVAL; return -EINVAL;
} }
retval = sdw_stream_add_slave(rt700->slave, &stream_config, retval = sdw_stream_add_slave(rt700->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
...@@ -945,8 +945,8 @@ static int rt700_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -945,8 +945,8 @@ static int rt700_pcm_hw_params(struct snd_pcm_substream *substream,
/* bit 3:0 Number of Channel */ /* bit 3:0 Number of Channel */
val |= (params_channels(params) - 1); val |= (params_channels(params) - 1);
} else { } else {
dev_err(component->dev, "Unsupported channels %d\n", dev_err(component->dev, "%s: Unsupported channels %d\n",
params_channels(params)); __func__, params_channels(params));
return -EINVAL; return -EINVAL;
} }
......
...@@ -451,7 +451,7 @@ static int __maybe_unused rt711_sdca_dev_resume(struct device *dev) ...@@ -451,7 +451,7 @@ static int __maybe_unused rt711_sdca_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT711_PROBE_TIMEOUT)); msecs_to_jiffies(RT711_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
sdw_show_ping_status(slave->bus, true); sdw_show_ping_status(slave->bus, true);
return -ETIMEDOUT; return -ETIMEDOUT;
......
...@@ -36,8 +36,8 @@ static int rt711_sdca_index_write(struct rt711_sdca_priv *rt711, ...@@ -36,8 +36,8 @@ static int rt711_sdca_index_write(struct rt711_sdca_priv *rt711,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt711->slave->dev, dev_err(&rt711->slave->dev,
"Failed to set private value: %06x <= %04x ret=%d\n", "%s: Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -52,8 +52,8 @@ static int rt711_sdca_index_read(struct rt711_sdca_priv *rt711, ...@@ -52,8 +52,8 @@ static int rt711_sdca_index_read(struct rt711_sdca_priv *rt711,
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt711->slave->dev, dev_err(&rt711->slave->dev,
"Failed to get private value: %06x => %04x ret=%d\n", "%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -1293,13 +1293,13 @@ static int rt711_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1293,13 +1293,13 @@ static int rt711_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt711->slave, &stream_config, retval = sdw_stream_add_slave(rt711->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
if (params_channels(params) > 16) { if (params_channels(params) > 16) {
dev_err(component->dev, "Unsupported channels %d\n", dev_err(component->dev, "%s: Unsupported channels %d\n",
params_channels(params)); __func__, params_channels(params));
return -EINVAL; return -EINVAL;
} }
...@@ -1318,8 +1318,8 @@ static int rt711_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1318,8 +1318,8 @@ static int rt711_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
sampling_rate = RT711_SDCA_RATE_192000HZ; sampling_rate = RT711_SDCA_RATE_192000HZ;
break; break;
default: default:
dev_err(component->dev, "Rate %d is not supported\n", dev_err(component->dev, "%s: Rate %d is not supported\n",
params_rate(params)); __func__, params_rate(params));
return -EINVAL; return -EINVAL;
} }
......
...@@ -408,7 +408,7 @@ static int rt711_bus_config(struct sdw_slave *slave, ...@@ -408,7 +408,7 @@ static int rt711_bus_config(struct sdw_slave *slave,
ret = rt711_clock_config(&slave->dev); ret = rt711_clock_config(&slave->dev);
if (ret < 0) if (ret < 0)
dev_err(&slave->dev, "Invalid clk config"); dev_err(&slave->dev, "%s: Invalid clk config", __func__);
return ret; return ret;
} }
...@@ -548,7 +548,7 @@ static int __maybe_unused rt711_dev_resume(struct device *dev) ...@@ -548,7 +548,7 @@ static int __maybe_unused rt711_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT711_PROBE_TIMEOUT)); msecs_to_jiffies(RT711_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
return -ETIMEDOUT; return -ETIMEDOUT;
} }
......
...@@ -37,8 +37,8 @@ static int rt711_index_write(struct regmap *regmap, ...@@ -37,8 +37,8 @@ static int rt711_index_write(struct regmap *regmap,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
pr_err("Failed to set private value: %06x <= %04x ret=%d\n", pr_err("%s: Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -52,8 +52,8 @@ static int rt711_index_read(struct regmap *regmap, ...@@ -52,8 +52,8 @@ static int rt711_index_read(struct regmap *regmap,
*value = 0; *value = 0;
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
pr_err("Failed to get private value: %06x => %04x ret=%d\n", pr_err("%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -428,7 +428,7 @@ static void rt711_jack_init(struct rt711_priv *rt711) ...@@ -428,7 +428,7 @@ static void rt711_jack_init(struct rt711_priv *rt711)
RT711_HP_JD_FINAL_RESULT_CTL_JD12); RT711_HP_JD_FINAL_RESULT_CTL_JD12);
break; break;
default: default:
dev_warn(rt711->component->dev, "Wrong JD source\n"); dev_warn(rt711->component->dev, "%s: Wrong JD source\n", __func__);
break; break;
} }
...@@ -1020,7 +1020,7 @@ static int rt711_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1020,7 +1020,7 @@ static int rt711_pcm_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt711->slave, &stream_config, retval = sdw_stream_add_slave(rt711->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
...@@ -1028,8 +1028,8 @@ static int rt711_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1028,8 +1028,8 @@ static int rt711_pcm_hw_params(struct snd_pcm_substream *substream,
/* bit 3:0 Number of Channel */ /* bit 3:0 Number of Channel */
val |= (params_channels(params) - 1); val |= (params_channels(params) - 1);
} else { } else {
dev_err(component->dev, "Unsupported channels %d\n", dev_err(component->dev, "%s: Unsupported channels %d\n",
params_channels(params)); __func__, params_channels(params));
return -EINVAL; return -EINVAL;
} }
......
...@@ -139,8 +139,8 @@ static int rt712_sdca_dmic_index_write(struct rt712_sdca_dmic_priv *rt712, ...@@ -139,8 +139,8 @@ static int rt712_sdca_dmic_index_write(struct rt712_sdca_dmic_priv *rt712,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt712->slave->dev, dev_err(&rt712->slave->dev,
"Failed to set private value: %06x <= %04x ret=%d\n", "%s: Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -155,8 +155,8 @@ static int rt712_sdca_dmic_index_read(struct rt712_sdca_dmic_priv *rt712, ...@@ -155,8 +155,8 @@ static int rt712_sdca_dmic_index_read(struct rt712_sdca_dmic_priv *rt712,
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt712->slave->dev, dev_err(&rt712->slave->dev,
"Failed to get private value: %06x => %04x ret=%d\n", "%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -317,7 +317,8 @@ static int rt712_sdca_dmic_set_gain_put(struct snd_kcontrol *kcontrol, ...@@ -317,7 +317,8 @@ static int rt712_sdca_dmic_set_gain_put(struct snd_kcontrol *kcontrol,
for (i = 0; i < p->count; i++) { for (i = 0; i < p->count; i++) {
err = regmap_write(rt712->mbq_regmap, p->reg_base + i, gain_val[i]); err = regmap_write(rt712->mbq_regmap, p->reg_base + i, gain_val[i]);
if (err < 0) if (err < 0)
dev_err(&rt712->slave->dev, "0x%08x can't be set\n", p->reg_base + i); dev_err(&rt712->slave->dev, "%s: 0x%08x can't be set\n",
__func__, p->reg_base + i);
} }
return changed; return changed;
...@@ -667,13 +668,13 @@ static int rt712_sdca_dmic_hw_params(struct snd_pcm_substream *substream, ...@@ -667,13 +668,13 @@ static int rt712_sdca_dmic_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt712->slave, &stream_config, retval = sdw_stream_add_slave(rt712->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
if (params_channels(params) > 4) { if (params_channels(params) > 4) {
dev_err(component->dev, "Unsupported channels %d\n", dev_err(component->dev, "%s: Unsupported channels %d\n",
params_channels(params)); __func__, params_channels(params));
return -EINVAL; return -EINVAL;
} }
...@@ -698,8 +699,8 @@ static int rt712_sdca_dmic_hw_params(struct snd_pcm_substream *substream, ...@@ -698,8 +699,8 @@ static int rt712_sdca_dmic_hw_params(struct snd_pcm_substream *substream,
sampling_rate = RT712_SDCA_RATE_192000HZ; sampling_rate = RT712_SDCA_RATE_192000HZ;
break; break;
default: default:
dev_err(component->dev, "Rate %d is not supported\n", dev_err(component->dev, "%s: Rate %d is not supported\n",
params_rate(params)); __func__, params_rate(params));
return -EINVAL; return -EINVAL;
} }
...@@ -923,7 +924,8 @@ static int __maybe_unused rt712_sdca_dmic_dev_resume(struct device *dev) ...@@ -923,7 +924,8 @@ static int __maybe_unused rt712_sdca_dmic_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT712_PROBE_TIMEOUT)); msecs_to_jiffies(RT712_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n",
__func__);
sdw_show_ping_status(slave->bus, true); sdw_show_ping_status(slave->bus, true);
return -ETIMEDOUT; return -ETIMEDOUT;
......
...@@ -452,7 +452,7 @@ static int __maybe_unused rt712_sdca_dev_resume(struct device *dev) ...@@ -452,7 +452,7 @@ static int __maybe_unused rt712_sdca_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT712_PROBE_TIMEOUT)); msecs_to_jiffies(RT712_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
sdw_show_ping_status(slave->bus, true); sdw_show_ping_status(slave->bus, true);
return -ETIMEDOUT; return -ETIMEDOUT;
......
...@@ -34,8 +34,8 @@ static int rt712_sdca_index_write(struct rt712_sdca_priv *rt712, ...@@ -34,8 +34,8 @@ static int rt712_sdca_index_write(struct rt712_sdca_priv *rt712,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt712->slave->dev, dev_err(&rt712->slave->dev,
"Failed to set private value: %06x <= %04x ret=%d\n", "%s: Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -50,8 +50,8 @@ static int rt712_sdca_index_read(struct rt712_sdca_priv *rt712, ...@@ -50,8 +50,8 @@ static int rt712_sdca_index_read(struct rt712_sdca_priv *rt712,
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt712->slave->dev, dev_err(&rt712->slave->dev,
"Failed to get private value: %06x => %04x ret=%d\n", "%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -1060,13 +1060,13 @@ static int rt712_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1060,13 +1060,13 @@ static int rt712_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt712->slave, &stream_config, retval = sdw_stream_add_slave(rt712->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
if (params_channels(params) > 16) { if (params_channels(params) > 16) {
dev_err(component->dev, "Unsupported channels %d\n", dev_err(component->dev, "%s: Unsupported channels %d\n",
params_channels(params)); __func__, params_channels(params));
return -EINVAL; return -EINVAL;
} }
...@@ -1085,8 +1085,8 @@ static int rt712_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1085,8 +1085,8 @@ static int rt712_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
sampling_rate = RT712_SDCA_RATE_192000HZ; sampling_rate = RT712_SDCA_RATE_192000HZ;
break; break;
default: default:
dev_err(component->dev, "Rate %d is not supported\n", dev_err(component->dev, "%s: Rate %d is not supported\n",
params_rate(params)); __func__, params_rate(params));
return -EINVAL; return -EINVAL;
} }
...@@ -1106,7 +1106,7 @@ static int rt712_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1106,7 +1106,7 @@ static int rt712_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
sampling_rate); sampling_rate);
break; break;
default: default:
dev_err(component->dev, "Wrong DAI id\n"); dev_err(component->dev, "%s: Wrong DAI id\n", __func__);
return -EINVAL; return -EINVAL;
} }
......
...@@ -237,7 +237,7 @@ static int __maybe_unused rt715_dev_resume(struct device *dev) ...@@ -237,7 +237,7 @@ static int __maybe_unused rt715_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->enumeration_complete, time = wait_for_completion_timeout(&slave->enumeration_complete,
msecs_to_jiffies(RT715_PROBE_TIMEOUT)); msecs_to_jiffies(RT715_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Enumeration not complete, timed out\n"); dev_err(&slave->dev, "%s: Enumeration not complete, timed out\n", __func__);
sdw_show_ping_status(slave->bus, true); sdw_show_ping_status(slave->bus, true);
return -ETIMEDOUT; return -ETIMEDOUT;
......
...@@ -41,8 +41,8 @@ static int rt715_sdca_index_write(struct rt715_sdca_priv *rt715, ...@@ -41,8 +41,8 @@ static int rt715_sdca_index_write(struct rt715_sdca_priv *rt715,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt715->slave->dev, dev_err(&rt715->slave->dev,
"Failed to set private value: %08x <= %04x %d\n", "%s: Failed to set private value: %08x <= %04x %d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -59,8 +59,8 @@ static int rt715_sdca_index_read(struct rt715_sdca_priv *rt715, ...@@ -59,8 +59,8 @@ static int rt715_sdca_index_read(struct rt715_sdca_priv *rt715,
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt715->slave->dev, dev_err(&rt715->slave->dev,
"Failed to get private value: %06x => %04x ret=%d\n", "%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -152,8 +152,8 @@ static int rt715_sdca_set_amp_gain_put(struct snd_kcontrol *kcontrol, ...@@ -152,8 +152,8 @@ static int rt715_sdca_set_amp_gain_put(struct snd_kcontrol *kcontrol,
mc->shift); mc->shift);
ret = regmap_write(rt715->mbq_regmap, mc->reg + i, gain_val); ret = regmap_write(rt715->mbq_regmap, mc->reg + i, gain_val);
if (ret != 0) { if (ret != 0) {
dev_err(component->dev, "Failed to write 0x%x=0x%x\n", dev_err(component->dev, "%s: Failed to write 0x%x=0x%x\n",
mc->reg + i, gain_val); __func__, mc->reg + i, gain_val);
return ret; return ret;
} }
} }
...@@ -188,8 +188,8 @@ static int rt715_sdca_set_amp_gain_4ch_put(struct snd_kcontrol *kcontrol, ...@@ -188,8 +188,8 @@ static int rt715_sdca_set_amp_gain_4ch_put(struct snd_kcontrol *kcontrol,
ret = regmap_write(rt715->mbq_regmap, reg_base + i, ret = regmap_write(rt715->mbq_regmap, reg_base + i,
gain_val); gain_val);
if (ret != 0) { if (ret != 0) {
dev_err(component->dev, "Failed to write 0x%x=0x%x\n", dev_err(component->dev, "%s: Failed to write 0x%x=0x%x\n",
reg_base + i, gain_val); __func__, reg_base + i, gain_val);
return ret; return ret;
} }
} }
...@@ -224,8 +224,8 @@ static int rt715_sdca_set_amp_gain_8ch_put(struct snd_kcontrol *kcontrol, ...@@ -224,8 +224,8 @@ static int rt715_sdca_set_amp_gain_8ch_put(struct snd_kcontrol *kcontrol,
reg = i < 7 ? reg_base + i : (reg_base - 1) | BIT(15); reg = i < 7 ? reg_base + i : (reg_base - 1) | BIT(15);
ret = regmap_write(rt715->mbq_regmap, reg, gain_val); ret = regmap_write(rt715->mbq_regmap, reg, gain_val);
if (ret != 0) { if (ret != 0) {
dev_err(component->dev, "Failed to write 0x%x=0x%x\n", dev_err(component->dev, "%s: Failed to write 0x%x=0x%x\n",
reg, gain_val); __func__, reg, gain_val);
return ret; return ret;
} }
} }
...@@ -246,8 +246,8 @@ static int rt715_sdca_set_amp_gain_get(struct snd_kcontrol *kcontrol, ...@@ -246,8 +246,8 @@ static int rt715_sdca_set_amp_gain_get(struct snd_kcontrol *kcontrol,
for (i = 0; i < 2; i++) { for (i = 0; i < 2; i++) {
ret = regmap_read(rt715->mbq_regmap, mc->reg + i, &val); ret = regmap_read(rt715->mbq_regmap, mc->reg + i, &val);
if (ret < 0) { if (ret < 0) {
dev_err(component->dev, "Failed to read 0x%x, ret=%d\n", dev_err(component->dev, "%s: Failed to read 0x%x, ret=%d\n",
mc->reg + i, ret); __func__, mc->reg + i, ret);
return ret; return ret;
} }
ucontrol->value.integer.value[i] = rt715_sdca_get_gain(val, mc->shift); ucontrol->value.integer.value[i] = rt715_sdca_get_gain(val, mc->shift);
...@@ -271,8 +271,8 @@ static int rt715_sdca_set_amp_gain_4ch_get(struct snd_kcontrol *kcontrol, ...@@ -271,8 +271,8 @@ static int rt715_sdca_set_amp_gain_4ch_get(struct snd_kcontrol *kcontrol,
for (i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
ret = regmap_read(rt715->mbq_regmap, reg_base + i, &val); ret = regmap_read(rt715->mbq_regmap, reg_base + i, &val);
if (ret < 0) { if (ret < 0) {
dev_err(component->dev, "Failed to read 0x%x, ret=%d\n", dev_err(component->dev, "%s: Failed to read 0x%x, ret=%d\n",
reg_base + i, ret); __func__, reg_base + i, ret);
return ret; return ret;
} }
ucontrol->value.integer.value[i] = rt715_sdca_get_gain(val, gain_sft); ucontrol->value.integer.value[i] = rt715_sdca_get_gain(val, gain_sft);
...@@ -297,8 +297,8 @@ static int rt715_sdca_set_amp_gain_8ch_get(struct snd_kcontrol *kcontrol, ...@@ -297,8 +297,8 @@ static int rt715_sdca_set_amp_gain_8ch_get(struct snd_kcontrol *kcontrol,
for (i = 0; i < 8; i += 2) { for (i = 0; i < 8; i += 2) {
ret = regmap_read(rt715->mbq_regmap, reg_base + i, &val_l); ret = regmap_read(rt715->mbq_regmap, reg_base + i, &val_l);
if (ret < 0) { if (ret < 0) {
dev_err(component->dev, "Failed to read 0x%x, ret=%d\n", dev_err(component->dev, "%s: Failed to read 0x%x, ret=%d\n",
reg_base + i, ret); __func__, reg_base + i, ret);
return ret; return ret;
} }
ucontrol->value.integer.value[i] = (val_l >> gain_sft) / 10; ucontrol->value.integer.value[i] = (val_l >> gain_sft) / 10;
...@@ -306,8 +306,8 @@ static int rt715_sdca_set_amp_gain_8ch_get(struct snd_kcontrol *kcontrol, ...@@ -306,8 +306,8 @@ static int rt715_sdca_set_amp_gain_8ch_get(struct snd_kcontrol *kcontrol,
reg = (i == 6) ? (reg_base - 1) | BIT(15) : reg_base + 1 + i; reg = (i == 6) ? (reg_base - 1) | BIT(15) : reg_base + 1 + i;
ret = regmap_read(rt715->mbq_regmap, reg, &val_r); ret = regmap_read(rt715->mbq_regmap, reg, &val_r);
if (ret < 0) { if (ret < 0) {
dev_err(component->dev, "Failed to read 0x%x, ret=%d\n", dev_err(component->dev, "%s: Failed to read 0x%x, ret=%d\n",
reg, ret); __func__, reg, ret);
return ret; return ret;
} }
ucontrol->value.integer.value[i + 1] = (val_r >> gain_sft) / 10; ucontrol->value.integer.value[i + 1] = (val_r >> gain_sft) / 10;
...@@ -834,15 +834,15 @@ static int rt715_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -834,15 +834,15 @@ static int rt715_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
0xaf00); 0xaf00);
break; break;
default: default:
dev_err(component->dev, "Invalid DAI id %d\n", dai->id); dev_err(component->dev, "%s: Invalid DAI id %d\n", __func__, dai->id);
return -EINVAL; return -EINVAL;
} }
retval = sdw_stream_add_slave(rt715->slave, &stream_config, retval = sdw_stream_add_slave(rt715->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(component->dev, "Unable to configure port, retval:%d\n", dev_err(component->dev, "%s: Unable to configure port, retval:%d\n",
retval); __func__, retval);
return retval; return retval;
} }
...@@ -893,8 +893,8 @@ static int rt715_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -893,8 +893,8 @@ static int rt715_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
val = 0xf; val = 0xf;
break; break;
default: default:
dev_err(component->dev, "Unsupported sample rate %d\n", dev_err(component->dev, "%s: Unsupported sample rate %d\n",
params_rate(params)); __func__, params_rate(params));
return -EINVAL; return -EINVAL;
} }
......
...@@ -482,7 +482,7 @@ static int rt715_bus_config(struct sdw_slave *slave, ...@@ -482,7 +482,7 @@ static int rt715_bus_config(struct sdw_slave *slave,
ret = rt715_clock_config(&slave->dev); ret = rt715_clock_config(&slave->dev);
if (ret < 0) if (ret < 0)
dev_err(&slave->dev, "Invalid clk config"); dev_err(&slave->dev, "%s: Invalid clk config", __func__);
return 0; return 0;
} }
...@@ -554,7 +554,7 @@ static int __maybe_unused rt715_dev_resume(struct device *dev) ...@@ -554,7 +554,7 @@ static int __maybe_unused rt715_dev_resume(struct device *dev)
time = wait_for_completion_timeout(&slave->initialization_complete, time = wait_for_completion_timeout(&slave->initialization_complete,
msecs_to_jiffies(RT715_PROBE_TIMEOUT)); msecs_to_jiffies(RT715_PROBE_TIMEOUT));
if (!time) { if (!time) {
dev_err(&slave->dev, "Initialization not complete, timed out\n"); dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
sdw_show_ping_status(slave->bus, true); sdw_show_ping_status(slave->bus, true);
return -ETIMEDOUT; return -ETIMEDOUT;
......
...@@ -40,8 +40,8 @@ static int rt715_index_write(struct regmap *regmap, unsigned int reg, ...@@ -40,8 +40,8 @@ static int rt715_index_write(struct regmap *regmap, unsigned int reg,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) { if (ret < 0) {
pr_err("Failed to set private value: %08x <= %04x %d\n", pr_err("%s: Failed to set private value: %08x <= %04x %d\n",
addr, value, ret); __func__, addr, value, ret);
} }
return ret; return ret;
...@@ -55,8 +55,8 @@ static int rt715_index_write_nid(struct regmap *regmap, ...@@ -55,8 +55,8 @@ static int rt715_index_write_nid(struct regmap *regmap,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
pr_err("Failed to set private value: %06x <= %04x ret=%d\n", pr_err("%s: Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -70,8 +70,8 @@ static int rt715_index_read_nid(struct regmap *regmap, ...@@ -70,8 +70,8 @@ static int rt715_index_read_nid(struct regmap *regmap,
*value = 0; *value = 0;
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
pr_err("Failed to get private value: %06x => %04x ret=%d\n", pr_err("%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -862,14 +862,14 @@ static int rt715_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -862,14 +862,14 @@ static int rt715_pcm_hw_params(struct snd_pcm_substream *substream,
rt715_index_write(rt715->regmap, RT715_SDW_INPUT_SEL, 0xa000); rt715_index_write(rt715->regmap, RT715_SDW_INPUT_SEL, 0xa000);
break; break;
default: default:
dev_err(component->dev, "Invalid DAI id %d\n", dai->id); dev_err(component->dev, "%s: Invalid DAI id %d\n", __func__, dai->id);
return -EINVAL; return -EINVAL;
} }
retval = sdw_stream_add_slave(rt715->slave, &stream_config, retval = sdw_stream_add_slave(rt715->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
...@@ -883,8 +883,8 @@ static int rt715_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -883,8 +883,8 @@ static int rt715_pcm_hw_params(struct snd_pcm_substream *substream,
val |= 0x0 << 8; val |= 0x0 << 8;
break; break;
default: default:
dev_err(component->dev, "Unsupported sample rate %d\n", dev_err(component->dev, "%s: Unsupported sample rate %d\n",
params_rate(params)); __func__, params_rate(params));
return -EINVAL; return -EINVAL;
} }
...@@ -892,8 +892,8 @@ static int rt715_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -892,8 +892,8 @@ static int rt715_pcm_hw_params(struct snd_pcm_substream *substream,
/* bit 3:0 Number of Channel */ /* bit 3:0 Number of Channel */
val |= (params_channels(params) - 1); val |= (params_channels(params) - 1);
} else { } else {
dev_err(component->dev, "Unsupported channels %d\n", dev_err(component->dev, "%s: Unsupported channels %d\n",
params_channels(params)); __func__, params_channels(params));
return -EINVAL; return -EINVAL;
} }
......
...@@ -35,8 +35,8 @@ int rt722_sdca_index_write(struct rt722_sdca_priv *rt722, ...@@ -35,8 +35,8 @@ int rt722_sdca_index_write(struct rt722_sdca_priv *rt722,
ret = regmap_write(regmap, addr, value); ret = regmap_write(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt722->slave->dev, dev_err(&rt722->slave->dev,
"Failed to set private value: %06x <= %04x ret=%d\n", "%s: Failed to set private value: %06x <= %04x ret=%d\n",
addr, value, ret); __func__, addr, value, ret);
return ret; return ret;
} }
...@@ -51,8 +51,8 @@ int rt722_sdca_index_read(struct rt722_sdca_priv *rt722, ...@@ -51,8 +51,8 @@ int rt722_sdca_index_read(struct rt722_sdca_priv *rt722,
ret = regmap_read(regmap, addr, value); ret = regmap_read(regmap, addr, value);
if (ret < 0) if (ret < 0)
dev_err(&rt722->slave->dev, dev_err(&rt722->slave->dev,
"Failed to get private value: %06x => %04x ret=%d\n", "%s: Failed to get private value: %06x => %04x ret=%d\n",
addr, *value, ret); __func__, addr, *value, ret);
return ret; return ret;
} }
...@@ -663,7 +663,8 @@ static int rt722_sdca_dmic_set_gain_put(struct snd_kcontrol *kcontrol, ...@@ -663,7 +663,8 @@ static int rt722_sdca_dmic_set_gain_put(struct snd_kcontrol *kcontrol,
for (i = 0; i < p->count; i++) { for (i = 0; i < p->count; i++) {
err = regmap_write(rt722->mbq_regmap, p->reg_base + i, gain_val[i]); err = regmap_write(rt722->mbq_regmap, p->reg_base + i, gain_val[i]);
if (err < 0) if (err < 0)
dev_err(&rt722->slave->dev, "%#08x can't be set\n", p->reg_base + i); dev_err(&rt722->slave->dev, "%s: %#08x can't be set\n",
__func__, p->reg_base + i);
} }
return changed; return changed;
...@@ -1211,13 +1212,13 @@ static int rt722_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1211,13 +1212,13 @@ static int rt722_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
retval = sdw_stream_add_slave(rt722->slave, &stream_config, retval = sdw_stream_add_slave(rt722->slave, &stream_config,
&port_config, 1, sdw_stream); &port_config, 1, sdw_stream);
if (retval) { if (retval) {
dev_err(dai->dev, "Unable to configure port\n"); dev_err(dai->dev, "%s: Unable to configure port\n", __func__);
return retval; return retval;
} }
if (params_channels(params) > 16) { if (params_channels(params) > 16) {
dev_err(component->dev, "Unsupported channels %d\n", dev_err(component->dev, "%s: Unsupported channels %d\n",
params_channels(params)); __func__, params_channels(params));
return -EINVAL; return -EINVAL;
} }
...@@ -1236,8 +1237,8 @@ static int rt722_sdca_pcm_hw_params(struct snd_pcm_substream *substream, ...@@ -1236,8 +1237,8 @@ static int rt722_sdca_pcm_hw_params(struct snd_pcm_substream *substream,
sampling_rate = RT722_SDCA_RATE_192000HZ; sampling_rate = RT722_SDCA_RATE_192000HZ;
break; break;
default: default:
dev_err(component->dev, "Rate %d is not supported\n", dev_err(component->dev, "%s: Rate %d is not supported\n",
params_rate(params)); __func__, params_rate(params));
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment