Commit f8d825bf authored by Jan Veldeman's avatar Jan Veldeman Committed by Greg Kroah-Hartman

[PATCH] Driver core: Documentation: fix whitespace between parameters

Fix whitespace after comma between parameters.
Signed-off-by: default avatarJan Veldeman <Jan.Veldeman@advalvas.be>
Signed-off-by: default avatarDomen Puncer <domen@coderock.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 9a8af6b3
...@@ -90,7 +90,7 @@ void device_remove_file(struct device *, struct device_attribute *); ...@@ -90,7 +90,7 @@ void device_remove_file(struct device *, struct device_attribute *);
It also defines this helper for defining device attributes: It also defines this helper for defining device attributes:
#define DEVICE_ATTR(_name,_mode,_show,_store) \ #define DEVICE_ATTR(_name, _mode, _show, _store) \
struct device_attribute dev_attr_##_name = { \ struct device_attribute dev_attr_##_name = { \
.attr = {.name = __stringify(_name) , .mode = _mode }, \ .attr = {.name = __stringify(_name) , .mode = _mode }, \
.show = _show, \ .show = _show, \
...@@ -99,7 +99,7 @@ struct device_attribute dev_attr_##_name = { \ ...@@ -99,7 +99,7 @@ struct device_attribute dev_attr_##_name = { \
For example, declaring For example, declaring
static DEVICE_ATTR(foo,0644,show_foo,store_foo); static DEVICE_ATTR(foo, 0644, show_foo, store_foo);
is equivalent to doing: is equivalent to doing:
...@@ -121,8 +121,8 @@ set of sysfs operations for forwarding read and write calls to the ...@@ -121,8 +121,8 @@ set of sysfs operations for forwarding read and write calls to the
show and store methods of the attribute owners. show and store methods of the attribute owners.
struct sysfs_ops { struct sysfs_ops {
ssize_t (*show)(struct kobject *, struct attribute *,char *); ssize_t (*show)(struct kobject *, struct attribute *, char *);
ssize_t (*store)(struct kobject *,struct attribute *,const char *); ssize_t (*store)(struct kobject *, struct attribute *, const char *);
}; };
[ Subsystems should have already defined a struct kobj_type as a [ Subsystems should have already defined a struct kobj_type as a
...@@ -137,7 +137,7 @@ calls the associated methods. ...@@ -137,7 +137,7 @@ calls the associated methods.
To illustrate: To illustrate:
#define to_dev_attr(_attr) container_of(_attr,struct device_attribute,attr) #define to_dev_attr(_attr) container_of(_attr, struct device_attribute, attr)
#define to_dev(d) container_of(d, struct device, kobj) #define to_dev(d) container_of(d, struct device, kobj)
static ssize_t static ssize_t
...@@ -148,7 +148,7 @@ dev_attr_show(struct kobject * kobj, struct attribute * attr, char * buf) ...@@ -148,7 +148,7 @@ dev_attr_show(struct kobject * kobj, struct attribute * attr, char * buf)
ssize_t ret = 0; ssize_t ret = 0;
if (dev_attr->show) if (dev_attr->show)
ret = dev_attr->show(dev,buf); ret = dev_attr->show(dev, buf);
return ret; return ret;
} }
...@@ -216,16 +216,16 @@ A very simple (and naive) implementation of a device attribute is: ...@@ -216,16 +216,16 @@ A very simple (and naive) implementation of a device attribute is:
static ssize_t show_name(struct device *dev, struct device_attribute *attr, char *buf) static ssize_t show_name(struct device *dev, struct device_attribute *attr, char *buf)
{ {
return sprintf(buf,"%s\n",dev->name); return snprintf(buf, PAGE_SIZE, "%s\n", dev->name);
} }
static ssize_t store_name(struct device * dev, const char * buf) static ssize_t store_name(struct device * dev, const char * buf)
{ {
sscanf(buf,"%20s",dev->name); sscanf(buf, "%20s", dev->name);
return strlen(buf); return strnlen(buf, PAGE_SIZE);
} }
static DEVICE_ATTR(name,S_IRUGO,show_name,store_name); static DEVICE_ATTR(name, S_IRUGO, show_name, store_name);
(Note that the real implementation doesn't allow userspace to set the (Note that the real implementation doesn't allow userspace to set the
...@@ -290,7 +290,7 @@ struct device_attribute { ...@@ -290,7 +290,7 @@ struct device_attribute {
Declaring: Declaring:
DEVICE_ATTR(_name,_str,_mode,_show,_store); DEVICE_ATTR(_name, _str, _mode, _show, _store);
Creation/Removal: Creation/Removal:
...@@ -310,7 +310,7 @@ struct bus_attribute { ...@@ -310,7 +310,7 @@ struct bus_attribute {
Declaring: Declaring:
BUS_ATTR(_name,_mode,_show,_store) BUS_ATTR(_name, _mode, _show, _store)
Creation/Removal: Creation/Removal:
...@@ -331,7 +331,7 @@ struct driver_attribute { ...@@ -331,7 +331,7 @@ struct driver_attribute {
Declaring: Declaring:
DRIVER_ATTR(_name,_mode,_show,_store) DRIVER_ATTR(_name, _mode, _show, _store)
Creation/Removal: Creation/Removal:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment