Commit f8d8b7a1 authored by Arnaud Patard (Rtp)'s avatar Arnaud Patard (Rtp) Committed by John W. Linville

rt2x00: fix "buffer size not provably correct" build warning

rt2x00 debugfs interface doesn't check the size of the data coming
from userspace, leading to a build warning. Fix That.

v2: return EINVAL if input is too long
Signed-off-by: default avatarArnaud Patard <arnaud.patard@rtp-net.org>
Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 8d1331b3
...@@ -480,6 +480,9 @@ static ssize_t rt2x00debug_write_##__name(struct file *file, \ ...@@ -480,6 +480,9 @@ static ssize_t rt2x00debug_write_##__name(struct file *file, \
if (index >= debug->__name.word_count) \ if (index >= debug->__name.word_count) \
return -EINVAL; \ return -EINVAL; \
\ \
if (length > sizeof(line)) \
return -EINVAL; \
\
if (copy_from_user(line, buf, length)) \ if (copy_from_user(line, buf, length)) \
return -EFAULT; \ return -EFAULT; \
\ \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment