Commit f8da964d authored by Vivek Goyal's avatar Vivek Goyal Committed by Linus Torvalds

kexec-bzimage64: fix sparse warnings

David Howells brought to my attention the mails generated by kbuild test
bot and following sparse warnings were present.  This patch fixes these
warnings.

  arch/x86/kernel/kexec-bzimage64.c:270:5: warning: symbol 'bzImage64_probe' was not declared. Should it be static?
  arch/x86/kernel/kexec-bzimage64.c:328:6: warning: symbol 'bzImage64_load' was not declared. Should it be static?
  arch/x86/kernel/kexec-bzimage64.c:517:5: warning: symbol 'bzImage64_cleanup' was not declared. Should it be static?
  arch/x86/kernel/kexec-bzimage64.c:531:5: warning: symbol 'bzImage64_verify_sig' was not declared. Should it be static?
  arch/x86/kernel/kexec-bzimage64.c:546:23: warning: symbol 'kexec_bzImage64_ops' was not declared. Should it be static?
Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
Reported-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 36f3f500
...@@ -26,6 +26,7 @@ ...@@ -26,6 +26,7 @@
#include <asm/setup.h> #include <asm/setup.h>
#include <asm/crash.h> #include <asm/crash.h>
#include <asm/efi.h> #include <asm/efi.h>
#include <asm/kexec-bzimage64.h>
#define MAX_ELFCOREHDR_STR_LEN 30 /* elfcorehdr=0x<64bit-value> */ #define MAX_ELFCOREHDR_STR_LEN 30 /* elfcorehdr=0x<64bit-value> */
...@@ -267,7 +268,7 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params, ...@@ -267,7 +268,7 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
return ret; return ret;
} }
int bzImage64_probe(const char *buf, unsigned long len) static int bzImage64_probe(const char *buf, unsigned long len)
{ {
int ret = -ENOEXEC; int ret = -ENOEXEC;
struct setup_header *header; struct setup_header *header;
...@@ -325,10 +326,10 @@ int bzImage64_probe(const char *buf, unsigned long len) ...@@ -325,10 +326,10 @@ int bzImage64_probe(const char *buf, unsigned long len)
return ret; return ret;
} }
void *bzImage64_load(struct kimage *image, char *kernel, static void *bzImage64_load(struct kimage *image, char *kernel,
unsigned long kernel_len, char *initrd, unsigned long kernel_len, char *initrd,
unsigned long initrd_len, char *cmdline, unsigned long initrd_len, char *cmdline,
unsigned long cmdline_len) unsigned long cmdline_len)
{ {
struct setup_header *header; struct setup_header *header;
...@@ -514,7 +515,7 @@ void *bzImage64_load(struct kimage *image, char *kernel, ...@@ -514,7 +515,7 @@ void *bzImage64_load(struct kimage *image, char *kernel,
} }
/* This cleanup function is called after various segments have been loaded */ /* This cleanup function is called after various segments have been loaded */
int bzImage64_cleanup(void *loader_data) static int bzImage64_cleanup(void *loader_data)
{ {
struct bzimage64_data *ldata = loader_data; struct bzimage64_data *ldata = loader_data;
...@@ -528,7 +529,7 @@ int bzImage64_cleanup(void *loader_data) ...@@ -528,7 +529,7 @@ int bzImage64_cleanup(void *loader_data)
} }
#ifdef CONFIG_KEXEC_BZIMAGE_VERIFY_SIG #ifdef CONFIG_KEXEC_BZIMAGE_VERIFY_SIG
int bzImage64_verify_sig(const char *kernel, unsigned long kernel_len) static int bzImage64_verify_sig(const char *kernel, unsigned long kernel_len)
{ {
bool trusted; bool trusted;
int ret; int ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment