Commit fa0c5e71 authored by Tomi Valkeinen's avatar Tomi Valkeinen

OMAPFB: fix error handling in omapfb_find_best_mode()

omapfb_find_best_mode() doesn't check for the return value of kmalloc.
Fix this. This also removes the smatch warning:

drivers/video/omap2/omapfb/omapfb-main.c:2256 omapfb_find_best_mode()
error: potential null dereference 'specs'.  (kzalloc returns null)
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 057eeaee
...@@ -2241,12 +2241,18 @@ static int omapfb_find_best_mode(struct omap_dss_device *display, ...@@ -2241,12 +2241,18 @@ static int omapfb_find_best_mode(struct omap_dss_device *display,
len = 0x80 * 2; len = 0x80 * 2;
edid = kmalloc(len, GFP_KERNEL); edid = kmalloc(len, GFP_KERNEL);
if (edid == NULL)
return -ENOMEM;
r = display->driver->read_edid(display, edid, len); r = display->driver->read_edid(display, edid, len);
if (r < 0) if (r < 0)
goto err1; goto err1;
specs = kzalloc(sizeof(*specs), GFP_KERNEL); specs = kzalloc(sizeof(*specs), GFP_KERNEL);
if (specs == NULL) {
r = -ENOMEM;
goto err1;
}
fb_edid_to_monspecs(edid, specs); fb_edid_to_monspecs(edid, specs);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment