Commit fa4bb7d3 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab

media: ov8856: Check reading clock frequency succeeded

Instead of blindly trusting getting the clock frequency succeeded end then
testing it against a pre-defined value, verify reading the value
succeeded.

Fixes: 879347f0 ("media: ov8856: Add support for OV8856 sensor")
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent bf27502b
...@@ -1106,7 +1106,10 @@ static int ov8856_check_hwcfg(struct device *dev) ...@@ -1106,7 +1106,10 @@ static int ov8856_check_hwcfg(struct device *dev)
if (!fwnode) if (!fwnode)
return -ENXIO; return -ENXIO;
fwnode_property_read_u32(fwnode, "clock-frequency", &mclk); ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
if (ret)
return ret;
if (mclk != OV8856_MCLK) { if (mclk != OV8856_MCLK) {
dev_err(dev, "external clock %d is not supported", mclk); dev_err(dev, "external clock %d is not supported", mclk);
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment