Commit fa50e2b4 authored by Ionela Voinescu's avatar Ionela Voinescu Committed by Peter Zijlstra

sched/topology: Condition EAS enablement on FIE support

In order to make accurate predictions across CPUs and for all performance
states, Energy Aware Scheduling (EAS) needs frequency-invariant load
tracking signals.

EAS task placement aims to minimize energy consumption, and does so in
part by limiting the search space to only CPUs with the highest spare
capacity (CPU capacity - CPU utilization) in their performance domain.
Those candidates are the placement choices that will keep frequency at
its lowest possible and therefore save the most energy.

But without frequency invariance, a CPU's utilization is relative to the
CPU's current performance level, and not relative to its maximum
performance level, which determines its capacity. As a result, it will
fail to correctly indicate any potential spare capacity obtained by an
increase in a CPU's performance level. Therefore, a non-invariant
utilization signal would render the EAS task placement logic invalid.

Now that we properly report support for the Frequency Invariance Engine
(FIE) through arch_scale_freq_invariant() for arm and arm64 systems,
while also ensuring a re-evaluation of the EAS use conditions for
possible invariance status change, we can assert this is the case when
initializing EAS. Warn and bail out otherwise.
Suggested-by: default avatarQuentin Perret <qperret@google.com>
Signed-off-by: default avatarIonela Voinescu <ionela.voinescu@arm.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20201027180713.7642-4-ionela.voinescu@arm.com
parent ecec9e86
...@@ -328,6 +328,7 @@ static void sched_energy_set(bool has_eas) ...@@ -328,6 +328,7 @@ static void sched_energy_set(bool has_eas)
* 3. no SMT is detected. * 3. no SMT is detected.
* 4. the EM complexity is low enough to keep scheduling overheads low; * 4. the EM complexity is low enough to keep scheduling overheads low;
* 5. schedutil is driving the frequency of all CPUs of the rd; * 5. schedutil is driving the frequency of all CPUs of the rd;
* 6. frequency invariance support is present;
* *
* The complexity of the Energy Model is defined as: * The complexity of the Energy Model is defined as:
* *
...@@ -376,6 +377,14 @@ static bool build_perf_domains(const struct cpumask *cpu_map) ...@@ -376,6 +377,14 @@ static bool build_perf_domains(const struct cpumask *cpu_map)
goto free; goto free;
} }
if (!arch_scale_freq_invariant()) {
if (sched_debug()) {
pr_warn("rd %*pbl: Disabling EAS: frequency-invariant load tracking not yet supported",
cpumask_pr_args(cpu_map));
}
goto free;
}
for_each_cpu(i, cpu_map) { for_each_cpu(i, cpu_map) {
/* Skip already covered CPUs. */ /* Skip already covered CPUs. */
if (find_pd(pd, i)) if (find_pd(pd, i))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment