Commit faa30dfa authored by Leo Yan's avatar Leo Yan Committed by Arnaldo Carvalho de Melo

perf c2c: Refactor display string

The display type is shown by combination the display string array and a
suffix string "HITMs", which is not friendly to extend display for other
sorting type (e.g. extension for peer operations).

This patch moves the suffix string "HITMs" into display string array for
HITM types, so it can allow us to not necessarily to output string
"HITMs" for new incoming display type.
Reviewed-by: default avatarAli Saidi <alisaidi@amazon.com>
Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
Tested-by: default avatarAli Saidi <alisaidi@amazon.com>
Acked-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: Gustavo A. R. Silva <gustavoars@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Like Xu <likexu@tencent.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Timothy Hayes <timothy.hayes@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20220811062451.435810-13-leo.yan@linaro.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 7c10b65a
...@@ -122,9 +122,9 @@ enum { ...@@ -122,9 +122,9 @@ enum {
}; };
static const char *display_str[DISPLAY_MAX] = { static const char *display_str[DISPLAY_MAX] = {
[DISPLAY_LCL_HITM] = "Local", [DISPLAY_LCL_HITM] = "Local HITMs",
[DISPLAY_RMT_HITM] = "Remote", [DISPLAY_RMT_HITM] = "Remote HITMs",
[DISPLAY_TOT_HITM] = "Total", [DISPLAY_TOT_HITM] = "Total HITMs",
}; };
static const struct option c2c_options[] = { static const struct option c2c_options[] = {
...@@ -2489,7 +2489,7 @@ static void print_c2c_info(FILE *out, struct perf_session *session) ...@@ -2489,7 +2489,7 @@ static void print_c2c_info(FILE *out, struct perf_session *session)
fprintf(out, "%-36s: %s\n", first ? " Events" : "", evsel__name(evsel)); fprintf(out, "%-36s: %s\n", first ? " Events" : "", evsel__name(evsel));
first = false; first = false;
} }
fprintf(out, " Cachelines sort on : %s HITMs\n", fprintf(out, " Cachelines sort on : %s\n",
display_str[c2c.display]); display_str[c2c.display]);
fprintf(out, " Cacheline data grouping : %s\n", c2c.cl_sort); fprintf(out, " Cacheline data grouping : %s\n", c2c.cl_sort);
} }
...@@ -2646,7 +2646,7 @@ static int perf_c2c_browser__title(struct hist_browser *browser, ...@@ -2646,7 +2646,7 @@ static int perf_c2c_browser__title(struct hist_browser *browser,
{ {
scnprintf(bf, size, scnprintf(bf, size,
"Shared Data Cache Line Table " "Shared Data Cache Line Table "
"(%lu entries, sorted on %s HITMs)", "(%lu entries, sorted on %s)",
browser->nr_non_filtered_entries, browser->nr_non_filtered_entries,
display_str[c2c.display]); display_str[c2c.display]);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment