Commit fafb6ebe authored by David S. Miller's avatar David S. Miller

Revert "atl1c: Fix misuse of netdev_alloc_skb in refilling rx ring"

This reverts commit ebe7fdba.

This change is not correct.  GFP_DMA is not necessary for
this device.

There is some other problem causing this bug.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebe7fdba
...@@ -1660,7 +1660,7 @@ static int atl1c_alloc_rx_buffer(struct atl1c_adapter *adapter) ...@@ -1660,7 +1660,7 @@ static int atl1c_alloc_rx_buffer(struct atl1c_adapter *adapter)
while (next_info->flags & ATL1C_BUFFER_FREE) { while (next_info->flags & ATL1C_BUFFER_FREE) {
rfd_desc = ATL1C_RFD_DESC(rfd_ring, rfd_next_to_use); rfd_desc = ATL1C_RFD_DESC(rfd_ring, rfd_next_to_use);
skb = __netdev_alloc_skb(adapter->netdev, adapter->rx_buffer_len, GFP_ATOMIC|GFP_DMA); skb = netdev_alloc_skb(adapter->netdev, adapter->rx_buffer_len);
if (unlikely(!skb)) { if (unlikely(!skb)) {
if (netif_msg_rx_err(adapter)) if (netif_msg_rx_err(adapter))
dev_warn(&pdev->dev, "alloc rx buffer failed\n"); dev_warn(&pdev->dev, "alloc rx buffer failed\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment