Commit fba3993e authored by Randy Dunlap's avatar Randy Dunlap Committed by Greg Kroah-Hartman

most: fix kernel-doc warnings

Fix various W=1 kernel-doc warnings in drivers/most/:

drivers/most/most_usb.c:669: warning: Excess function parameter 'data' description in 'link_stat_timer_handler'
drivers/most/most_usb.c:769: warning: cannot understand function prototype: 'const struct file_operations hdm_usb_fops = '
drivers/most/most_usb.c:776: warning: cannot understand function prototype: 'const struct usb_device_id usbid[] = '
drivers/most/most_cdev.c:301: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * Initialization of struct file_operations
drivers/most/most_cdev.c:414: warning: Function parameter or member 'args' not described in 'comp_probe'
drivers/most/most_snd.c:56: warning: Function parameter or member 'pcm_hardware' not described in 'channel'
drivers/most/most_snd.c:56: warning: Function parameter or member 'copy_fn' not described in 'channel'
drivers/most/most_snd.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * Initialization of struct snd_pcm_ops
drivers/most/most_snd.c:514: warning: Function parameter or member 'device_name' not described in 'audio_probe_channel'
drivers/most/most_snd.c:703: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * Initialization of the struct most_component
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Christian Gromm <christian.gromm@microchip.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20230113063947.23174-1-rdunlap@infradead.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ad228a34
...@@ -297,7 +297,7 @@ static __poll_t comp_poll(struct file *filp, poll_table *wait) ...@@ -297,7 +297,7 @@ static __poll_t comp_poll(struct file *filp, poll_table *wait)
return mask; return mask;
} }
/** /*
* Initialization of struct file_operations * Initialization of struct file_operations
*/ */
static const struct file_operations channel_fops = { static const struct file_operations channel_fops = {
...@@ -404,8 +404,9 @@ static int comp_tx_completion(struct most_interface *iface, int channel_id) ...@@ -404,8 +404,9 @@ static int comp_tx_completion(struct most_interface *iface, int channel_id)
* @channel_id: channel index/ID * @channel_id: channel index/ID
* @cfg: pointer to actual channel configuration * @cfg: pointer to actual channel configuration
* @name: name of the device to be created * @name: name of the device to be created
* @args: pointer to array of component parameters (from configfs)
* *
* This allocates achannel object and creates the device node in /dev * This allocates a channel object and creates the device node in /dev
* *
* Returns 0 on success or error code otherwise. * Returns 0 on success or error code otherwise.
*/ */
......
...@@ -27,6 +27,7 @@ static struct most_component comp; ...@@ -27,6 +27,7 @@ static struct most_component comp;
/** /**
* struct channel - private structure to keep channel specific data * struct channel - private structure to keep channel specific data
* @substream: stores the substream structure * @substream: stores the substream structure
* @pcm_hardware: low-level hardware description
* @iface: interface for which the channel belongs to * @iface: interface for which the channel belongs to
* @cfg: channel configuration * @cfg: channel configuration
* @card: registered sound card * @card: registered sound card
...@@ -38,6 +39,7 @@ static struct most_component comp; ...@@ -38,6 +39,7 @@ static struct most_component comp;
* @opened: set when the stream is opened * @opened: set when the stream is opened
* @playback_task: playback thread * @playback_task: playback thread
* @playback_waitq: waitq used by playback thread * @playback_waitq: waitq used by playback thread
* @copy_fn: copy function for PCM-specific format and width
*/ */
struct channel { struct channel {
struct snd_pcm_substream *substream; struct snd_pcm_substream *substream;
...@@ -400,7 +402,7 @@ static snd_pcm_uframes_t pcm_pointer(struct snd_pcm_substream *substream) ...@@ -400,7 +402,7 @@ static snd_pcm_uframes_t pcm_pointer(struct snd_pcm_substream *substream)
return channel->buffer_pos; return channel->buffer_pos;
} }
/** /*
* Initialization of struct snd_pcm_ops * Initialization of struct snd_pcm_ops
*/ */
static const struct snd_pcm_ops pcm_ops = { static const struct snd_pcm_ops pcm_ops = {
...@@ -501,8 +503,8 @@ static void release_adapter(struct sound_adapter *adpt) ...@@ -501,8 +503,8 @@ static void release_adapter(struct sound_adapter *adpt)
* @iface: pointer to interface instance * @iface: pointer to interface instance
* @channel_id: channel index/ID * @channel_id: channel index/ID
* @cfg: pointer to actual channel configuration * @cfg: pointer to actual channel configuration
* @arg_list: string that provides the name of the device to be created in /dev * @device_name: name of the device to be created in /dev
* plus the desired audio resolution * @arg_list: string that provides the desired audio resolution
* *
* Creates sound card, pcm device, sets pcm ops and registers sound card. * Creates sound card, pcm device, sets pcm ops and registers sound card.
* *
...@@ -699,7 +701,7 @@ static int audio_tx_completion(struct most_interface *iface, int channel_id) ...@@ -699,7 +701,7 @@ static int audio_tx_completion(struct most_interface *iface, int channel_id)
return 0; return 0;
} }
/** /*
* Initialization of the struct most_component * Initialization of the struct most_component
*/ */
static struct most_component comp = { static struct most_component comp = {
......
...@@ -660,7 +660,7 @@ static void hdm_request_netinfo(struct most_interface *iface, int channel, ...@@ -660,7 +660,7 @@ static void hdm_request_netinfo(struct most_interface *iface, int channel,
/** /**
* link_stat_timer_handler - schedule work obtaining mac address and link status * link_stat_timer_handler - schedule work obtaining mac address and link status
* @data: pointer to USB device instance * @t: pointer to timer_list which holds a pointer to the USB device instance
* *
* The handler runs in interrupt context. That's why we need to defer the * The handler runs in interrupt context. That's why we need to defer the
* tasks to a work queue. * tasks to a work queue.
...@@ -763,14 +763,14 @@ static void wq_clear_halt(struct work_struct *wq_obj) ...@@ -763,14 +763,14 @@ static void wq_clear_halt(struct work_struct *wq_obj)
mutex_unlock(&mdev->io_mutex); mutex_unlock(&mdev->io_mutex);
} }
/** /*
* hdm_usb_fops - file operation table for USB driver * hdm_usb_fops - file operation table for USB driver
*/ */
static const struct file_operations hdm_usb_fops = { static const struct file_operations hdm_usb_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
}; };
/** /*
* usb_device_id - ID table for HCD device probing * usb_device_id - ID table for HCD device probing
*/ */
static const struct usb_device_id usbid[] = { static const struct usb_device_id usbid[] = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment