Commit fbaa5869 authored by Eric Paris's avatar Eric Paris Committed by James Morris

TPM: get_event_name stack corruption

get_event_name uses sprintf to fill a buffer declared on the stack.  It fills
the buffer 2 bytes at a time.  What the code doesn't take into account is that
sprintf(buf, "%02x", data) actually writes 3 bytes.  2 bytes for the data and
then it nul terminates the string.  Since we declare buf to be 40 characters
long and then we write 40 bytes of data into buf sprintf is going to write 41
characters.  The fix is to leave room in buf for the nul terminator.
Signed-off-by: default avatarEric Paris <eparis@redhat.com>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 279e677f
...@@ -212,7 +212,8 @@ static int get_event_name(char *dest, struct tcpa_event *event, ...@@ -212,7 +212,8 @@ static int get_event_name(char *dest, struct tcpa_event *event,
unsigned char * event_entry) unsigned char * event_entry)
{ {
const char *name = ""; const char *name = "";
char data[40] = ""; /* 41 so there is room for 40 data and 1 nul */
char data[41] = "";
int i, n_len = 0, d_len = 0; int i, n_len = 0, d_len = 0;
struct tcpa_pc_event *pc_event; struct tcpa_pc_event *pc_event;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment