Commit fbbdc255 authored by Zhenhua Huang's avatar Zhenhua Huang Committed by Masami Hiramatsu (Google)

fs/proc: remove redundant comments from /proc/bootconfig

commit 717c7c89 ("fs/proc: Add boot loader arguments as comment to
/proc/bootconfig") adds bootloader argument comments into /proc/bootconfig.

/proc/bootconfig shows boot_command_line[] multiple times following
every xbc key value pair, that's duplicated and not necessary.
Remove redundant ones.

Output before and after the fix is like:
key1 = value1
*bootloader argument comments*
key2 = value2
*bootloader argument comments*
key3 = value3
*bootloader argument comments*
...

key1 = value1
key2 = value2
key3 = value3
*bootloader argument comments*
...

Link: https://lore.kernel.org/all/20240409044358.1156477-1-paulmck@kernel.org/

Fixes: 717c7c89 ("fs/proc: Add boot loader arguments as comment to /proc/bootconfig")
Signed-off-by: default avatarZhenhua Huang <quic_zhenhuah@quicinc.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Cc: <linux-trace-kernel@vger.kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>
Cc: stable@vger.kernel.org
Acked-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
parent fec50db7
...@@ -62,12 +62,12 @@ static int __init copy_xbc_key_value_list(char *dst, size_t size) ...@@ -62,12 +62,12 @@ static int __init copy_xbc_key_value_list(char *dst, size_t size)
break; break;
dst += ret; dst += ret;
} }
if (ret >= 0 && boot_command_line[0]) { }
ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n", if (ret >= 0 && boot_command_line[0]) {
boot_command_line); ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n",
if (ret > 0) boot_command_line);
dst += ret; if (ret > 0)
} dst += ret;
} }
out: out:
kfree(key); kfree(key);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment