Commit fbf33f5a authored by Ziyang Xuan's avatar Ziyang Xuan Committed by David S. Miller

octeontx2-pf: Fix potential memory leak in otx2_init_tc()

In otx2_init_tc(), if rhashtable_init() failed, it does not free
tc->tc_entries_bitmap which is allocated in otx2_tc_alloc_ent_bitmap().

Fixes: 2e2a8126 ("octeontx2-pf: Unify flow management variables")
Signed-off-by: default avatarZiyang Xuan <william.xuanziyang@huawei.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 165df241
...@@ -1134,7 +1134,12 @@ int otx2_init_tc(struct otx2_nic *nic) ...@@ -1134,7 +1134,12 @@ int otx2_init_tc(struct otx2_nic *nic)
return err; return err;
tc->flow_ht_params = tc_flow_ht_params; tc->flow_ht_params = tc_flow_ht_params;
return rhashtable_init(&tc->flow_table, &tc->flow_ht_params); err = rhashtable_init(&tc->flow_table, &tc->flow_ht_params);
if (err) {
kfree(tc->tc_entries_bitmap);
tc->tc_entries_bitmap = NULL;
}
return err;
} }
EXPORT_SYMBOL(otx2_init_tc); EXPORT_SYMBOL(otx2_init_tc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment