Commit fc85cee9 authored by Dawei Li's avatar Dawei Li Committed by Will Deacon

perf/qcom_l2: Avoid placing cpumask on the stack

In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
the stack.
Suggested-by: default avatarMark Rutland <mark.rutland@arm.com>
Reviewed-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarDawei Li <dawei.li@shingroup.cn>
Link: https://lore.kernel.org/r/20240403155950.2068109-10-dawei.li@shingroup.cnSigned-off-by: default avatarWill Deacon <will@kernel.org>
parent b78d0fa2
...@@ -801,9 +801,8 @@ static int l2cache_pmu_online_cpu(unsigned int cpu, struct hlist_node *node) ...@@ -801,9 +801,8 @@ static int l2cache_pmu_online_cpu(unsigned int cpu, struct hlist_node *node)
static int l2cache_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) static int l2cache_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
{ {
struct cluster_pmu *cluster;
struct l2cache_pmu *l2cache_pmu; struct l2cache_pmu *l2cache_pmu;
cpumask_t cluster_online_cpus; struct cluster_pmu *cluster;
unsigned int target; unsigned int target;
l2cache_pmu = hlist_entry_safe(node, struct l2cache_pmu, node); l2cache_pmu = hlist_entry_safe(node, struct l2cache_pmu, node);
...@@ -820,9 +819,8 @@ static int l2cache_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) ...@@ -820,9 +819,8 @@ static int l2cache_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
cluster->on_cpu = -1; cluster->on_cpu = -1;
/* Any other CPU for this cluster which is still online */ /* Any other CPU for this cluster which is still online */
cpumask_and(&cluster_online_cpus, &cluster->cluster_cpus, target = cpumask_any_and_but(&cluster->cluster_cpus,
cpu_online_mask); cpu_online_mask, cpu);
target = cpumask_any_but(&cluster_online_cpus, cpu);
if (target >= nr_cpu_ids) { if (target >= nr_cpu_ids) {
disable_irq(cluster->irq); disable_irq(cluster->irq);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment