Commit fcfb4dcc authored by KOSAKI Motohiro's avatar KOSAKI Motohiro Committed by Linus Torvalds

mm/mempolicy.c: mpol_equal(): use bool

mpol_equal() logically returns a boolean.  Use a bool type to slightly
improve readability.
Signed-off-by: default avatarKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Stephen Wilson <wilsons@start.ca>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0c176d52
...@@ -164,11 +164,11 @@ static inline void mpol_get(struct mempolicy *pol) ...@@ -164,11 +164,11 @@ static inline void mpol_get(struct mempolicy *pol)
atomic_inc(&pol->refcnt); atomic_inc(&pol->refcnt);
} }
extern int __mpol_equal(struct mempolicy *a, struct mempolicy *b); extern bool __mpol_equal(struct mempolicy *a, struct mempolicy *b);
static inline int mpol_equal(struct mempolicy *a, struct mempolicy *b) static inline bool mpol_equal(struct mempolicy *a, struct mempolicy *b)
{ {
if (a == b) if (a == b)
return 1; return true;
return __mpol_equal(a, b); return __mpol_equal(a, b);
} }
...@@ -257,9 +257,9 @@ static inline int vma_migratable(struct vm_area_struct *vma) ...@@ -257,9 +257,9 @@ static inline int vma_migratable(struct vm_area_struct *vma)
struct mempolicy {}; struct mempolicy {};
static inline int mpol_equal(struct mempolicy *a, struct mempolicy *b) static inline bool mpol_equal(struct mempolicy *a, struct mempolicy *b)
{ {
return 1; return true;
} }
static inline void mpol_put(struct mempolicy *p) static inline void mpol_put(struct mempolicy *p)
......
...@@ -1983,28 +1983,28 @@ struct mempolicy *__mpol_cond_copy(struct mempolicy *tompol, ...@@ -1983,28 +1983,28 @@ struct mempolicy *__mpol_cond_copy(struct mempolicy *tompol,
} }
/* Slow path of a mempolicy comparison */ /* Slow path of a mempolicy comparison */
int __mpol_equal(struct mempolicy *a, struct mempolicy *b) bool __mpol_equal(struct mempolicy *a, struct mempolicy *b)
{ {
if (!a || !b) if (!a || !b)
return 0; return false;
if (a->mode != b->mode) if (a->mode != b->mode)
return 0; return false;
if (a->flags != b->flags) if (a->flags != b->flags)
return 0; return false;
if (mpol_store_user_nodemask(a)) if (mpol_store_user_nodemask(a))
if (!nodes_equal(a->w.user_nodemask, b->w.user_nodemask)) if (!nodes_equal(a->w.user_nodemask, b->w.user_nodemask))
return 0; return false;
switch (a->mode) { switch (a->mode) {
case MPOL_BIND: case MPOL_BIND:
/* Fall through */ /* Fall through */
case MPOL_INTERLEAVE: case MPOL_INTERLEAVE:
return nodes_equal(a->v.nodes, b->v.nodes); return !!nodes_equal(a->v.nodes, b->v.nodes);
case MPOL_PREFERRED: case MPOL_PREFERRED:
return a->v.preferred_node == b->v.preferred_node; return a->v.preferred_node == b->v.preferred_node;
default: default:
BUG(); BUG();
return 0; return false;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment