Commit fd100533 authored by Huacai Chen's avatar Huacai Chen Committed by Kelsey Skunberg

drm/qxl: Use correct notify port address when creating cursor ring

BugLink: https://bugs.launchpad.net/bugs/1885932

commit 80e5f89d upstream.

The command ring and cursor ring use different notify port addresses
definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in
qxl_device_init() we use QXL_IO_NOTIFY_CMD to create both command ring
and cursor ring. This doesn't cause any problems now, because QEMU's
behaviors on QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR are the same.
However, QEMU's behavior may be change in future, so let's fix it.

P.S.: In the X.org QXL driver, the notify port address of cursor ring
      is correct.
Signed-off-by: default avatarHuacai Chen <chenhc@lemote.com>
Cc: <stable@vger.kernel.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1585635488-17507-1-git-send-email-chenhc@lemote.comSigned-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
Signed-off-by: default avatarKelsey Skunberg <kelsey.skunberg@canonical.com>
parent 823b42a8
...@@ -199,7 +199,7 @@ static int qxl_device_init(struct qxl_device *qdev, ...@@ -199,7 +199,7 @@ static int qxl_device_init(struct qxl_device *qdev,
&(qdev->ram_header->cursor_ring_hdr), &(qdev->ram_header->cursor_ring_hdr),
sizeof(struct qxl_command), sizeof(struct qxl_command),
QXL_CURSOR_RING_SIZE, QXL_CURSOR_RING_SIZE,
qdev->io_base + QXL_IO_NOTIFY_CMD, qdev->io_base + QXL_IO_NOTIFY_CURSOR,
false, false,
&qdev->cursor_event); &qdev->cursor_event);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment