Commit fd13a683 authored by Kangjie Lu's avatar Kangjie Lu Committed by Greg Kroah-Hartman

USB: usbfs: fix potential infoleak in devio

commit 681fef83 upstream.

The stack object “ci” has a total size of 8 bytes. Its last 3 bytes
are padding bytes which are not initialized and leaked to userland
via “copy_to_user”.
Signed-off-by: default avatarKangjie Lu <kjlu@gatech.edu>
Signed-off-by: default avatarCharles (Chas) Williams <ciwillia@brocade.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8c6f91e3
...@@ -1104,10 +1104,11 @@ static int proc_getdriver(struct dev_state *ps, void __user *arg) ...@@ -1104,10 +1104,11 @@ static int proc_getdriver(struct dev_state *ps, void __user *arg)
static int proc_connectinfo(struct dev_state *ps, void __user *arg) static int proc_connectinfo(struct dev_state *ps, void __user *arg)
{ {
struct usbdevfs_connectinfo ci = { struct usbdevfs_connectinfo ci;
.devnum = ps->dev->devnum,
.slow = ps->dev->speed == USB_SPEED_LOW memset(&ci, 0, sizeof(ci));
}; ci.devnum = ps->dev->devnum;
ci.slow = ps->dev->speed == USB_SPEED_LOW;
if (copy_to_user(arg, &ci, sizeof(ci))) if (copy_to_user(arg, &ci, sizeof(ci)))
return -EFAULT; return -EFAULT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment