Commit fd1457d8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Douglas Anderson

drm/mcde: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert the mcde drm driver from always returning zero in the
remove callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-28-u.kleine-koenig@pengutronix.de
parent 41a56a18
...@@ -448,7 +448,7 @@ static int mcde_probe(struct platform_device *pdev) ...@@ -448,7 +448,7 @@ static int mcde_probe(struct platform_device *pdev)
} }
static int mcde_remove(struct platform_device *pdev) static void mcde_remove(struct platform_device *pdev)
{ {
struct drm_device *drm = platform_get_drvdata(pdev); struct drm_device *drm = platform_get_drvdata(pdev);
struct mcde *mcde = to_mcde(drm); struct mcde *mcde = to_mcde(drm);
...@@ -457,8 +457,6 @@ static int mcde_remove(struct platform_device *pdev) ...@@ -457,8 +457,6 @@ static int mcde_remove(struct platform_device *pdev)
clk_disable_unprepare(mcde->mcde_clk); clk_disable_unprepare(mcde->mcde_clk);
regulator_disable(mcde->vana); regulator_disable(mcde->vana);
regulator_disable(mcde->epod); regulator_disable(mcde->epod);
return 0;
} }
static const struct of_device_id mcde_of_match[] = { static const struct of_device_id mcde_of_match[] = {
...@@ -474,7 +472,7 @@ static struct platform_driver mcde_driver = { ...@@ -474,7 +472,7 @@ static struct platform_driver mcde_driver = {
.of_match_table = of_match_ptr(mcde_of_match), .of_match_table = of_match_ptr(mcde_of_match),
}, },
.probe = mcde_probe, .probe = mcde_probe,
.remove = mcde_remove, .remove_new = mcde_remove,
}; };
static struct platform_driver *const component_drivers[] = { static struct platform_driver *const component_drivers[] = {
......
...@@ -1208,14 +1208,12 @@ static int mcde_dsi_probe(struct platform_device *pdev) ...@@ -1208,14 +1208,12 @@ static int mcde_dsi_probe(struct platform_device *pdev)
return component_add(dev, &mcde_dsi_component_ops); return component_add(dev, &mcde_dsi_component_ops);
} }
static int mcde_dsi_remove(struct platform_device *pdev) static void mcde_dsi_remove(struct platform_device *pdev)
{ {
struct mcde_dsi *d = platform_get_drvdata(pdev); struct mcde_dsi *d = platform_get_drvdata(pdev);
component_del(&pdev->dev, &mcde_dsi_component_ops); component_del(&pdev->dev, &mcde_dsi_component_ops);
mipi_dsi_host_unregister(&d->dsi_host); mipi_dsi_host_unregister(&d->dsi_host);
return 0;
} }
static const struct of_device_id mcde_dsi_of_match[] = { static const struct of_device_id mcde_dsi_of_match[] = {
...@@ -1231,5 +1229,5 @@ struct platform_driver mcde_dsi_driver = { ...@@ -1231,5 +1229,5 @@ struct platform_driver mcde_dsi_driver = {
.of_match_table = of_match_ptr(mcde_dsi_of_match), .of_match_table = of_match_ptr(mcde_dsi_of_match),
}, },
.probe = mcde_dsi_probe, .probe = mcde_dsi_probe,
.remove = mcde_dsi_remove, .remove_new = mcde_dsi_remove,
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment