Commit fd48e9ac authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o

ext4: unindent codeblock in ext4_xattr_block_set()

Remove unnecessary else (and thus indentation level) from a code block
in ext4_xattr_block_set(). It will also make following code changes
easier. No functional changes.

CC: stable@vger.kernel.org
Fixes: 82939d79 ("ext4: convert to mbcache2")
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220712105436.32204-4-jack@suse.czSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 6bc0d63d
...@@ -1850,6 +1850,8 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode, ...@@ -1850,6 +1850,8 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
#define header(x) ((struct ext4_xattr_header *)(x)) #define header(x) ((struct ext4_xattr_header *)(x))
if (s->base) { if (s->base) {
int offset = (char *)s->here - bs->bh->b_data;
BUFFER_TRACE(bs->bh, "get_write_access"); BUFFER_TRACE(bs->bh, "get_write_access");
error = ext4_journal_get_write_access(handle, sb, bs->bh, error = ext4_journal_get_write_access(handle, sb, bs->bh,
EXT4_JTR_NONE); EXT4_JTR_NONE);
...@@ -1882,9 +1884,7 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode, ...@@ -1882,9 +1884,7 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
if (error) if (error)
goto cleanup; goto cleanup;
goto inserted; goto inserted;
} else { }
int offset = (char *)s->here - bs->bh->b_data;
unlock_buffer(bs->bh); unlock_buffer(bs->bh);
ea_bdebug(bs->bh, "cloning"); ea_bdebug(bs->bh, "cloning");
s->base = kmemdup(BHDR(bs->bh), bs->bh->b_size, GFP_NOFS); s->base = kmemdup(BHDR(bs->bh), bs->bh->b_size, GFP_NOFS);
...@@ -1925,7 +1925,6 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode, ...@@ -1925,7 +1925,6 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
s->here->e_value_inum = 0; s->here->e_value_inum = 0;
s->here->e_value_size = 0; s->here->e_value_size = 0;
} }
}
} else { } else {
/* Allocate a buffer where we construct the new block. */ /* Allocate a buffer where we construct the new block. */
s->base = kzalloc(sb->s_blocksize, GFP_NOFS); s->base = kzalloc(sb->s_blocksize, GFP_NOFS);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment