Commit fdb0a662 authored by Toshiaki Makita's avatar Toshiaki Makita Committed by David S. Miller

bridge: Update outdated comment on promiscuous mode

Now bridge ports can be non-promiscuous, vlan_vid_add() is no longer an
unnecessary operation.
Signed-off-by: default avatarToshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 618896e6
...@@ -55,10 +55,8 @@ static int __vlan_add(struct net_port_vlans *v, u16 vid, u16 flags) ...@@ -55,10 +55,8 @@ static int __vlan_add(struct net_port_vlans *v, u16 vid, u16 flags)
if (p) { if (p) {
/* Add VLAN to the device filter if it is supported. /* Add VLAN to the device filter if it is supported.
* Stricly speaking, this is not necessary now, since * This ensures tagged traffic enters the bridge when
* devices are made promiscuous by the bridge, but if * promiscuous mode is disabled by br_manage_promisc().
* that ever changes this code will allow tagged
* traffic to enter the bridge.
*/ */
err = vlan_vid_add(dev, br->vlan_proto, vid); err = vlan_vid_add(dev, br->vlan_proto, vid);
if (err) if (err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment