Commit fde04ab9 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] demux.h: Remove duplicated enum

"enum dmx_ts_pes" and "typedef enum dmx_pes_type_t" are just the
same enum declared twice, since Kernel (2.6.12). There's no reason
to duplicate it there, and sparse complains about that:
	drivers/media/dvb-core/dmxdev.c:600:55: warning: mixing different enum types
So, remove the internal define, keeping just the external one.
Internally, use only "enum dmx_ts_pes", as it is too late to drop
dmx_pes_type_t from the userspace API.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 9ea89e2b
...@@ -83,45 +83,6 @@ enum dmx_success { ...@@ -83,45 +83,6 @@ enum dmx_success {
#define TS_DEMUX 8 /* in case TS_PACKET is set, send the TS to #define TS_DEMUX 8 /* in case TS_PACKET is set, send the TS to
the demux device, not to the dvr device */ the demux device, not to the dvr device */
/* PES type for filters which write to built-in decoder */
/* these should be kept identical to the types in dmx.h */
enum dmx_ts_pes
{ /* also send packets to decoder (if it exists) */
DMX_TS_PES_AUDIO0,
DMX_TS_PES_VIDEO0,
DMX_TS_PES_TELETEXT0,
DMX_TS_PES_SUBTITLE0,
DMX_TS_PES_PCR0,
DMX_TS_PES_AUDIO1,
DMX_TS_PES_VIDEO1,
DMX_TS_PES_TELETEXT1,
DMX_TS_PES_SUBTITLE1,
DMX_TS_PES_PCR1,
DMX_TS_PES_AUDIO2,
DMX_TS_PES_VIDEO2,
DMX_TS_PES_TELETEXT2,
DMX_TS_PES_SUBTITLE2,
DMX_TS_PES_PCR2,
DMX_TS_PES_AUDIO3,
DMX_TS_PES_VIDEO3,
DMX_TS_PES_TELETEXT3,
DMX_TS_PES_SUBTITLE3,
DMX_TS_PES_PCR3,
DMX_TS_PES_OTHER
};
#define DMX_TS_PES_AUDIO DMX_TS_PES_AUDIO0
#define DMX_TS_PES_VIDEO DMX_TS_PES_VIDEO0
#define DMX_TS_PES_TELETEXT DMX_TS_PES_TELETEXT0
#define DMX_TS_PES_SUBTITLE DMX_TS_PES_SUBTITLE0
#define DMX_TS_PES_PCR DMX_TS_PES_PCR0
struct dmx_ts_feed { struct dmx_ts_feed {
int is_filtering; /* Set to non-zero when filtering in progress */ int is_filtering; /* Set to non-zero when filtering in progress */
struct dmx_demux *parent; /* Back-pointer */ struct dmx_demux *parent; /* Back-pointer */
......
...@@ -569,7 +569,7 @@ static int dvb_dmxdev_start_feed(struct dmxdev *dmxdev, ...@@ -569,7 +569,7 @@ static int dvb_dmxdev_start_feed(struct dmxdev *dmxdev,
dmx_output_t otype; dmx_output_t otype;
int ret; int ret;
int ts_type; int ts_type;
dmx_pes_type_t ts_pes; enum dmx_ts_pes ts_pes;
struct dmx_ts_feed *tsfeed; struct dmx_ts_feed *tsfeed;
feed->ts = NULL; feed->ts = NULL;
......
...@@ -674,7 +674,7 @@ static int dmx_ts_feed_set(struct dmx_ts_feed *ts_feed, u16 pid, int ts_type, ...@@ -674,7 +674,7 @@ static int dmx_ts_feed_set(struct dmx_ts_feed *ts_feed, u16 pid, int ts_type,
return -ERESTARTSYS; return -ERESTARTSYS;
if (ts_type & TS_DECODER) { if (ts_type & TS_DECODER) {
if (pes_type >= DMX_TS_PES_OTHER) { if (pes_type >= DMX_PES_OTHER) {
mutex_unlock(&demux->mutex); mutex_unlock(&demux->mutex);
return -EINVAL; return -EINVAL;
} }
...@@ -846,7 +846,7 @@ static int dvbdmx_release_ts_feed(struct dmx_demux *dmx, ...@@ -846,7 +846,7 @@ static int dvbdmx_release_ts_feed(struct dmx_demux *dmx,
feed->pid = 0xffff; feed->pid = 0xffff;
if (feed->ts_type & TS_DECODER && feed->pes_type < DMX_TS_PES_OTHER) if (feed->ts_type & TS_DECODER && feed->pes_type < DMX_PES_OTHER)
demux->pesfilter[feed->pes_type] = NULL; demux->pesfilter[feed->pes_type] = NULL;
mutex_unlock(&demux->mutex); mutex_unlock(&demux->mutex);
...@@ -1268,7 +1268,7 @@ int dvb_dmx_init(struct dvb_demux *dvbdemux) ...@@ -1268,7 +1268,7 @@ int dvb_dmx_init(struct dvb_demux *dvbdemux)
INIT_LIST_HEAD(&dvbdemux->frontend_list); INIT_LIST_HEAD(&dvbdemux->frontend_list);
for (i = 0; i < DMX_TS_PES_OTHER; i++) { for (i = 0; i < DMX_PES_OTHER; i++) {
dvbdemux->pesfilter[i] = NULL; dvbdemux->pesfilter[i] = NULL;
dvbdemux->pids[i] = 0xffff; dvbdemux->pids[i] = 0xffff;
} }
......
...@@ -119,8 +119,8 @@ struct dvb_demux { ...@@ -119,8 +119,8 @@ struct dvb_demux {
struct list_head frontend_list; struct list_head frontend_list;
struct dvb_demux_feed *pesfilter[DMX_TS_PES_OTHER]; struct dvb_demux_feed *pesfilter[DMX_PES_OTHER];
u16 pids[DMX_TS_PES_OTHER]; u16 pids[DMX_PES_OTHER];
int playing; int playing;
int recording; int recording;
......
...@@ -1044,7 +1044,7 @@ static int dvb_net_feed_start(struct net_device *dev) ...@@ -1044,7 +1044,7 @@ static int dvb_net_feed_start(struct net_device *dev)
ret = priv->tsfeed->set(priv->tsfeed, ret = priv->tsfeed->set(priv->tsfeed,
priv->pid, /* pid */ priv->pid, /* pid */
TS_PACKET, /* type */ TS_PACKET, /* type */
DMX_TS_PES_OTHER, /* pes type */ DMX_PES_OTHER, /* pes type */
32768, /* circular buffer size */ 32768, /* circular buffer size */
timeout /* timeout */ timeout /* timeout */
); );
......
...@@ -71,11 +71,11 @@ int fdtv_start_feed(struct dvb_demux_feed *dvbdmxfeed) ...@@ -71,11 +71,11 @@ int fdtv_start_feed(struct dvb_demux_feed *dvbdmxfeed)
if (dvbdmxfeed->type == DMX_TYPE_TS) { if (dvbdmxfeed->type == DMX_TYPE_TS) {
switch (dvbdmxfeed->pes_type) { switch (dvbdmxfeed->pes_type) {
case DMX_TS_PES_VIDEO: case DMX_PES_VIDEO:
case DMX_TS_PES_AUDIO: case DMX_PES_AUDIO:
case DMX_TS_PES_TELETEXT: case DMX_PES_TELETEXT:
case DMX_TS_PES_PCR: case DMX_PES_PCR:
case DMX_TS_PES_OTHER: case DMX_PES_OTHER:
c = alloc_channel(fdtv); c = alloc_channel(fdtv);
break; break;
default: default:
...@@ -132,7 +132,7 @@ int fdtv_stop_feed(struct dvb_demux_feed *dvbdmxfeed) ...@@ -132,7 +132,7 @@ int fdtv_stop_feed(struct dvb_demux_feed *dvbdmxfeed)
(demux->dmx.frontend->source != DMX_MEMORY_FE))) { (demux->dmx.frontend->source != DMX_MEMORY_FE))) {
if (dvbdmxfeed->ts_type & TS_DECODER) { if (dvbdmxfeed->ts_type & TS_DECODER) {
if (dvbdmxfeed->pes_type >= DMX_TS_PES_OTHER || if (dvbdmxfeed->pes_type >= DMX_PES_OTHER ||
!demux->pesfilter[dvbdmxfeed->pes_type]) !demux->pesfilter[dvbdmxfeed->pes_type])
return -EINVAL; return -EINVAL;
...@@ -141,7 +141,7 @@ int fdtv_stop_feed(struct dvb_demux_feed *dvbdmxfeed) ...@@ -141,7 +141,7 @@ int fdtv_stop_feed(struct dvb_demux_feed *dvbdmxfeed)
} }
if (!(dvbdmxfeed->ts_type & TS_DECODER && if (!(dvbdmxfeed->ts_type & TS_DECODER &&
dvbdmxfeed->pes_type < DMX_TS_PES_OTHER)) dvbdmxfeed->pes_type < DMX_PES_OTHER))
return 0; return 0;
} }
......
...@@ -990,7 +990,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed) ...@@ -990,7 +990,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
if (feed->type == DMX_TYPE_TS) { if (feed->type == DMX_TYPE_TS) {
if ((feed->ts_type & TS_DECODER) && if ((feed->ts_type & TS_DECODER) &&
(feed->pes_type <= DMX_TS_PES_PCR)) { (feed->pes_type <= DMX_PES_PCR)) {
switch (demux->dmx.frontend->source) { switch (demux->dmx.frontend->source) {
case DMX_MEMORY_FE: case DMX_MEMORY_FE:
if (feed->ts_type & TS_DECODER) if (feed->ts_type & TS_DECODER)
...@@ -1051,14 +1051,14 @@ static int av7110_stop_feed(struct dvb_demux_feed *feed) ...@@ -1051,14 +1051,14 @@ static int av7110_stop_feed(struct dvb_demux_feed *feed)
if (feed->type == DMX_TYPE_TS) { if (feed->type == DMX_TYPE_TS) {
if (feed->ts_type & TS_DECODER) { if (feed->ts_type & TS_DECODER) {
if (feed->pes_type >= DMX_TS_PES_OTHER || if (feed->pes_type >= DMX_PES_OTHER ||
!demux->pesfilter[feed->pes_type]) !demux->pesfilter[feed->pes_type])
return -EINVAL; return -EINVAL;
demux->pids[feed->pes_type] |= 0x8000; demux->pids[feed->pes_type] |= 0x8000;
demux->pesfilter[feed->pes_type] = NULL; demux->pesfilter[feed->pes_type] = NULL;
} }
if (feed->ts_type & TS_DECODER && if (feed->ts_type & TS_DECODER &&
feed->pes_type < DMX_TS_PES_OTHER) { feed->pes_type < DMX_PES_OTHER) {
ret = dvb_feed_stop_pid(feed); ret = dvb_feed_stop_pid(feed);
} else } else
if ((feed->ts_type & TS_PACKET) && if ((feed->ts_type & TS_PACKET) &&
......
...@@ -930,11 +930,11 @@ static int ttusb_start_feed(struct dvb_demux_feed *dvbdmxfeed) ...@@ -930,11 +930,11 @@ static int ttusb_start_feed(struct dvb_demux_feed *dvbdmxfeed)
if (dvbdmxfeed->type == DMX_TYPE_TS) { if (dvbdmxfeed->type == DMX_TYPE_TS) {
switch (dvbdmxfeed->pes_type) { switch (dvbdmxfeed->pes_type) {
case DMX_TS_PES_VIDEO: case DMX_PES_VIDEO:
case DMX_TS_PES_AUDIO: case DMX_PES_AUDIO:
case DMX_TS_PES_TELETEXT: case DMX_PES_TELETEXT:
case DMX_TS_PES_PCR: case DMX_PES_PCR:
case DMX_TS_PES_OTHER: case DMX_PES_OTHER:
break; break;
default: default:
return -EINVAL; return -EINVAL;
......
...@@ -951,34 +951,34 @@ static int ttusb_dec_start_ts_feed(struct dvb_demux_feed *dvbdmxfeed) ...@@ -951,34 +951,34 @@ static int ttusb_dec_start_ts_feed(struct dvb_demux_feed *dvbdmxfeed)
switch (dvbdmxfeed->pes_type) { switch (dvbdmxfeed->pes_type) {
case DMX_TS_PES_VIDEO: case DMX_PES_VIDEO:
dprintk(" pes_type: DMX_TS_PES_VIDEO\n"); dprintk(" pes_type: DMX_PES_VIDEO\n");
dec->pid[DMX_PES_PCR] = dvbdmxfeed->pid; dec->pid[DMX_PES_PCR] = dvbdmxfeed->pid;
dec->pid[DMX_PES_VIDEO] = dvbdmxfeed->pid; dec->pid[DMX_PES_VIDEO] = dvbdmxfeed->pid;
dec->video_filter = dvbdmxfeed->filter; dec->video_filter = dvbdmxfeed->filter;
ttusb_dec_set_pids(dec); ttusb_dec_set_pids(dec);
break; break;
case DMX_TS_PES_AUDIO: case DMX_PES_AUDIO:
dprintk(" pes_type: DMX_TS_PES_AUDIO\n"); dprintk(" pes_type: DMX_PES_AUDIO\n");
dec->pid[DMX_PES_AUDIO] = dvbdmxfeed->pid; dec->pid[DMX_PES_AUDIO] = dvbdmxfeed->pid;
dec->audio_filter = dvbdmxfeed->filter; dec->audio_filter = dvbdmxfeed->filter;
ttusb_dec_set_pids(dec); ttusb_dec_set_pids(dec);
break; break;
case DMX_TS_PES_TELETEXT: case DMX_PES_TELETEXT:
dec->pid[DMX_PES_TELETEXT] = dvbdmxfeed->pid; dec->pid[DMX_PES_TELETEXT] = dvbdmxfeed->pid;
dprintk(" pes_type: DMX_TS_PES_TELETEXT(not supported)\n"); dprintk(" pes_type: DMX_PES_TELETEXT(not supported)\n");
return -ENOSYS; return -ENOSYS;
case DMX_TS_PES_PCR: case DMX_PES_PCR:
dprintk(" pes_type: DMX_TS_PES_PCR\n"); dprintk(" pes_type: DMX_PES_PCR\n");
dec->pid[DMX_PES_PCR] = dvbdmxfeed->pid; dec->pid[DMX_PES_PCR] = dvbdmxfeed->pid;
ttusb_dec_set_pids(dec); ttusb_dec_set_pids(dec);
break; break;
case DMX_TS_PES_OTHER: case DMX_PES_OTHER:
dprintk(" pes_type: DMX_TS_PES_OTHER(not supported)\n"); dprintk(" pes_type: DMX_PES_OTHER(not supported)\n");
return -ENOSYS; return -ENOSYS;
default: default:
......
...@@ -51,7 +51,7 @@ typedef enum ...@@ -51,7 +51,7 @@ typedef enum
} dmx_input_t; } dmx_input_t;
typedef enum typedef enum dmx_ts_pes
{ {
DMX_PES_AUDIO0, DMX_PES_AUDIO0,
DMX_PES_VIDEO0, DMX_PES_VIDEO0,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment