Commit fe1a5ddf authored by Shaohua Li's avatar Shaohua Li Committed by Adrian Bunk

x86 microcode: don't check the size

IA32 manual says if micorcode update's size is 0, then the size is
default size (2048 bytes). But this doesn't suggest all microcode
update's size should be above 2048 bytes to me. We actually had a
microcode update whose size is 1024 bytes. The patch just removed the
check.

Backported by Daniel Drake.
Signed-off-by: default avatarDaniel Drake <dsd@gentoo.org>
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
parent 7a715c63
...@@ -233,14 +233,14 @@ static int find_matching_ucodes (void) ...@@ -233,14 +233,14 @@ static int find_matching_ucodes (void)
} }
total_size = get_totalsize(&mc_header); total_size = get_totalsize(&mc_header);
if ((cursor + total_size > user_buffer_size) || (total_size < DEFAULT_UCODE_TOTALSIZE)) { if (cursor + total_size > user_buffer_size) {
printk(KERN_ERR "microcode: error! Bad data in microcode data file\n"); printk(KERN_ERR "microcode: error! Bad data in microcode data file\n");
error = -EINVAL; error = -EINVAL;
goto out; goto out;
} }
data_size = get_datasize(&mc_header); data_size = get_datasize(&mc_header);
if ((data_size + MC_HEADER_SIZE > total_size) || (data_size < DEFAULT_UCODE_DATASIZE)) { if (data_size + MC_HEADER_SIZE > total_size) {
printk(KERN_ERR "microcode: error! Bad data in microcode data file\n"); printk(KERN_ERR "microcode: error! Bad data in microcode data file\n");
error = -EINVAL; error = -EINVAL;
goto out; goto out;
...@@ -437,11 +437,6 @@ static ssize_t microcode_write (struct file *file, const char __user *buf, size_ ...@@ -437,11 +437,6 @@ static ssize_t microcode_write (struct file *file, const char __user *buf, size_
{ {
ssize_t ret; ssize_t ret;
if (len < DEFAULT_UCODE_TOTALSIZE) {
printk(KERN_ERR "microcode: not enough data\n");
return -EINVAL;
}
if ((len >> PAGE_SHIFT) > num_physpages) { if ((len >> PAGE_SHIFT) > num_physpages) {
printk(KERN_ERR "microcode: too much data (max %ld pages)\n", num_physpages); printk(KERN_ERR "microcode: too much data (max %ld pages)\n", num_physpages);
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment