Commit fe3d44cd authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

dmaengine: fsl-qdma: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919133207.1400430-14-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent fa13c3ef
...@@ -1266,7 +1266,7 @@ static void fsl_qdma_cleanup_vchan(struct dma_device *dmadev) ...@@ -1266,7 +1266,7 @@ static void fsl_qdma_cleanup_vchan(struct dma_device *dmadev)
} }
} }
static int fsl_qdma_remove(struct platform_device *pdev) static void fsl_qdma_remove(struct platform_device *pdev)
{ {
int i; int i;
struct fsl_qdma_queue *status; struct fsl_qdma_queue *status;
...@@ -1283,7 +1283,6 @@ static int fsl_qdma_remove(struct platform_device *pdev) ...@@ -1283,7 +1283,6 @@ static int fsl_qdma_remove(struct platform_device *pdev)
dma_free_coherent(&pdev->dev, sizeof(struct fsl_qdma_format) * dma_free_coherent(&pdev->dev, sizeof(struct fsl_qdma_format) *
status->n_cq, status->cq, status->bus_addr); status->n_cq, status->cq, status->bus_addr);
} }
return 0;
} }
static const struct of_device_id fsl_qdma_dt_ids[] = { static const struct of_device_id fsl_qdma_dt_ids[] = {
...@@ -1298,7 +1297,7 @@ static struct platform_driver fsl_qdma_driver = { ...@@ -1298,7 +1297,7 @@ static struct platform_driver fsl_qdma_driver = {
.of_match_table = fsl_qdma_dt_ids, .of_match_table = fsl_qdma_dt_ids,
}, },
.probe = fsl_qdma_probe, .probe = fsl_qdma_probe,
.remove = fsl_qdma_remove, .remove_new = fsl_qdma_remove,
}; };
module_platform_driver(fsl_qdma_driver); module_platform_driver(fsl_qdma_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment