Commit fe56d6e4 authored by Jakub Kicinski's avatar Jakub Kicinski

selftests: net: local_termination: annotate the expected failures

Vladimir said when adding this test:

  The bridge driver fares particularly badly [...] mainly because
  it does not implement IFF_UNICAST_FLT.

See commit 90b9566a ("selftests: forwarding: add a test for
local_termination.sh").

We don't want to hide the known gaps, but having a test which
always fails prevents us from catching regressions. Report
the cases we know may fail as XFAIL.
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/r/20240516152513.1115270-1-kuba@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f0fa8411
...@@ -155,25 +155,30 @@ run_test() ...@@ -155,25 +155,30 @@ run_test()
"$smac > $MACVLAN_ADDR, ethertype IPv4 (0x0800)" \ "$smac > $MACVLAN_ADDR, ethertype IPv4 (0x0800)" \
true true
check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \ xfail_on_veth $h1 \
"$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \ check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \
false "$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \
false
check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, promisc" \ check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, promisc" \
"$smac > $UNKNOWN_UC_ADDR2, ethertype IPv4 (0x0800)" \ "$smac > $UNKNOWN_UC_ADDR2, ethertype IPv4 (0x0800)" \
true true
check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, allmulti" \ xfail_on_veth $h1 \
"$smac > $UNKNOWN_UC_ADDR3, ethertype IPv4 (0x0800)" \ check_rcv $rcv_if_name \
false "Unicast IPv4 to unknown MAC address, allmulti" \
"$smac > $UNKNOWN_UC_ADDR3, ethertype IPv4 (0x0800)" \
false
check_rcv $rcv_if_name "Multicast IPv4 to joined group" \ check_rcv $rcv_if_name "Multicast IPv4 to joined group" \
"$smac > $JOINED_MACV4_MC_ADDR, ethertype IPv4 (0x0800)" \ "$smac > $JOINED_MACV4_MC_ADDR, ethertype IPv4 (0x0800)" \
true true
check_rcv $rcv_if_name "Multicast IPv4 to unknown group" \ xfail_on_veth $h1 \
"$smac > $UNKNOWN_MACV4_MC_ADDR1, ethertype IPv4 (0x0800)" \ check_rcv $rcv_if_name \
false "Multicast IPv4 to unknown group" \
"$smac > $UNKNOWN_MACV4_MC_ADDR1, ethertype IPv4 (0x0800)" \
false
check_rcv $rcv_if_name "Multicast IPv4 to unknown group, promisc" \ check_rcv $rcv_if_name "Multicast IPv4 to unknown group, promisc" \
"$smac > $UNKNOWN_MACV4_MC_ADDR2, ethertype IPv4 (0x0800)" \ "$smac > $UNKNOWN_MACV4_MC_ADDR2, ethertype IPv4 (0x0800)" \
...@@ -187,9 +192,10 @@ run_test() ...@@ -187,9 +192,10 @@ run_test()
"$smac > $JOINED_MACV6_MC_ADDR, ethertype IPv6 (0x86dd)" \ "$smac > $JOINED_MACV6_MC_ADDR, ethertype IPv6 (0x86dd)" \
true true
check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \ xfail_on_veth $h1 \
"$smac > $UNKNOWN_MACV6_MC_ADDR1, ethertype IPv6 (0x86dd)" \ check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \
false "$smac > $UNKNOWN_MACV6_MC_ADDR1, ethertype IPv6 (0x86dd)" \
false
check_rcv $rcv_if_name "Multicast IPv6 to unknown group, promisc" \ check_rcv $rcv_if_name "Multicast IPv6 to unknown group, promisc" \
"$smac > $UNKNOWN_MACV6_MC_ADDR2, ethertype IPv6 (0x86dd)" \ "$smac > $UNKNOWN_MACV6_MC_ADDR2, ethertype IPv6 (0x86dd)" \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment