Commit fe85f6e6 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: ump: Don't clear bank selection after sending a program change

The current code clears the bank selection MSB/LSB after sending a
program change, but this can be wrong, as many apps may not send the
full bank selection with both MSB and LSB but sending only one.
Better to keep the previous bank set.

Fixes: 0b5288f5 ("ALSA: ump: Add legacy raw MIDI support")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20240529083823.5778-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent edb32776
...@@ -404,7 +404,6 @@ static int cvt_legacy_cmd_to_ump(struct ump_cvt_to_ump *cvt, ...@@ -404,7 +404,6 @@ static int cvt_legacy_cmd_to_ump(struct ump_cvt_to_ump *cvt,
midi2->pg.bank_msb = cc->cc_bank_msb; midi2->pg.bank_msb = cc->cc_bank_msb;
midi2->pg.bank_lsb = cc->cc_bank_lsb; midi2->pg.bank_lsb = cc->cc_bank_lsb;
cc->bank_set = 0; cc->bank_set = 0;
cc->cc_bank_msb = cc->cc_bank_lsb = 0;
} }
break; break;
case UMP_MSG_STATUS_CHANNEL_PRESSURE: case UMP_MSG_STATUS_CHANNEL_PRESSURE:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment