Commit fe9af155 authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Zefan Li

dm: hold suspend_lock while suspending device during device deletion

commit ab7c7bb6 upstream.

__dm_destroy() must take the suspend_lock so that its presuspend and
postsuspend calls do not race with an internal suspend.
Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarZefan Li <lizefan@huawei.com>
parent 182420b6
...@@ -2295,10 +2295,16 @@ static void __dm_destroy(struct mapped_device *md, bool wait) ...@@ -2295,10 +2295,16 @@ static void __dm_destroy(struct mapped_device *md, bool wait)
set_bit(DMF_FREEING, &md->flags); set_bit(DMF_FREEING, &md->flags);
spin_unlock(&_minor_lock); spin_unlock(&_minor_lock);
/*
* Take suspend_lock so that presuspend and postsuspend methods
* do not race with internal suspend.
*/
mutex_lock(&md->suspend_lock);
if (!dm_suspended_md(md)) { if (!dm_suspended_md(md)) {
dm_table_presuspend_targets(map); dm_table_presuspend_targets(map);
dm_table_postsuspend_targets(map); dm_table_postsuspend_targets(map);
} }
mutex_unlock(&md->suspend_lock);
/* /*
* Rare, but there may be I/O requests still going to complete, * Rare, but there may be I/O requests still going to complete,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment