Commit feda79bf authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab

V4L/DVB: drivers/media/video/gspca: Use kmemdup

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDouglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 230b27cd
...@@ -572,12 +572,11 @@ static void reg_w_buf(struct gspca_dev *gspca_dev, ...@@ -572,12 +572,11 @@ static void reg_w_buf(struct gspca_dev *gspca_dev,
} else { } else {
u8 *tmpbuf; u8 *tmpbuf;
tmpbuf = kmalloc(len, GFP_KERNEL); tmpbuf = kmemdup(buffer, len, GFP_KERNEL);
if (!tmpbuf) { if (!tmpbuf) {
err("Out of memory"); err("Out of memory");
return; return;
} }
memcpy(tmpbuf, buffer, len);
usb_control_msg(gspca_dev->dev, usb_control_msg(gspca_dev->dev,
usb_sndctrlpipe(gspca_dev->dev, 0), usb_sndctrlpipe(gspca_dev->dev, 0),
0, 0,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment