Commit ff361fda authored by Dan Carpenter's avatar Dan Carpenter Committed by Steve French

cifs: Silence uninitialized variable warning

This is not really a runtime issue but Smatch complains that:

    fs/cifs/smb2ops.c:1740 smb2_query_symlink()
    error: uninitialized symbol 'resp_buftype'.

The warning is right that it can be uninitialized...  Also "err_buf"
would be NULL at this point and we're not supposed to pass NULLs to
free_rsp_buf() or it might trigger some extra output if we turn on
debugging.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarPaulo Alcantara <palcantara@suse.de>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 1236568e
...@@ -1700,7 +1700,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, ...@@ -1700,7 +1700,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,
&resp_buftype); &resp_buftype);
if (!rc || !err_iov.iov_base) { if (!rc || !err_iov.iov_base) {
rc = -ENOENT; rc = -ENOENT;
goto querty_exit; goto free_path;
} }
err_buf = err_iov.iov_base; err_buf = err_iov.iov_base;
...@@ -1741,6 +1741,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, ...@@ -1741,6 +1741,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,
querty_exit: querty_exit:
free_rsp_buf(resp_buftype, err_buf); free_rsp_buf(resp_buftype, err_buf);
free_path:
kfree(utf16_path); kfree(utf16_path);
return rc; return rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment