Commit ffdf726d authored by Lars Poeschel's avatar Lars Poeschel Committed by Miguel Ojeda

auxdisplay: hd44780_common: Fix build error

When building the hd44780_common driver without a driver that actually
uses it like panel or hd44780 you get a build error, because
hd44780_common uses charlcd, but did not select it. Its users did
select it.

This is fixed now. hd4478_common now selects charlcd in Kconfig and
panel and hd44780 do not. They only select hd44780_common.
Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarLars Poeschel <poeschel@lemonage.de>
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 8c9108d0
...@@ -27,6 +27,7 @@ config CHARLCD ...@@ -27,6 +27,7 @@ config CHARLCD
config HD44780_COMMON config HD44780_COMMON
tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST
select CHARLCD
help help
This is a module with the common symbols for HD44780 (and compatibles) This is a module with the common symbols for HD44780 (and compatibles)
displays. This is the code that multiple other modules use. It is not displays. This is the code that multiple other modules use. It is not
...@@ -37,7 +38,6 @@ config HD44780_COMMON ...@@ -37,7 +38,6 @@ config HD44780_COMMON
config HD44780 config HD44780
tristate "HD44780 Character LCD support" tristate "HD44780 Character LCD support"
depends on GPIOLIB || COMPILE_TEST depends on GPIOLIB || COMPILE_TEST
select CHARLCD
select HD44780_COMMON select HD44780_COMMON
help help
Enable support for Character LCDs using a HD44780 controller. Enable support for Character LCDs using a HD44780 controller.
...@@ -196,7 +196,6 @@ config ARM_CHARLCD ...@@ -196,7 +196,6 @@ config ARM_CHARLCD
menuconfig PARPORT_PANEL menuconfig PARPORT_PANEL
tristate "Parallel port LCD/Keypad Panel support" tristate "Parallel port LCD/Keypad Panel support"
depends on PARPORT depends on PARPORT
select CHARLCD
select HD44780_COMMON select HD44780_COMMON
help help
Say Y here if you have an HD44780 or KS-0074 LCD connected to your Say Y here if you have an HD44780 or KS-0074 LCD connected to your
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment