- 28 Aug, 2017 7 commits
-
-
Dan Carpenter authored
The copy_from_user() function returns the number of bytes which we weren't able to copy. We don't want to return that to the user but instead we want to return -EFAULT. Fixes: d7e09d03 ("staging: add Lustre file system client support") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Dan Carpenter authored
We recently changed from using obd_ioctl_popdata() to calling copy_to_user() directly. This if statement was supposed to be deleted but it was over looked. "err" is zero at this point so it means we return success. Fixes: b03679f6 ("staging: lustre: uapi: remove obd_ioctl_popdata() wrapper") Signed-off-by:
-
Himanshu Jha authored
calling memcpy immediately after memset with the same region of memory makes memset redundant. Build successfully. Signed-off-by:
Himanshu Jha <himanshujha199640@gmail.com> Signed-off-by:
-
Larry Finger authored
The changes in this commit are also being sent to the main rtlwifi drivers in wireless-next; however, these changes will also be useful for any debugging of r8822be before it gets moved into the main tree. Use debugfs to dump register and btcoex status, and also write registers and h2c. We create topdir in /sys/kernel/debug/rtlwifi/, and use the MAC address as subdirectory with several entries to dump mac_reg, bb_reg, rf_reg etc. An example is /sys/kernel/debug/rtlwifi/00-11-22-33-44-55-66/mac_0 This change permits examination of device registers in a dynamic manner, a feature not available with the current debug mechanism. We use seq_file to replace RT_TRACE to dump status, then we can use 'cat' to access btcoex's status through debugfs. (i.e. /sys/kernel/debug/rtlwifi/00-11-22-33-44-55-66/btcoex) Other related changes are 1. implement btc_disp_dbg_msg() to access btcoex's common status. 2. remove obsolete field bt_exist Signed-off-by:Ping-Ke Shih <pkshih@realtek.com> Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com> Cc: Birming Chiu <birming@realtek.com> Cc: Shaofu <shaofu@realtek.com> Cc: Steven Ting <steventing@realtek.com> Signed-off-by:
-
Dan Carpenter authored
Smatch is distrustful of the "capab" value and marks it as user controlled. I think it actually comes from the firmware? Anyway, I looked at other drivers and they added a bounds check and it seems like a harmless thing to have so I have added it here as well. Signed-off-by:
-
Janani Sankara Babu authored
This patch is created to solve the following coding style issue reported by the checkpatch script. CHECK: spaces preffered around that '&' (ctx:VxV) Signed-off-by:
Janani Sankara Babu <jananis37@gmail.com> Signed-off-by:
-
Janani Sankara Babu authored
This patch solves the following warning shown by the checkpatch script WARNING: Comparisons should place the constants on the right side of the test Signed-off-by:
-
- 27 Aug, 2017 3 commits
-
-
Himanshu Jha authored
Kfree on NULL pointer is a no-op and therefore checking is redundant. Signed-off-by:
-
Himanshu Jha authored
call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value. Build and tested it. Signed-off-by:
-
Alex Briskin authored
Register with module_driver macro instead of module_init/module_exit. Signed-off-by:
Alex Briskin <br.shurik@gmail.com> Signed-off-by:
-
- 23 Aug, 2017 30 commits
-
-
Arnd Bergmann authored
Like the version in drivers/net/wireless, this driver requires the MAC80211 framework, otherwise we run into a link error: ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined! ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined! ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined! ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined! This adds the Kconfig dependency for it. Fixes: 56bde846 ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Arnd Bergmann authored
gcc notices a very complicated way to check a value for being equal to one, and warns about it: drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c: In function 'halbtc8822b1ant_set_ext_ant_switch': drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c:2105:9: error: '~' on a boolean expression [-Werror=bool-operation] ~switch_polatiry_inverse : ^ drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c:2105:9: note: did you mean to use logical not? ~switch_polatiry_inverse : ^ This simplifies this expression to make it more readable and to make gcc happy. Fixes: 56bde846 ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver") Signed-off-by: -
Arnd Bergmann authored
This function contains a series of interdependent conditions, slightly more than gcc can follow handle apparently: drivers/staging/rtlwifi/base.c: In function 'rtl_check_beacon_key': drivers/staging/rtlwifi/base.c:2546:34: error: 'ht_cap_ie' may be used uninitialized in this function [-Werror=maybe-uninitialized] This moves the code around a bit, to simplify the conditions enough that gcc can see that all variables are correctly initialized. Fixes: 56bde846 ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver") Signed-off-by:
-
Bryan Garza authored
Changed dev_err() call to use function name constant instead of hardcoded string. Issue found by checkpatch. Signed-off-by:
Bryan Garza <bry@riseup.net> Signed-off-by:
-
Gilad Ben-Yossef authored
The crypto API requires saving the last blocks of ciphertext in req->info for use as IV for CTS mode. The ccree driver was not doing this. This patch fixes that. The bug was manifested with cts(cbc(aes)) mode in tcrypt tests. Fixes: 302ef8eb ("Add CryptoCell skcipher support") Signed-off-by:
Gilad Ben-Yossef <gilad@benyossef.com> Cc: stable <stable@vger.kernel.org> Signed-off-by:
-
Laurentiu Tudor authored
Throughout the driver we use == 0 / != 0 to check strcmp() returns except this place, so fix it. Signed-off-by:
Laurentiu Tudor <laurentiu.tudor@nxp.com> Signed-off-by:
-
James Simmons authored
Rationalize include paths in all the lnet header files. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
James Simmons authored
Rationalize include paths in all the libcfs header files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the libcfs source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the ksocklnd source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the ko2iblnd source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the lnet core source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the lnet selftest source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths for the lustre uapi headers Signed-off-by:
-
James Simmons authored
Rationalize include paths for the lustre internal headers Signed-off-by:
-
James Simmons authored
Rationalize include paths in the osc source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the obdecho source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the obdclass source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the mgc source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the mdc source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the lov source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the lmv source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the llite source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the ptlrpc/ldlm source code files. Signed-off-by:
-
James Simmons authored
Rationalize include paths in the fld source code files. Signed-off-by:
-
James Simmons authored
Start to rationalize include paths in the fid source code files. Signed-off-by:
-
James Simmons authored
The BIT macro is not available for UAPI headers so remove it from the lustre UAPI headers. Signed-off-by:
-
James Simmons authored
In order for lustre_idl.h to be usable for both user land and kernel space it has to use the proper byteorder functions. Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/16916Reviewed-by:
Frank Zago <fzago@cray.com> Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Reviewed-by:
John L. Hammond <john.hammond@intel.com> Signed-off-by:
-
James Simmons authored
Now that lustre_ioctl.h is a UAPI header the kernel configuration option CONFIG_LUSTRE_OBD_MAX_IOCTL needs to be remove. The user land utilites will no longer be able to see this option and actually they never used this option before. Since this is the case setting the kernel configuration to something other than 8K could actually break things. The best option is just hard code it to 8K. Signed-off-by:
Quentin Bouget <quentin.bouget@cea.fr> Reviewed-by:
Ben Evans <bevans@cray.com> Reviewed-by:
-
James Simmons authored
Move all the remaining lustre headers shared between user land and kernel space to the uapi directory. Signed-off-by:
-
