- 21 Aug, 2014 40 commits
-
-
Laurent Pinchart authored
When the CCDC is already stopped due to a buffer underrun, the stop state machine won't advance in BT.656 mode as no interrupt are generated by the stopped CCDC in that mode. Handle this case explicitly in the ccdc_disable() function. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tested-by:
Enrico Butera <ebutera@users.sourceforge.net> Signed-off-by:
Mauro Carvalho Chehab <m.chehab@samsung.com>
-
Laurent Pinchart authored
In BT.656 mode the synchronization signals are generated by the CCDC from the embedded sync codes. The VD0 and VD1 interrupts are thus only triggered when the CCDC is enabled, unlike external sync mode where the line counter runs even when the CCDC is stopped. We can't disable the CCDC at VD1 time, as no VD0 interrupt would be generated for a short frame, which would result in the CCDC being stopped and no VD interrupt generated anymore. The CCDC is stopped from the VD0 interrupt handler instead for BT.656. Signed-off-by:
-
Laurent Pinchart authored
We will stop using VD1 in BT.656 mode, move frame number increment to the VD0 interrupt handler. Signed-off-by:
-
Laurent Pinchart authored
Use a local variable to avoid the duplicate spin_unlock_irqrestore() call. Signed-off-by:
-
Laurent Pinchart authored
There's no need for a double underscore in the function name, remove it. Signed-off-by:
-
Laurent Pinchart authored
Checking that the captured field corresponds to the last required field depending on the requested field order before completing the buffer isn't enough. When the first field at stream start corresponds to the last required field, this would result in returning an interlaced buffer containing a single field. Fix this by keeping track of the fields captured in the buffer, and make sure that both fields are present for alternate field orders. Signed-off-by:
-
Laurent Pinchart authored
The video port doesn't support YUV formats. Disable it when the CCDC sink pad format is set to YUV instead of leaving it enabled and relying on downstream modules not to process data they receive from the video port. Experiments showed that this fixes some of the CCDC failures to stop, especially in BT.656 mode. Signed-off-by:
-
Laurent Pinchart authored
Query the CCDC input media bus type from the subdev connected to the CCDC sink pad and configure the CCDC accordingly to support BT.656 synchronization. Signed-off-by:
Sakari Ailus <sakari.ailus@iki.fi> Signed-off-by:
-
Laurent Pinchart authored
The CCDC can interleave fields into a single buffer when writing to memory. Support it. Signed-off-by:
-
Laurent Pinchart authored
When the CCDC input is interlaced enable the alternate field order on the CCDC output video node. The field signal polarity is specified through platform data. Signed-off-by:
-
Laurent Pinchart authored
Instead of using goto statements to a single line return, return the correct value immediately. Signed-off-by:
-
Laurent Pinchart authored
Assign the format variable to the sink pad format earlier and use it instead of accessing the sink pad format directly from the ISP structure. Signed-off-by:
-
Laurent Pinchart authored
The field order requested on the video node must match the field order at the connected subdevice source pad. Signed-off-by:
-
Laurent Pinchart authored
If the requested field order is not supported default to progressive as we can't guess how the user will configure the pipeline later on. Signed-off-by:
-
Laurent Pinchart authored
The isp_video_pix_to_mbus() and isp_video_mbus_to_pix() calls in isp_video_set_format() only access static fields of the isp_video structure. They don't need to be protected by a mutex. Signed-off-by:
-
Laurent Pinchart authored
We don't want to modify all source files the day the FSF moves. Signed-off-by:
-
Laurent Pinchart authored
Record the value returned by subdevs from s_stream(0) and handle stop failures when an error occurs. Signed-off-by:
-
Laurent Pinchart authored
The field order must match between the source and sink pads, or the sink pad field order must be NONE. This allows connecting an interlaced source to a bridge that has no hardware support for interlaced formats. Signed-off-by:
-
Sakari Ailus authored
Add support for the V4L2_CID_TEST_PATTERN control. When the solid colour mode is selected, additional controls become available for setting the solid four solid colour components. Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by:
Hans Verkuil <hans.verkuil@cisco.com> Acked-by:
-
Sakari Ailus authored
Add numeric definitions for menu items used in the smiapp driver's test pattern menu. Signed-off-by:
Lad, Prabhakar <prabhakar.csengg@gmail.com> Signed-off-by:
-
Sakari Ailus authored
In many cases the test pattern has selectable values for each colour component. Implement controls for raw bayer components. Additional controls should be defined for colour components that are not covered by these controls. Signed-off-by:
-
Mauro Carvalho Chehab authored
Now that xc5000_set_params() is also called during resume, move the code that checks for the firmware to happen there. This way, the firmware will be loaded either for analog or digital TV when .resume callback is called. Signed-off-by: -
Mauro Carvalho Chehab authored
When DVB is streaming and suspend is called, it will call au0828_stop_transport(), with will clean the streaming flag. Due to that, stop_urb_transfer() will be called twice, causing an oops. So, we need another flag to be used at resume, telling it to restart DVB. While here, add a logic at stop_urb_transfer() to prevent it of being called twice, and convert the usb_streaming flag into boolean. Signed-off-by: -
Mauro Carvalho Chehab authored
dev->dvb is always not null, as it is an area at the dev memory. So, checking if (dev->dvb) is always true. Instead of this stupid check, what the code wants to do is to know if the DVB was successully registered. Fix it by checking, instead, for dvb->frontend. It should also be sure that this var will be NULL if the device was not properly initialized. Signed-off-by: -
Mauro Carvalho Chehab authored
xc5000_set_params() is a bad name for a function that handles only digital TV. Rename it to xc5000_set_digital_params(), and proper name the generic function that works for both digital and analog. No functional changes. Signed-off-by: -
Mauro Carvalho Chehab authored
If a device suspends/hibertates with a station tuned, restore the tuner station at resume. Signed-off-by: -
Mauro Carvalho Chehab authored
As we need a function that reapply the last tuned radio, in order to do resume, split the code that validates and updates the internal priv struct from the ones that actually set radio and TV. A latter patch will add support for resume. Signed-off-by: -
Mauro Carvalho Chehab authored
As we'll be adding a code to resume tuner operation, we need to move the code that actually sets DTV on a separate function, to be called by the resume code. No functional changes, just code got moved. Signed-off-by: -
Mauro Carvalho Chehab authored
After xc5000 stops working, it waits for 5 seconds, waiting for a new usage. Only after that it goes to low power mode. If a suspend event happens before that, a work queue will remain active, with causes suspend to crash. Signed-off-by: -
Mauro Carvalho Chehab authored
While several tuners have some sort of suspend/resume implementation, this is currently mangled with an optional .sleep callback that it is also used to put the device on low power mode. Not all drivers implement it, as returning the driver from low power may require to re-load the firmware, with takes some time. Also, some drivers may delay it. So, the more coherent is to add two new optional callbacks that will let the tuners to directy implement suspend and resume callbacks if they need. Signed-off-by: -
Mauro Carvalho Chehab authored
Suspend/resume conditions can be very tricky. Add some info printk's to help tracking what's happening there. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of using printk(KERN_foo, use pr_foo() macros. No functional changes. Note: we should do the same for dprintk(), but that would require to remove the dprintk levels. So, for now, let's not touch on it. Signed-off-by: -
Mauro Carvalho Chehab authored
Signed-off-by: -
Mauro Carvalho Chehab authored
No timers should be enabled during suspend. So, stop them. At resume time, we should do the proper initialization for it to keep working. Signed-off-by: -
Mauro Carvalho Chehab authored
The STREAM_ON state is used by s_format callback, but the driver never sets it. Fix it. This will also be needed in order to handle suspend/resume ops. Signed-off-by: -
Mauro Carvalho Chehab authored
The scheduled work should be cancelled during suspend. At resume time, we need to set the frontend again. So, add such logic to the driver. Signed-off-by: -
Mauro Carvalho Chehab authored
At resume, we should restore the register contents. So, reenable the bridge and GPIO settings. Signed-off-by: -
Mauro Carvalho Chehab authored
Trying to make au0828 to suspend can do very bad things, as the polling Kthread is not handled. We should disable it during suspend, only re-enabling it at resume. Still, analog and digital TV won't work, as we don't reinit the settings at resume, but at least it won't hang. Signed-off-by: -
Shuah Khan authored
Remove CONFIG_VIDEO_AU0828_RC scope around au0828_rc_register() and au0828_rc_unregister() calls in au0828-core Signed-off-by:
Shuah Khan <shuah.kh@samsung.com> Signed-off-by:
-
Shuah Khan authored
Define au0828_rc_*() stubs to avoid compile errors when VIDEO_AU0828_RC is disabled and avoid the need to enclose au0828_rc_*() in ifdef CONFIG_VIDEO_AU0828_RC in .c files. Signed-off-by:
-
