- 15 Feb, 2016 40 commits
-
-
Bhumika Goyal authored
Remove multiple assignments by factorizing them. Made a coccinelle script to match cases: @@ identifier a,b; constant c; @@ -a=b=c; +a=c; +b=c; Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Janani Ravichandran authored
Remove braces around single statement blocks in if conditions as they are not required. Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Remove else block here as it is not useful after the return statement in the corresponding if block. This simplifies code. This issue was identified by checkpatch. Signed-off-by:
-
Janani Ravichandran authored
Remove the return statement at the end of the void function as it has no purpose. Signed-off-by:
-
Janani Ravichandran authored
Remove the macros FN_IN and FN_OUT as they haven't been used anywhere. Signed-off-by:
-
Janani Ravichandran authored
Remove spaces between function names and open parentheses as they are unnecessary. Signed-off-by:
-
Janani Ravichandran authored
Get rid of extraneous braces enclosing single statement blocks. Signed-off-by:
-
Janani Ravichandran authored
This patch includes KERN_ facility level for printk(). KERN_INFO is justified here as the messages here are informational. Signed-off-by:
-
Alison Schofield authored
Remove cast on void pointers. C programming language guarantees the conversion from void pointer to any other pointer type. Coccinelle patch: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Alison Schofield authored
Remove casts on void pointers. C programming language guarantees the conversion from void pointer to any other pointer type. Coccinelle patch: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Alison Schofield authored
Remove cast on void pointer. C programming language guarantees the conversion from void pointer to any other pointer type. Coccinelle patch: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Alison Schofield authored
Remove cast on void pointers. C programming language guarantees the conversion from void pointer to any other pointer type. Coccinelle patch: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Chaehyun Lim authored
This patch uses netdev_err instead of PRINT_ER that is a custom debug print. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch renames result to ret that is used to get return value from wilc_send_config_pkt. Some handle_*() function are used as result, others are used as ret. It will start to rename as ret in all handle_*() function to sync up with this variable name. Signed-off-by:
-
Chaehyun Lim authored
result variable gets value from wilc_send_config_pkt that has return value of int. This patch changes data type of result variable to int. Signed-off-by:
-
Chaehyun Lim authored
When handle_set_channel is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by:
-
Chaehyun Lim authored
struct scan_info is defined as a new local variable in wilc_scan function. It makes some assignment short as well as improve more readability. Signed-off-by:
-
Chaehyun Lim authored
This patch renames u8security to security to remove u8 prefix in struct user_conn_req. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Chaehyun Lim authored
This patch renames pu8ssid to ssid to remove pu8 prefix in struct user_conn_req. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Chaehyun Lim authored
This patch renames pu8bssid to bssid to remove pu8 prefix in struct user_conn_req. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Chaehyun Lim authored
This patch renames s8rssi to rssi to remove s8 prefix in struct found_net_info. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Chaehyun Lim authored
This patch renames au8bssid to bssid to remove au8 prefix. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Chaehyun Lim authored
This patch renames au8bssid to bssid to remove au8 prefix in struct join_bss_param. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Alison Schofield authored
Improve readability by initializing local variables at declaration. In one instance, vnt_start_interrupt_urb_complete(), also use that local variable in subsequent switch. Signed-off-by:
-
Alison Schofield authored
Replace GFP_ATOMIC with GFP_KERNEL during urb buffer allocation. This makes vnt_alloc_bufs() consistent in setting GFP_KERNEL during kmalloc() and usb_alloc_urb(). GFP_KERNEL is safe because we are in process context, not in an interrupt handler, nor holding any spinlock. Signed-off-by:
-
Eva Rachel Retuya authored
Rename the macro defining constant ROWxCOL into ROW_X_COL to remove checkpatch check concerning use of CamelCase and to achieve better readability. CHECK: Avoid CamelCase: <ROWxCOL> Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Omit the whitespace after '{' brace as suggested by checkpatch. CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: -
Eva Rachel Retuya authored
Insert the required whitespace after the function declaration as suggested by checkpatch. CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by:
-
Eva Rachel Retuya authored
Fix alignment issues by properly indenting function parameters in accordance to the kernel coding style. Checkpatch pointed out this issue. CHECK: Alignment should match open parenthesis Signed-off-by:
-
Eva Rachel Retuya authored
Add the required trailing * on subsequent lines as well as move the */ on a separate line. Checkpatch found this issue. Signed-off-by:
-
Bhumika Goyal authored
Declare the function cache_stats_print as static since it is used only in this file. Used grep to find occurences. Problem found using sparse. Signed-off-by:
-
Bhumika Goyal authored
NULL check before kfree is unnecessary so remove it. Semantic patch used: // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Signed-off-by: -
Amitoj Kaur Chawla authored
Use macro IS_ERR_OR_NULL in place of tests for NULL and IS_ERR. The Coccinelle semantic patch used to make the change is as follows: //<smpl> @@ expression e; @@ - e == NULL || IS_ERR(e) + IS_ERR_OR_NULL(e) //</smpl> Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Niranjan Dighe authored
Fix the following warning generated about type casting by sparse warning: cast removes address space of expression The current implementation casts the structure pointers with (char *) without __user annotation and then adds sizeof struct to it, thereby generating the sparse warning. Fixed this by removing the unnecessary char pointer type cast. Signed-off-by:
Niranjan Dighe <niranjan.dighe@gmail.com> Signed-off-by:
-
James Simmons authored
Doing if (rc != 0) or if (rc == 0) is bad form. This patch corrects the LNet code to behavior according to kernel coding standards. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
James Simmons authored
This removes every instance of checking a variable against NULL in the LNet source code. Signed-off-by:
-
James Simmons authored
Properly balance the braces done wrong as reported by checkpatch.pl. Signed-off-by:
-
James Simmons authored
Several function declarations have spacing in them. Lets remove all those instances reported by checkpatch.pl. Signed-off-by:
-
James Simmons authored
Cleanup all occurances of more than one variable being set per line as reported by checkpatch.pl. Signed-off-by:
-
James Simmons authored
Add missing spaces in the code reported by checkpatch.pl. Signed-off-by:
-
