- 04 Oct, 2017 40 commits
-
-
Christophe JAILLET authored
If this memory allocation fails, we must release some resources, as already done in the code below and above. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-
Markus Elfring authored
Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
Sean Young <sean@mess.org> Signed-off-by:
-
Marc Gonzalez authored
ir_setkeytable() and ir_create_table() print the same debug message. Delete the one in ir_setkeytable() Signed-off-by:
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> Signed-off-by:
-
Stephen Hemminger authored
The Linus policy on Kconfig is that the default should be no for all new devices. I.e the user rebuild a new kernel from an old config should not by default get a larger kernel. Fixes: b4c184e5 ("[media] media: reorganize the main Kconfig items") Signed-off-by:
Stephen Hemminger <sthemmin@microsoft.com> Acked-by:
Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by:
-
Thomas Meyer authored
Replace self coded binary search, by existing library version. Signed-off-by:
Thomas Meyer <thomas@m3y3r.de> Signed-off-by:
-
Ladislav Michl authored
Gpiolib API is preferred way to access gpios. Signed-off-by:
Ladislav Michl <ladis@linux-mips.org> Signed-off-by:
-
Ladislav Michl authored
gpio_ir_recv_platform_data are not used anywhere in kernel tree, so remove it. Signed-off-by:
-
Ladislav Michl authored
There already is standard macro providing driver name, use it. Signed-off-by:
-
Ladislav Michl authored
Use of devm_request_irq simplifies error unwinding and as free_irq was the last user of driver remove function, remove it too. Signed-off-by:
-
Ladislav Michl authored
Requesting any context irq is not actually great idea since threaded interrupt handler is run at too unpredictable time which turns timing information wrong. Fix it by requesting regular interrupt. Signed-off-by:
-
Ladislav Michl authored
Use of devm_rc_register_device simplifies error unwinding. Signed-off-by:
-
Ladislav Michl authored
Use of devm_gpio_request_one simplifies error unwinding. Signed-off-by:
-
Ladislav Michl authored
Use of devm_rc_allocate_device simplifies error unwinding. Signed-off-by:
-
Ladislav Michl authored
Use of devm_kzalloc simplifies error unwinding. Signed-off-by:
-
Ladislav Michl authored
Using explicit struct device variable makes code a bit more readable. Signed-off-by:
-
Colin Ian King authored
Don't populate the const arrays vfd_packet6 and fp_packet on the stack, instead make them static. Makes the object code smaller by over 600 bytes: Before: text data bss dec hex filename 43794 17920 1024 62738 f512 drivers/media/rc/imon.o After: text data bss dec hex filename 42994 18080 1024 62098 f292 drivers/media/rc/imon.o Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Sean Young authored
Only the nec protocol is understood, but then it doesn't pass on the full scancode and it ignores the nec repeats its own remote sends, so holding buttons does not work. Signed-off-by:
-
Sean Young authored
This name is also stored in the input's device name, but that is not available in TX only hardware (no input device). Signed-off-by:
-
Sean Young authored
If the protocols of an rc device cannot be changed, ensure the sysfs file is not writable. This makes it possible to detect this from userspace, so ir-keytable can deal with case without giving an error. Signed-off-by:
-
Sean Young authored
"IR-receiver inside an USB DVB receiver" is not descriptive and we have a proper name available. Signed-off-by:
-
Sean Young authored
rc scancode drivers without change_protocol should have all protocols enabled at all time. This was only true for cec and ir-kbd-i2c. Signed-off-by:
-
Sean Young authored
The keymap is missing one key, and correct another. Signed-off-by:
-
Sean Young authored
This receiver only accepts nec16 messages, I've tried many other protocols and they're all dropped. Signed-off-by:
-
Markus Elfring authored
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by:
-
Markus Elfring authored
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by:
-
Bhumika Goyal authored
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Arvind Yadav authored
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by <linux/usb.h> work with const usb_device_id. So mark the non-const structs as const. Signed-off-by:
Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by:
-
David Härdeman authored
The use of two separate structs (lirc_dev aka lirc_driver and irctl) makes it much harder to follow the proper lifetime of the various structs and necessitates hacks such as keeping a copy of struct lirc_dev inside struct irctl. Merging the two structs means that lirc_dev can properly manage the lifetime of the resulting struct and simplifies the code at the same time. [mchehab@s-opensource.com: fix merge conflict] Signed-off-by:
David Härdeman <david@hardeman.nu> Signed-off-by:
-
David Härdeman authored
lirc_zilog currently embeds a struct lirc_dev in its own struct IR, but subsequent patches will make the lifetime of struct lirc_dev dynamic (i.e. it will be free():d once lirc_dev is sure there are no users of the struct). Therefore, change lirc_zilog to use a pointer to a dynamically allocated struct lirc_dev. Signed-off-by:
-
David Härdeman authored
lirc_zilog stashes a pointer to the parent device in struct lirc_dev and uses it for logging. It makes more sense to let lirc_zilog keep track of that pointer in its own struct (this is in preparation for subsequent patches which will remodel struct lirc_dev). Signed-off-by:
-
David Härdeman authored
Introduce two new functions so that the API for lirc_dev matches that of the rc-core and input subsystems. This means that lirc_dev structs are managed using the usual four functions: lirc_allocate_device lirc_free_device lirc_register_device lirc_unregister_device The functions are pretty simplistic at this point, later patches will put more flesh on the bones of both. Signed-off-by:
-
David Härdeman authored
This is in preparation for the later patches which do away with struct irctl entirely. Signed-off-by:
-
David Härdeman authored
Using the kernel-provided IDA simplifies the code and makes it possible to remove the lirc_dev_lock mutex. Signed-off-by:
-
David Härdeman authored
Use the irctl mutex for all device operations and only use lirc_dev_lock to protect the irctls array. Also, make sure that the device is alive early in each fops function before doing anything else. Since this patch touches nearly every line where the irctl mutex is taken/released, it also renames the mutex at the same time (the name irctl_lock will be misleading once struct irctl goes away in later patches). [mchehab@s-opensource.com: fix a merge conflict] Signed-off-by:
-
David Härdeman authored
The "attached" member of struct irctl is a boolean value, so let the code reflect that. Signed-off-by:
-
David Härdeman authored
Make setting chunk_size and buffer_size mandatory for drivers which expect lirc_dev to allocate the lirc_buffer (i.e. ir-lirc-codec) and don't set them in lirc-zilog (which creates its own buffer). Also remove an unnecessary copy of chunk_size in struct irctl (the same information is already available from struct lirc_buffer). Signed-off-by:
-
David Härdeman authored
By making better use of file->private_data in lirc_dev we can avoid digging around in the irctls[] array, thereby simplifying the code. External drivers need to use lirc_get_pdata() instead of mucking around in file->private_data. The newly introduced lirc_init_pdata() function isn't very elegant, but it's a stopgap measure which can be removed once lirc_zilog is converted to rc-core. Signed-off-by:
-
David Härdeman authored
Replace calls to cdev_add() and device_add() with the cdev_device_add() helper function. Signed-off-by:
-
David Härdeman authored
All users of lirc_register_driver() uses dynamic minor allocation, therefore we can remove the ability to explicitly request a given number. This changes the function prototype of lirc_unregister_driver() to also take a struct lirc_driver pointer as the sole argument. Signed-off-by:
-
David Härdeman authored
If an error is generated, it is more logical to error out ASAP. Signed-off-by:
-
