1. 30 Jul, 2022 3 commits
    • Benjamin Coddington's avatar
      NLM: Defend against file_lock changes after vfs_test_lock() · 184cefbe
      Benjamin Coddington authored
      Instead of trusting that struct file_lock returns completely unchanged
      after vfs_test_lock() when there's no conflicting lock, stash away our
      nlm_lockowner reference so we can properly release it for all cases.
      
      This defends against another file_lock implementation overwriting fl_owner
      when the return type is F_UNLCK.
      Reported-by: default avatarRoberto Bergantinos Corpas <rbergant@redhat.com>
      Tested-by: default avatarRoberto Bergantinos Corpas <rbergant@redhat.com>
      Signed-off-by: default avatarBenjamin Coddington <bcodding@redhat.com>
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      184cefbe
    • Chuck Lever's avatar
      SUNRPC: Fix xdr_encode_bool() · c770f31d
      Chuck Lever authored
      I discovered that xdr_encode_bool() was returning the same address
      that was passed in the @p parameter. The documenting comment states
      that the intent is to return the address of the next buffer
      location, just like the other "xdr_encode_*" helpers.
      
      The result was the encoded results of NFSv3 PATHCONF operations were
      not formed correctly.
      
      Fixes: ded04a58 ("NFSD: Update the NFSv3 PATHCONF3res encoder to use struct xdr_stream")
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
      c770f31d
    • Jeff Layton's avatar
      nfsd: eliminate the NFSD_FILE_BREAK_* flags · 23ba98de
      Jeff Layton authored
      We had a report from the spring Bake-a-thon of data corruption in some
      nfstest_interop tests. Looking at the traces showed the NFS server
      allowing a v3 WRITE to proceed while a read delegation was still
      outstanding.
      
      Currently, we only set NFSD_FILE_BREAK_* flags if
      NFSD_MAY_NOT_BREAK_LEASE was set when we call nfsd_file_alloc.
      NFSD_MAY_NOT_BREAK_LEASE was intended to be set when finding files for
      COMMIT ops, where we need a writeable filehandle but don't need to
      break read leases.
      
      It doesn't make any sense to consult that flag when allocating a file
      since the file may be used on subsequent calls where we do want to break
      the lease (and the usage of it here seems to be reverse from what it
      should be anyway).
      
      Also, after calling nfsd_open_break_lease, we don't want to clear the
      BREAK_* bits. A lease could end up being set on it later (more than
      once) and we need to be able to break those leases as well.
      
      This means that the NFSD_FILE_BREAK_* flags now just mirror
      NFSD_MAY_{READ,WRITE} flags, so there's no need for them at all. Just
      drop those flags and unconditionally call nfsd_open_break_lease every
      time.
      Reported-by: default avatarOlga Kornieskaia <kolga@netapp.com>
      Link: https://bugzilla.redhat.com/show_bug.cgi?id=2107360
      Fixes: 65294c1f (nfsd: add a new struct file caching facility to nfsd)
      Cc: <stable@vger.kernel.org> # 5.4.x : bb283ca1 NFSD: Clean up the show_nf_flags() macro
      Cc: <stable@vger.kernel.org> # 5.4.x
      Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      23ba98de
  2. 17 Jul, 2022 15 commits
  3. 16 Jul, 2022 12 commits
  4. 15 Jul, 2022 10 commits
    • Linus Torvalds's avatar
      Merge tag 'riscv-for-linus-5.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · 9b59ec8d
      Linus Torvalds authored
      Pull RISC-V fixes from Palmer Dabbelt:
      
       - A fix to avoid printing a warning when modules do not exercise any
         errata-dependent behavior and the SiFive errata are enabled.
      
       - A fix to the Microchip PFSOC to attach the L2 cache to the CPU nodes.
      
      * tag 'riscv-for-linus-5.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux:
        riscv: don't warn for sifive erratas in modules
        riscv: dts: microchip: hook up the mpfs' l2cache
      9b59ec8d
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · a8ebfcd3
      Linus Torvalds authored
      Pull KVM fixes from Paolo Bonzini:
       "RISC-V:
         - Fix missing PAGE_PFN_MASK
      
         - Fix SRCU deadlock caused by kvm_riscv_check_vcpu_requests()
      
        x86:
         - Fix for nested virtualization when TSC scaling is active
      
         - Estimate the size of fastcc subroutines conservatively, avoiding
           disastrous underestimation when return thunks are enabled
      
         - Avoid possible use of uninitialized fields of 'struct
           kvm_lapic_irq'
      
        Generic:
         - Mark as such the boolean values available from the statistics file
           descriptors
      
         - Clarify statistics documentation"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        KVM: emulate: do not adjust size of fastop and setcc subroutines
        KVM: x86: Fully initialize 'struct kvm_lapic_irq' in kvm_pv_kick_cpu_op()
        Documentation: kvm: clarify histogram units
        kvm: stats: tell userspace which values are boolean
        x86/kvm: fix FASTOP_SIZE when return thunks are enabled
        KVM: nVMX: Always enable TSC scaling for L2 when it was enabled for L1
        RISC-V: KVM: Fix SRCU deadlock caused by kvm_riscv_check_vcpu_requests()
        riscv: Fix missing PAGE_PFN_MASK
      a8ebfcd3
    • Linus Torvalds's avatar
      Merge tag 'ceph-for-5.19-rc7' of https://github.com/ceph/ceph-client · 1ce9d792
      Linus Torvalds authored
      Pull ceph fix from Ilya Dryomov:
       "A folio locking fixup that Xiubo and David cooperated on, marked for
        stable. Most of it is in netfs but I picked it up into ceph tree on
        agreement with David"
      
      * tag 'ceph-for-5.19-rc7' of https://github.com/ceph/ceph-client:
        netfs: do not unlock and put the folio twice
      1ce9d792
    • Linus Torvalds's avatar
      Merge tag 'spi-fix-v5.19-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi · 8006112d
      Linus Torvalds authored
      Pull spi fixes from Mark Brown:
       "A few driver specific fixes, none especially remarkable, plus a
        MAINTAINERS file update due to the previous maintainer for the NXP
        FSPI driver having left the company"
      
      * tag 'spi-fix-v5.19-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
        spi: cadence-quadspi: Remove spi_master_put() in probe failure path
        MAINTAINERS: change the NXP FSPI driver maintainer.
        spi: amd: Limit max transfer and message size
        spi: aspeed: Fix division by zero
        spi: aspeed: Add dev_dbg() to dump the spi-mem direct mapping descriptor
      8006112d
    • Linus Torvalds's avatar
      Merge tag 'soc-fixes-5.19-3' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc · 1c49f281
      Linus Torvalds authored
      Pull ARM SoC fixes from Arnd Bergmann:
       "Most of the contents are bugfixes for the devicetree files:
      
         - A Qualcomm MSM8974 pin controller regression, caused by a cleanup
           patch that gets partially reverted here.
      
         - Missing properties for Broadcom BCM49xx to fix timer detection and
           SMP boot.
      
         - Fix touchscreen pinctrl for imx6ull-colibri board
      
         - Multiple fixes for Rockchip rk3399 based machines including the vdu
           clock-rate fix, otg port fix on Quartz64-A and ethernet on
           Quartz64-B
      
         - Fixes for misspelled DT contents causing minor problems on
           imx6qdl-ts7970m, orangepi-zero, sama5d2, kontron-kswitch-d10, and
           ls1028a
      
        And a couple of changes elsewhere:
      
         - Fix binding for Allwinner D1 display pipeline
      
         - Trivial code fixes to the TEE and reset controller driver
           subsystems and the rockchip platform code.
      
         - Multiple updates to the MAINTAINERS files, marking the Palm Treo
           support as orphaned, and fixing some entries for added or changed
           file names"
      
      * tag 'soc-fixes-5.19-3' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (21 commits)
        arm64: dts: broadcom: bcm4908: Fix cpu node for smp boot
        arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
        ARM: dts: sunxi: Fix SPI NOR campatible on Orange Pi Zero
        ARM: dts: at91: sama5d2: Fix typo in i2s1 node
        tee: tee_get_drvdata(): fix description of return value
        optee: Remove duplicate 'of' in two places.
        ARM: dts: kswitch-d10: use open drain mode for coma-mode pins
        ARM: dts: colibri-imx6ull: fix snvs pinmux group
        optee: smc_abi.c: fix wrong pointer passed to IS_ERR/PTR_ERR()
        MAINTAINERS: add polarfire rng, pci and clock drivers
        MAINTAINERS: mark ARM/PALM TREO SUPPORT orphan
        ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count
        arm64: dts: ls1028a: Update SFP node to include clock
        dt-bindings: display: sun4i: Fix D1 pipeline count
        ARM: dts: qcom: msm8974: re-add missing pinctrl
        reset: Fix devm bulk optional exclusive control getter
        MAINTAINERS: rectify entry for SYNOPSYS AXS10x RESET CONTROLLER DRIVER
        ARM: rockchip: Add missing of_node_put() in rockchip_suspend_init()
        arm64: dts: rockchip: Assign RK3399 VDU clock rate
        arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior
        ...
      1c49f281
    • David Sterba's avatar
      Revert "btrfs: turn delayed_nodes_tree into an XArray" · 088aea3b
      David Sterba authored
      This reverts commit 253bf575.
      
      Revert the xarray conversion, there's a problem with potential
      sleep-inside-spinlock [1] when calling xa_insert that triggers GFP_NOFS
      allocation. The radix tree used the preloading mechanism to avoid
      sleeping but this is not available in xarray.
      
      Conversion from spin lock to mutex is possible but at time of rc6 is
      riskier than a clean revert.
      
      [1] https://lore.kernel.org/linux-btrfs/cover.1657097693.git.fdmanana@suse.com/Reported-by: default avatarFilipe Manana <fdmanana@suse.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      088aea3b
    • David Sterba's avatar
      Revert "btrfs: turn name_cache radix tree into XArray in send_ctx" · 5b8418b8
      David Sterba authored
      This reverts commit 40769420.
      
      Revert the xarray conversion, there's a problem with potential
      sleep-inside-spinlock [1] when calling xa_insert that triggers GFP_NOFS
      allocation. The radix tree used the preloading mechanism to avoid
      sleeping but this is not available in xarray.
      
      Conversion from spin lock to mutex is possible but at time of rc6 is
      riskier than a clean revert.
      
      [1] https://lore.kernel.org/linux-btrfs/cover.1657097693.git.fdmanana@suse.com/Reported-by: default avatarFilipe Manana <fdmanana@suse.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      5b8418b8
    • David Sterba's avatar
      Revert "btrfs: turn fs_info member buffer_radix into XArray" · 01cd3909
      David Sterba authored
      This reverts commit 8ee92268.
      
      Revert the xarray conversion, there's a problem with potential
      sleep-inside-spinlock [1] when calling xa_insert that triggers GFP_NOFS
      allocation. The radix tree used the preloading mechanism to avoid
      sleeping but this is not available in xarray.
      
      Conversion from spin lock to mutex is possible but at time of rc6 is
      riskier than a clean revert.
      
      [1] https://lore.kernel.org/linux-btrfs/cover.1657097693.git.fdmanana@suse.com/Reported-by: default avatarFilipe Manana <fdmanana@suse.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      01cd3909
    • David Sterba's avatar
      Revert "btrfs: turn fs_roots_radix in btrfs_fs_info into an XArray" · fc7cbcd4
      David Sterba authored
      This reverts commit 48b36a60.
      
      Revert the xarray conversion, there's a problem with potential
      sleep-inside-spinlock [1] when calling xa_insert that triggers GFP_NOFS
      allocation. The radix tree used the preloading mechanism to avoid
      sleeping but this is not available in xarray.
      
      Conversion from spin lock to mutex is possible but at time of rc6 is
      riskier than a clean revert.
      
      [1] https://lore.kernel.org/linux-btrfs/cover.1657097693.git.fdmanana@suse.com/Reported-by: default avatarFilipe Manana <fdmanana@suse.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      fc7cbcd4
    • Linus Torvalds's avatar
      Merge tag 'platform-drivers-x86-v5.19-4' of... · 2a347a06
      Linus Torvalds authored
      Merge tag 'platform-drivers-x86-v5.19-4' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86
      
      Pull x86 platform driver fixes from Hans de Goede:
       "Highlights:
      
         - Fix brightness key events getting reported twice on some Dells.
           Regression caused by recent Panasonic hotkey fixes
      
         - Fix poweroff no longer working on some devices regression caused
           by recent poweroff handler rework
      
         - Mark new (in 5.19) Intel IFS driver as broken, because of some
           issues surrounding the userspace (sysfs) API which need to be
           cleared up
      
         - Some hardware-id / quirk additions"
      
      * tag 'platform-drivers-x86-v5.19-4' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86:
        ACPI: video: Fix acpi_video_handles_brightness_key_presses()
        platform/x86: intel_atomisp2_led: Also turn off the always-on camera LED on the Asus T100TAF
        platform/x86/intel/ifs: Mark as BROKEN
        platform/x86: asus-wmi: Add key mappings
        efi: Fix efi_power_off() not being run before acpi_power_off() when necessary
        platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830/1050 poweroff again
        platform/x86: gigabyte-wmi: add support for B660I AORUS PRO DDR4
        platform/x86/amd/pmc: Add new platform support
        platform/x86/amd/pmc: Add new acpi id for PMC controller
      2a347a06