Commits · 1c1bc5f1dd86237c65f571ca72c75b285b0dceeb · Kirill Smelkov / linux

16 May, 2014 40 commits

staging: rtl8723au: Call usb_read_interrupt() directly instead of via HAL layer · 1c1bc5f1
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
1c1bc5f1

staging: rtl8723au: Call usb_{read,write}_port() functions directly · 633475cf

Jes Sorensen authored May 16, 2014

Get rid of more HAL layer obfuscations
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

633475cf

staging: rtl8723au: Clean up usb_{read,write}_port() usage · 97ccc3a6

Jes Sorensen authored May 16, 2014

Get rid of silly HAL convolution for calling usb_{read,write}_port()
functions.

Benefit from fact we just have one input address for read_port, so no
point storing this and carrying it around.

Pick pipe in the local function instead of based on dst/src address.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

97ccc3a6

staging: rtl8723au: Use correct pipe type for USB interrupts · 4810ce07

Jes Sorensen authored May 16, 2014

Use a correct pipe type when filling un interrupt urbs. This should
finally take care of the WARN() messages on the console when USB urbs
are submitted.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4810ce07

staging: rtl8723au: Clean up mess of parenthesis abuse · af1853da

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

af1853da

staging: rtl8723au: usb_ops_linux.h: Remove some unused #defines · 428891a3

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

428891a3

staging: rtl8723au: Remove nasty wrappers used to hide wrong function types · 2296fd2d

Jes Sorensen authored May 16, 2014

Do not use #defines to hack around pre-history functions not matching
current APIs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2296fd2d

staging: rtl8723au: Remove unused USB bulk related macros and variables · a64ddc8d
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
a64ddc8d

staging: rtl8723au: Don't wrap calls to usb_control_msg() · 4631e505

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4631e505

staging: rtl8723au: Call usb_intf_{start,stop} directly · 596f85ad

Jes Sorensen authored May 16, 2014

Rip out multiple layer of useless wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

596f85ad

staging: rtl8723au: Call rtl8723au_set_hw_type() directly · c174eae6

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c174eae6

staging: rtl8723au: Remove unused usb_suspend_sema · 43aeefd9

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

43aeefd9

staging: rtl8723au: Move last utility function from osdep_service.c to os_intfs.c · 633dd914

Jes Sorensen authored May 16, 2014

No point carrying a dedicated file just for this small helper, so move
it to os_intfs.c and get rid of osdep_service.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

633dd914

staging: rtl8723au: os_intfs.c: Various cosmetic cleanups · e6ac6eb2

Jes Sorensen authored May 16, 2014

In addition skb->priorty is a u32, so make rtw_classify8021d return a
u32 to match.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e6ac6eb2

staging: rtl8723au: os_dep/usb_ops_linux.c: More bad parenthesis cleanup · eb269884
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
eb269884

staging: rtl8723au: hal/usb_ops_linux.c: Various cleanups · 7438ccb9

Jes Sorensen authored May 16, 2014

Reduce excessive parenthesis usage, remove unnecessary null
initialization of variables, and some bad formatting.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7438ccb9

staging: rtl8723au: odm_precomp.h: Remove unused #define TEST_FALG__ · 9b00959f

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9b00959f

staging: rtl8723au: hal_com.c: Fix one case of returning status in an s32 · 18bd6df2
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
18bd6df2

staging: rtl8723au: rtl8723a_cmd.c: Fix up bad return types · 95d412d8

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

95d412d8

staging: rtl8723au: rtl8723a_hal_init.c: Fix more messy return type abuse · a5681f99
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
a5681f99

staging: rtl8723au: rtl8723a_phycfg.c: Use int for error return codes · c691ec33

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c691ec33

staging: rtl8723au: rtl8723au_xmit.c: Fixup messy return type usage · 5c195cc2

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5c195cc2

staging: rtl8723au: rtl8723au_xmit_tasklet(): Remove unnecessary variable init · 24ed8e45
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
24ed8e45

staging: rtl8723au: usb_halinit.c: Another u8 error code case · e04cd3f5

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e04cd3f5

staging: rtl8723au: usb_intf.c: Fixup yet another round of u8 abuse for error type · 86c3e3f1
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
86c3e3f1
staging: rtl8723au: os_intfs.c: Fixup more u8/uint abuse for error return codes · 9e2d0666
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
9e2d0666
staging: rtl8732au: ioctl_cfg80211.c: Fix another case of u8 abuse for error return · 16b9632d
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
16b9632d
staging: rtl8723au: rtw_xmit.c: Be consistent in using int for error return type · 8fd873d9
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8fd873d9
staging: rtl8723au: rtw_wlan_util.c: Fix up random mixing of bool vs int · f6fe0a41
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f6fe0a41
staging: rtl8723au: rtw_sta_mgt.c: Clean up messy usage of return types · 95ddd225
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
95ddd225
staging: rtl8723au: rtw_security.c: Clean up mess of error return code types · 75f3f039
Jes Sorensen authored May 16, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
75f3f039

staging: rtl8723au: decryptor() use int to store error codes · 69632480

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

69632480

staging: rtl8723au: Don't return true/false in unsigned int · d5789247

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d5789247

staging: rtl8723au: rtw_mlme_ext.c: Use int to return error codes · f66e05d8

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f66e05d8

staging: rtl8723au: rtw_ioctl_set.c: Fix up messy error code handling · 7e761c5a

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7e761c5a

staging: rtl8723au: Remove unused usb_read_mem/usb_write_mem stubs · 43eeb8ee

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

43eeb8ee

staging: rtl8723au: Clean up error codes in IO functions · ad899b12

Jes Sorensen authored May 16, 2014

This also fixes up another messy case assuming _FAIL == false and
true == _SUCCESS
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ad899b12

staging: rtl8723au: Remove unused rtw_is_wps_ie23a() · 828373f9

Jes Sorensen authored May 16, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

828373f9

staging: rtl8723au: Clean up error code mess in rtw_efuse.c · 44f3f16d

Jes Sorensen authored May 16, 2014

Use int to return error codes, and avoid mixing and matching
true/false with _FAIL/_SUCCESS at random.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

44f3f16d

staging: rtl8723au: Make cmd and event handlers return int instead of u8 · 1ec8911b

Jes Sorensen authored May 16, 2014

This is needed so we can eventually start passing around proper error
codes instead of the custom RTW ones.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1ec8911b