- 23 Aug, 2011 40 commits
-
-
Roland Vossen authored
Code cleanup. bus->card is assigned in brcmf_sdbrcm_probe (before brcmf_sdbrcm_probe_attach()). Since w_sdreg32() and r_sdreg32() are called only after that assignment, they can safely use bus->card. Thus there is no instance left where brcmf_sdcard_reg_read() or brcmf_sdcard_reg_write() is called with a NULL parameter, so the mechanism in bcmsdh.c that deals with a NULL pointer could be deleted. Reviewed-by:
Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by:
Franky (Zhenhui) Lin <frankyl@broadcom.com> Signed-off-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Code cleanup. Macro invocations have been substituted with macro expansion. Reviewed-by:
-
Roland Vossen authored
This instruction was required for the bcm4716/bcm4322, but since the fullmac driver only supports bcm4329, it could be removed. After that, the R_REG macro's were identical and thus were reduced to just 1 R_REG macro. Reviewed-by:
-
Roland Vossen authored
Driver now builds for big endian mips platform, possibly also for other big endian platforms. A change was made to the R_REG and W_REG macro's. These macro's perform an xor (^) operation for endianess swap purposes. Gcc complained because an xor operation is not allowed on a pointer type. Fixed this by casting the pointer to an unsigned long. Reviewed-by:
-
Roland Vossen authored
Code that exceeded the 80 char limit has been placed in separate functions. Checkpatch warnings for the phy dir are now reduced to 1. Reviewed-by:
Henry Ptasinski <henryp@broadcom.com> Signed-off-by:
-
Roland Vossen authored
Refactored code to not exceed the 80 char limit. Reviewed-by:
-
Roland Vossen authored
Most of them being 'line exceeds 80 chars'. Still checkpatch warnings for the phy dir left, these will be resolved in the subsequent commits. Reviewed-by:
-
Arend van Spriel authored
Two members vcons_in and vcons_out were declared using the volatile keyword. However, there is no reason for doing so. The member is used only to calculate the backplane address to access using offsetof. This address is passed to subsequent read function. Use of volatile is not warranted. Signed-off-by:
Roland Vossen <rvossen@broadcom.com> Reviewed-by:
-
Arend van Spriel authored
The sysioc thread was triggered using a semaphore. Now it waits for a wake_up() on its wait queue and the semaphore has been removed as the semaphore serves another purpose. This removes a checkpatch warning for dhd_linux.c. Signed-off-by:
-
Franky Lin authored
Ioctl response wait is used only by bus layer in fullmac. Move the corresponding code to dhd_sdio.c Signed-off-by:
-
Franky Lin authored
In fullmac some variables are used by sdio layer declared in dhd_linux.c. Move them to dhd_sdio.c for clean up. Signed-off-by:
-
Sukesh Srikakula authored
With this patch, brcmfmac driver will pass roamed channel information to cfg80211 via cfg80211_roamed() API. Signed-off-by:
Sukesh Srikakula <sukeshs@broadcom.com> Reviewed-by:
-
Sukesh Srikakula authored
Disabling the interface doesn't terminate undergoing iscan in FW. When the interface is enabled immediately, first scan request is returning the stale scan results, which are populated during the earlier iscan. These stale scan results are causing random failures with chromium auto test cases. With this patch, iscan will be terminated in FW whenever iscan thread is terminated by the host driver. Signed-off-by:
-
Henry Ptasinski authored
Removed unnecessary braces in single-statement blocks. Used the tools 'uncrustify' and 'coccinelle' to accomplish this. Signed-off-by:
-
Arend van Spriel authored
The function brcmu_ether_atoe() does exactly the same as mac_pton(). The driver now uses the latter and brcmu_ether_atoe() has been removed as it is not used anymore. Signed-off-by:
-
Sukesh Srikakula authored
Connect request made robust by passing broadcast bssid to the FW in SET_SSID request. This fix helps STA to connect to any available AP in ESS instead of sticking to one unresponsive AP. Signed-off-by:
-
Sukesh Srikakula authored
With this patch, FW roaming will be enabled by default in brcmfmac driver Signed-off-by:
-
Sukesh Srikakula authored
brcmfmac driver is getting request for enabling power save before the interface is up. With the earlier implementation, this request used to fail resulting out of sync power save state between cfg80211 & brcmfmac driver. With this fix, power save state is stored in configuration parameters and will be used while initializing the adapter. Signed-off-by:
-
Roland Vossen authored
Signed-off-by:
-
Arend van Spriel authored
The function brcmf_c_pattern_atoh() returned meaningless -1 value. These have been replaced by linux error code -EINVAL. Signed-off-by:
-
Arend van Spriel authored
As checkpatch.pl rightfully indicated the volatile keyword was used but not necessary. It has been removed from the code. Signed-off-by:
-
Arend van Spriel authored
Part of the code in brcmf_init_scan was identical to the code in brcmf_invoke_iscan and has been replaced by a call to it. Signed-off-by:
-
Arend van Spriel authored
The semaphore proto_sem has been replaced with mutex proto_block which lock certain code paths for one thread. Signed-off-by:
-
Arend van Spriel authored
The FOREACH_BSS macro was changed to remove a checkpatch error. However, the patch was considered ugly. This patch is another attempt to make it more clear. END_FOREACH_BSS is defined with braces to avoid an invalid checkpatch.pl warning. Ideally, the checkpatch.pl script should be adapted but lacking good perl knowledge to do so. Reported-by:
Dan Carpenter <error27@gmail.com> Reviewed-by:
-
Roland Vossen authored
Volatile keyword is not needed, hardware is accessed using native Linux calls that provide synchronization. Signed-off-by:
-
Roland Vossen authored
Signed-off-by:
-
Roland Vossen authored
By struct brcms_c_rateset. Struct brcms_c_rateset was renamed from brcms_rateset, because there will be two rateset related structures that should differ significantly in naming from each other. Struct wl_rateset will be renamed to struct brcm_rateset in the next patch. Signed-off-by:
-
Roland Vossen authored
Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Softmac related code cleanup. Typedefs are undesirable according to the CodingStyle document. Signed-off-by:
-
Roland Vossen authored
Moved bmac functions above 'common' functions invoking them. This facilitates merging these functions in a later commit. Also declared locally used functions static. Signed-off-by:
-
Roland Vossen authored
Future goal is to merge the bmac layer in the driver with the 'common' layer. A step towards this goal is to have one file containing both bmac and common code. Header files (bmac.h, main.h) were also merged. Signed-off-by:
-
Roland Vossen authored
Three functions use the same method to check incoming parameters. The 'len' parameter can be equal to 0 in case of a 'set' operation. Currently these functions return an error code under that condition, which is incorrect. The problem was introduced in recent patches in which asserts were removed from the fullmac. Despite this being a bug, my regression testing has not shown any problems. Reported-by:
-
