- 04 Aug, 2015 5 commits
-
-
Geert Uytterhoeven authored
The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Acked-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Noralf Trønnes authored
Pass platform_data as an argument to fbtft_framebuffer_alloc() instead of using dev->platform_data. This fixes an issue where the device comes from Device Tree and fbtft_probe_common() sets dev->platform_data to allocated memory. When the module is reloaded, dev->platform_data points to freed memory. Signed-off-by:
Noralf Trønnes <noralf@tronnes.org> Signed-off-by:
-
Randy Dunlap authored
Fix build of hdm-dim2. Since it calls a function that is provided by AIM_NETWORK, make it depend on that symbol. Also fix a misspelling in the Kconfig file. drivers/built-in.o: In function `deliver_netinfo_thread': dim2_hdm.c:(.text+0x3a9563): undefined reference to `most_deliver_netinfo' Signed-off-by:
Randy Dunlap <rdunlap@infradead.org> Cc: Jain Roy Ambi <JainRoy.Ambi@microchip.com> Cc: Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by:
-
Randy Dunlap authored
Fix build errors: driver uses snd_pcm*() interfaces, so select SND_PCM. drivers/built-in.o: In function `audio_rx_completion': sound.c:(.text+0x3cd376): undefined reference to `snd_pcm_period_elapsed' drivers/built-in.o: In function `pcm_prepare': sound.c:(.text+0x3cd3b0): undefined reference to `snd_pcm_format_physical_width' sound.c:(.text+0x3cd3ce): undefined reference to `snd_pcm_format_big_endian' sound.c:(.text+0x3cd42c): undefined reference to `snd_pcm_format_big_endian' drivers/built-in.o: In function `pcm_hw_free': sound.c:(.text+0x3cd50a): undefined reference to `snd_pcm_lib_free_vmalloc_buffer' drivers/built-in.o: In function `pcm_hw_params': sound.c:(.text+0x3cd54c): undefined reference to `_snd_pcm_lib_alloc_vmalloc_buffer' drivers/built-in.o: In function `playback_thread': sound.c:(.text+0x3cd6a0): undefined reference to `snd_pcm_period_elapsed' drivers/built-in.o: In function `audio_probe_channel': sound.c:(.text+0x3cdc0b): undefined reference to `snd_pcm_new' sound.c:(.text+0x3cdc2b): undefined reference to `snd_pcm_set_ops' drivers/built-in.o:(.data+0x952d0): undefined reference to `snd_pcm_lib_ioctl' drivers/built-in.o:(.data+0x95318): undefined reference to `snd_pcm_lib_get_vmalloc_page' Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Signed-off-by:
-
Christian Gromm authored
This patch prevents a potential integer overlow. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
- 31 Jul, 2015 35 commits
-
-
Mateusz Kulikowski authored
In case of probe failure, io memory was not released properly. Signed-off-by:
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by:
-
Mateusz Kulikowski authored
The same steps were made for each RF path independently. Signed-off-by:
-
Mateusz Kulikowski authored
Macro caused checkpatch complaints - replace [] braces with () and use [] braces as array initializers. Signed-off-by:
-
Mateusz Kulikowski authored
Merge function into rtl92e_config_rf as having them separated gives no benefit. Signed-off-by:
-
Mateusz Kulikowski authored
Move phy version check outside of the loop. Signed-off-by:
-
Mateusz Kulikowski authored
Function should return struct member - no extra logic is needed. Signed-off-by:
-
Mateusz Kulikowski authored
It is set at the very beginning of function to a constant value. Signed-off-by:
-
Mateusz Kulikowski authored
Function is empty; rtllib checks if handler is NULL. Signed-off-by:
-
Mateusz Kulikowski authored
Function is empty; rtllib checks if handler is NULL. Signed-off-by:
-
Mateusz Kulikowski authored
Function is empty and called only once. Signed-off-by:
-
Mateusz Kulikowski authored
Function is empty and called only once. Signed-off-by:
-
Dan Carpenter authored
We checked that "it->options[3]" was non-zero on the line before so there is no need to check again. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Dan Carpenter authored
I was looking at how TOTAL_CAM_ENTRY is used and I saw this code. We print an error but continue writing "EntryNo" to a register as if it were valid. "EntryNo" is controlled by the user in rtl8192_ioctl() so it definitely can be invalid. I'm not positive what happens with the invalid data but it can't be good. Signed-off-by:
-
Dan Carpenter authored
"EntryNo" is comes from the user in the ioctl and it's a number between 0-255. The ieee->swcamtable[] array only has 32 elements so it can result in memory corruption. Signed-off-by:
-
Alex Wilson authored
Fixed two coding style warnings concerning multiline comments. Signed-off-by:
Alex Wilson <alex.david.wilson@gmail.com> Signed-off-by:
-
Viresh Kumar authored
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. This also replaces an IS_ERR(x) + (x == NULL) check to IS_ERR_OR_NULL check. Signed-off-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
Michael Hornung authored
* Fix sparse warning "Using plain integer as NULL pointer" Signed-off-by:
Michael Hornung <mhornung.linux@gmail.com> Signed-off-by:
-
Christian Gromm authored
This patch replaces pr_*() functions with dev_*(). Reported-by:
-
Christian Gromm authored
This patch fixes error "doing DMA on the stack" by using kzalloc for buffer allocation. Reported-by:
-
Christian Gromm authored
This patch fixes wrong casting. Reported-by:
-
Christian Gromm authored
This patch fixes double unlocking of a spinlock the aim-v4l2 module. Reported-by:
Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by:
-
Jignesh R Patel authored
Fixes the following checkpatch warning: Warning: Line over 80 characters Signed-off-by:
Jignesh R Patel <jigneshpatel0103@gmail.com> Signed-off-by:
-
Shraddha Barke authored
This patch compresses two lines into a single line if immediate return statement is found. Remove variable rc as it is no longer needed. It is done using script Coccinelle. And coccinelle uses the following semantic patch for this compression function: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by:Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
-
Freeman Zhang authored
Add space after ',' to fix the error message provided by checkpatch.pl: ERROR: space required after that ',' Signed-off-by:
Freeman Zhang <freeman.zhang1992@gmail.com> Signed-off-by:
-
Shraddha Barke authored
Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by:
-
Ciprian Manea authored
This patch fixes the checkpatch.pl warning: WARNING: Missing a blank line after declarations + unsigned long flags; + pshmem = (struct slic_shmem *)(unsigned long) Signed-off-by:
Ciprian Manea <ciprian.manea.cm@gmail.com> Signed-off-by:
-
Peter Huewe authored
If DEBUG is set dumpVGAReg is called and tries to access XGISR which is defined as (xgifb_info->dev_info.P3c4) which is not known within this function. -> add as parameter to dumpVGAReg so xgifb_info becomes known Signed-off-by:
Peter Huewe <peterhuewe@gmx.de> Signed-off-by:
-
Kevin Darbyshire-Bryant authored
Fixes checkpatch.pl WARNING: Missing a blank line after delarations Signed-off-by:
Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> Signed-off-by:
-
Navy Cheng authored
The public headers is well known by others and the redundant commits make the code mess. Remove the comments of the public headers to make the code tidy. Signed-off-by:
Navy Cheng <navych@126.com> Signed-off-by:
-
Tim Sell authored
The code that tests for high and low xmit watermarks was consolidatedand simplified. The output behavior should be identical, with the exception of an off-by-one error being corrected in the tests done when the counters overflowed. Signed-off-by:
Tim Sell <Timothy.Sell@unisys.com> Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Tim Sell authored
* A skb->len error-check was enabled (removed from a "#ifdef DEBUG" block). * Several unneeded "#ifdef DEBUG" blocks were removed. * A dev_err() was converted to the more-appropriate netdev_err(). Signed-off-by:
-
Tim Sell authored
Previously we simplified the serverdown function to basically turn it into a dev_close(), but missed the analogous logic in visornic_resume() (which is essentially the "book-end" of visornic_serverdown_complete()). As a result, during IO partition recovery, the nic would go closed when the IO partition went away, but would never be opened again when the IO partition came back. This patch changes visornic_resume() to use dev_open(), so that it once again plays nicely with visornic_serverdown_complete(). Because dev_open() forces us into the visornic_open() path, other logic in visornic_resume() was no longer necessary, and lended to simplifying visornic_resume() even more. Fixes: 36645d72a377 ("staging: unisys: simplify visornic_serverdown_complete") Signed-off-by: -
Tim Sell authored
Because devdata->enab_dis_acked is the flag used to determine whether an enable/disable operation to the IO partition has completed, it should always be cleared prior to initiating the operation. The call added to visornic_enable_with_timeout() added in this patch makes the usage there consistent with visornic_disable_with_timeout(). Signed-off-by:
-
Tim Sell authored
In the patch which changed the serverdown logic to by synchronous, we were mistakenly holding on to devdata->priv_lock in the call to visornic_serverdown_complete(), which ultimately ended up recursively attempting to grab the same lock via the path: --> dev_close --> visornic_close() --> visornic_disable_with_timeout() Evidence: BUG: spinlock recursion on CPU#0, kworker/u2:0/1567 lock: 0xffff88002d7e4c90, .magic: dead4ead, .owner: kworker/ .owner_cpu: 0 CPU: 0 PID: 1567 Comm: kworker/u2:0 Tainted: G WC 4.2.0-rc3-ARCH+ #60 Hardware name: Dell Inc. PowerEdge T110/ , BIOS 1.23 12/15/2009 Workqueue: visorchipset_controlvm controlvm_periodic_work [visorbus] ffff8800216a9380 ffff88002d167878 ffffffff81476874 000000000000061f ffff88002d7e4c90 ffff88002d167898 ffffffff8109e2bc ffff88002d7e4c90 ffffffff81763d7c ffff88002d1678b8 ffffffff8109e330 ffff88002d7e4c90 Call Trace: [<ffffffff81476874>] dump_stack+0x4f/0x73 [<ffffffff8109e2bc>] spin_dump+0x7c/0xc0 [<ffffffff8109e330>] spin_bug+0x30/0x40 [<ffffffff8109e547>] do_raw_spin_lock+0x127/0x140 [<ffffffff8147bf8b>] _raw_spin_lock_irqsave+0x4b/0x60 [<ffffffffa0168a5c>] ? visornic_disable_with_timeout.clone.2+0x3c/ [visornic] [<ffffffff8147c639>] ? _raw_spin_unlock_bh+0x39/0x40 [<ffffffffa0168a5c>] visornic_disable_with_timeout.clone.2+0x3c/ [visornic] [<ffffffffa0168c6e>] visornic_close+0xe/0x20 [visornic] [<ffffffff813ae8d2>] __dev_close_many+0x92/0xe0 [<ffffffff813ae9ea>] dev_close_many+0x7a/0x110 [<ffffffff81097556>] ? down+0x16/0x50 [<ffffffff813af01f>] dev_close+0x3f/0x50 [<ffffffffa0166b61>] visornic_serverdown+0x91/0x1a0 [visornic] [<ffffffffa0155760>] ? device_changestate_responder.clone. [visorbus] [<ffffffffa0166c85>] visornic_pause+0x15/0x20 [visornic] [<ffffffffa015101f>] initiate_chipset_device_pause_resume+0x9f/0xe0 [visorbus] [<ffffffffa0151093>] chipset_device_pause+0x13/0x20 [visorbus] [<ffffffffa0153cbb>] device_epilog+0x12b/0x1a0 [visorbus] [<ffffffffa015506b>] handle_command+0x72b/0x970 [visorbus] [<ffffffffa015214e>] ? visorchannel_signalremove+0x6e/0x80 [visorbus] [<ffffffffa0155521>] controlvm_periodic_work+0x271/0x420 [visorbus] [<ffffffff8106cb52>] process_one_work+0x1d2/0x540 [<ffffffff8106cab9>] ? process_one_work+0x139/0x540 [<ffffffff814771b7>] ? __schedule+0x807/0xc30 [<ffffffff8106cf57>] worker_thread+0x57/0x4c0 [<ffffffff8106cf00>] ? process_scheduled_works+0x40/0x40 [<ffffffff8106cf00>] ? process_scheduled_works+0x40/0x40 [<ffffffff81073b19>] kthread+0xe9/0x110 [<ffffffff81073a30>] ? __init_kthread_worker+0x70/0x70 [<ffffffff8147cddf>] ret_from_fork+0x3f/0x70 [<ffffffff81073a30>] ? __init_kthread_worker+0x70/0x70 BUG: spinlock lockup suspected on CPU#0, kworker/u2:0/1567 Fixes: f2b70efaf48f ("staging: unisys: Make serverdown synchronous") Signed-off-by: -
Kees Cook authored
This makes sure the kthread name can't be parsed as a format string. Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
