- 22 Oct, 2023 40 commits
-
-
Kent Overstreet authored
This was another bug because of bch2_btree_iter_set_pos() invalidating iterators. Signed-off-by:
Kent Overstreet <kent.overstreet@gmail.com> Signed-off-by:
Kent Overstreet <kent.overstreet@linux.dev>
-
Kent Overstreet authored
Signed-off-by:
-
Kent Overstreet authored
We weren't journalling updates done while splitting/compacting nodes - oops. Signed-off-by: -
Kent Overstreet authored
Extent btrees no longer have weird special behaviour for min_key. Signed-off-by:
-
Kent Overstreet authored
Dropping the wrong kind of lock can't lead to anything good... Signed-off-by:
-
Kent Overstreet authored
It wasn't updated for the patch that switched inodes to using the offset field of struct bkey. Signed-off-by:
-
Kent Overstreet authored
bch2_btree_iter_set_pos() invalidates the key returned by peek(). Signed-off-by:
-
Kent Overstreet authored
When initial btree gc was changed to overlay journal keys as it walks the btree, it also stopped checking btree topology. Previously, checking btree topology was a fairly complicated affair - but it's much easier now that btree_ptr_v2 has min_key in the pointer. This rewrites the old range_checks code and uses it in both runtime and initial gc. Signed-off-by:
-
Kent Overstreet authored
This fixes a lockdep splat - allocating memory can call bch2_clear_page_bits() which takes mark_lock. Signed-off-by: -
Kent Overstreet authored
This is so we don't overflow MAX_LOCK_DEPTH. Signed-off-by:
-
Kent Overstreet authored
Previously, BTREE_ID_INODES was special - inodes were indexed by the inode field, which meant the offset field of struct bpos wasn't used, which led to special cases in e.g. the btree iterator code. Now, inodes in the inodes btree are indexed by the offset field. Also: prevously min_key was special for extents btrees, min_key for extents would equal max_key for the previous node. Now, min_key = bkey_successor() of the previous node, same as non extent btrees. This means we can completely get rid of btree_type_sucessor/predecessor. Also make some improvements to the metadata IO validate/compat code. Signed-off-by:
-
Kent Overstreet authored
This has popped and thus needs to be debugged, but the assertion firing isn't necessarily fatal so switch it to a warning. Signed-off-by:
-
Kent Overstreet authored
This fixes an issue where mounting would fail because of memory fragmentation - previously the compression bounce buffers were using get_free_pages(). Signed-off-by:
-
Kent Overstreet authored
Signed-off-by:
-
Kent Overstreet authored
The locking was wrong, and we could get a use after free in the error path where we weren't taking the entrie being freed off the unwritten list. Signed-off-by:
-
Kent Overstreet authored
vmalloc allocations don't always obey GFP_NOFS - memalloc_nofs_save() is the prefered approach for the future. Signed-off-by:
-
Kent Overstreet authored
Seeing the extents that were overlapping is highly useful for figuring out what went wrong. Signed-off-by:
-
Kent Overstreet authored
This will be used by the userspace debug tools. Signed-off-by:
-
Kent Overstreet authored
Signed-off-by:
-
Kent Overstreet authored
Previously, the btree has always been self contained and internally consistent on disk without anything from the journal - the journal just contained pointers to the btree roots. However, this meant that btree node split or compact operations - i.e. anything that changes btree node topology and involves updates to interior nodes - would require that interior btree node to be written immediately, which means emitting a btree node write that's mostly empty (using 4k of space on disk if the filesystemm blocksize is 4k to only write perhaps ~100 bytes of new keys). More importantly, this meant most btree node writes had to be FUA, and consumer drives have a history of slow and/or buggy FUA support - other filesystes have been bit by this. This patch changes the interior btree update path to journal updates to interior nodes, after the writes for the new btree nodes have completed. Best of all, it turns out to simplify the interior node update path somewhat. Signed-off-by:
-
Kent Overstreet authored
This slightly modifies the journal replay code so that it can replay updates to interior nodes. Signed-off-by:
-
Kent Overstreet authored
This will be needed for the upcoming patches to journal updates to interior btree nodes. Signed-off-by: -
Kent Overstreet authored
Extent merging is currently broken, and will be reimplemented differently soon - right now it only happens when btree nodes are being compacted, which makes it difficult to test. Signed-off-by:
-
Kent Overstreet authored
This works around a btree locking issue - we can't be holding read locks while taking write locks, which currently means we can't have live iterators holding read locks at commit time. Signed-off-by:
-
Kent Overstreet authored
This fixes a transaction iterator overflow. Signed-off-by:
-
Kent Overstreet authored
We were incorrectly not restarting the transaction when re-traversing iterators. Signed-off-by:
-
Kent Overstreet authored
Internal writes (i.e. copygc/rebalance operations) shouldn't be blocking on the allocator when we're going RO. Signed-off-by:
-
Kent Overstreet authored
The patch "bcachefs: Move extent overwrite handling out of core btree code" should have been flipping on this feature bit; extent btree nodes in the old format have to be rewritten before we can insert into them with the new extent update path. Not turning on this feature bit was causing us to go into an infinite loop where we keep rewriting btree nodes over and over. Signed-off-by:
-
Kent Overstreet authored
This is needed so that users can roll back to before "d9bb516b2d bcachefs: Move extent overwrite handling out of core btree code", which it appears may still be buggy. Signed-off-by:
-
Kent Overstreet authored
This updates bch2_rbio_narrow_crcs() to the current style for transactional btree code, and fixes a rare panic on iterator overflow. Signed-off-by:
-
Kent Overstreet authored
Signed-off-by:
-
Kent Overstreet authored
Signed-off-by:
-
Kent Overstreet authored
Signed-off-by:
-
Kent Overstreet authored
Ever since the btree code was first written, handling of overwriting existing extents - including partially overwriting and splittin existing extents - was handled as part of the core btree insert path. The modern transaction and iterator infrastructure didn't exist then, so that was the only way for it to be done. This patch moves that outside of the core btree code to a pass that runs at transaction commit time. This is a significant simplification to the btree code and overall reduction in code size, but more importantly it gets us much closer to the core btree code being completely independent of extents and is important prep work for snapshots. This introduces a new feature bit; the old and new extent update models are incompatible when the filesystem needs journal replay. Signed-off-by: -
Kent Overstreet authored
Introduce a new iterator method that provides a consistent view of the btree plus uncommitted updates. Signed-off-by:
-
Kent Overstreet authored
Signed-off-by:
-
Kent Overstreet authored
Ensure that iter->pos always lies between the start and end of iter->k (the last key returned). Also, bch2_btree_iter_set_pos() now invalidates the key that peek() or next() returned. Signed-off-by:
-
Kent Overstreet authored
Signed-off-by: -
Kent Overstreet authored
More aggressively checking iterator invariants, and fixing the resulting bugs. Also greatly simplifying iter_next() and iter_next_slot() - they were hyper optimized before, but the optimizations were getting too brittle. Signed-off-by:
-
Kent Overstreet authored
These are created by the new extent update path, but not used yet by the recovery code and they break the existing recovery code, so we can just skip them. Signed-off-by:
-
