- 23 May, 2014 40 commits
-
-
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Julia Lawall authored
Delete unnecessary local variable whose value is always 0 and that hides the fact that the result is always 0. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ local idexpression ret; expression e; position p; @@ -ret = 0; ... when != ret = e return - ret + 0 ; // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
John Church authored
This patch fixes a coding style issue for a line that was over 80 characters long. Signed-off-by:
John Church <sleeveroller@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Rickard Strandqvist authored
Removal of null pointer checks that could never happen Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Reviewed-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Jes Sorensen authored
Copying 16 bits into an uninitialized 32 bit stack variable and then byteswapping it can provide 'interesting' results. Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
navin patidar authored
Signed-off-by:
navin patidar <navin.patidar@gmail.com> Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
odm_DynamicBBPowerSaving() has empty defination. Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Function has empty defination. Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
navin patidar authored
Signed-off-by:
-
Christian Engelmayer authored
(status != _SUCCESS) immediately after 'status = _SUCCESS' will never evaluate true. Thus remove the logically dead code. Detected by Coverity - CID 1077553. Signed-off-by:
Christian Engelmayer <cengelma@gmx.at> Acked-by:
-
Christian Engelmayer authored
Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS as long as not explicitly set. Thus initialize 'status' to FAIL, in order to prevent undefined behaviour if going through the exit paths. Detected by Coverity - CID 1077832. Signed-off-by:
-
Christian Engelmayer authored
Fix a potential leak in the error path of rtw_set_key(). In case the requested algorithm is not supported by the driver, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077716, 1077717. Signed-off-by:
-
Christian Engelmayer authored
Fix a potential leak in the error path of function update_bcn_wps_ie(). Move the affected input verification to the beginning of the function so that it may return directly without leaking already allocated memory. Detected by Coverity - CID 1077718. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_mp_pwrtrk() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - 1077715. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077714. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_mp_QueryDrv() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077713. Signed-off-by:
-
Christian Engelmayer authored
Function rtw_wx_set_enc_ext() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077712. Signed-off-by:
-
