- 13 Oct, 2007 40 commits
-
-
Laurent Vivier authored
Split kvm_setup_pio() into two functions, one to setup in/out pio (kvm_emulate_pio()) and one to setup ins/outs pio (kvm_emulate_pio_string()). Signed-off-by:
Laurent Vivier <Laurent.Vivier@bull.net> Signed-off-by:
Avi Kivity <avi@qumranet.com>
-
Laurent Vivier authored
Both vmx and svm decode the I/O instructions, and both botch the job, requiring the instruction prefixes to be fetched in order to completely decode the instruction. So, if we see a string I/O instruction, use the x86 emulator to decode it, as it already has all the prefix decoding machinery. This patch defines ins/outs opcodes in x86_emulate.c and calls emulate_instruction() from io_interception() (svm.c) and from handle_io() (vmx.c). It removes all vmx/svm prefix instruction decoders (get_addr_size(), io_get_override(), io_address(), get_io_count()) Signed-off-by:
-
Laurent Vivier authored
Line 1809 of kvm_main.c is useless, value is overwritten in line 1815: 1809 now = min(count, PAGE_SIZE / size); 1810 1811 if (!down) 1812 in_page = PAGE_SIZE - offset_in_page(address); 1813 else 1814 in_page = offset_in_page(address) + size; 1815 now = min(count, (unsigned long)in_page / size); 1816 if (!now) { Signed-off-by: -
Li, Xin B authored
Remove a duplicated ia32e mode VM Entry control definition and use the proper one. Signed-off-by:
Xin Li <xin.b.li@intel.com> Signed-off-by:
-
Rusty Russell authored
We use kfree in svm.c and vmx.c, and this works, but it could break at any time. kfree() is supposed to match up with kmalloc(). Signed-off-by:
Rusty Russell <rusty@rustcorp.com.au> Signed-off-by:
-
Rusty Russell authored
All guest-invokable printks should be ratelimited to prevent malicious guests from flooding logs. This is a start. Signed-off-by:
-
Rusty Russell authored
Devices don't need open or release functions. Signed-off-by:
-
Rusty Russell authored
We shouldn't define stat_set on the debug attributes, since that will cause silent failure on writing: without a set argument, userspace will get -EACCESS. Signed-off-by:
-
Gabriel C authored
move_msr_up() is used only on X86_64 and generates a warning on !X86_64 Signed-off-by:
Gabriel Craciunescu <nix.or.die@googlemail.com> Signed-off-by:
-
Rusty Russell authored
alloc_vmcs_cpu is already declared (static) above, no need to redeclare. Signed-off-by:
-
Rusty Russell authored
set_msr_interception() is used by svm to set up which MSRs should be intercepted. It can only fail if someone has changed the code to try to intercept an MSR without updating the array of ranges. The return value is ignored anyway: it should just BUG() if it doesn't work. (A build-time failure would be better, but that's tricky). Signed-off-by:
-
Rusty Russell authored
For some reason, mark_page_dirty open-codes __gfn_to_memslot(). Signed-off-by:
-
Rusty Russell authored
sSigned-off-by:
-
Yang, Sheng authored
All the physical CPUs on the board should support the same VMX feature set. Add check_processor_compatibility to kvm_arch_ops for the consistency check. Signed-off-by:
Sheng Yang <sheng.yang@intel.com> Signed-off-by:
-
Rusty Russell authored
kvm_vm_ioctl_get_dirty_log scans bitmap to see it it's all zero, but doesn't use that information. Avi says: Looks like it was used to guard kvm_mmu_slot_remove_write_access(); optimizing the case where the guest just leaves the screen alone (which it usually does, especially in benchmarks). I'd rather reinstate that optimization. See 90cb0529 where the damage was done. It's pretty simple: if the bitmap is all zero, we don't need to do anything to clean it. Signed-off-by:
-
Rusty Russell authored
Now we use a kmem cache for allocating vcpus, we can get the 16-byte alignment required by fxsave & fxrstor instructions, and avoid manually aligning the buffer. Signed-off-by:
-
Rusty Russell authored
Avi wants the allocations of vcpus centralized again. The easiest way is to add a "size" arg to kvm_init_arch, and expose the thus-prepared cache to the modules. Signed-off-by:
-
Laurent Vivier authored
... in favor of the more general emulator_{read,write}_*. Signed-off-by: -
Laurent Vivier authored
... instead of a x86_emulate_ctxt, so that other callers can use it easily. Signed-off-by:
-
Rusty Russell authored
Changes some svm.c internal function names: 1) io_adress -> io_address (de-germanify the spelling) 2) kvm_reput_irq -> reput_irq (it's not a generic kvm function) 3) kvm_do_inject_irq -> (it's not a generic kvm function) Signed-off-by:
-
Rusty Russell authored
container_of is wonderful, but not casting at all is better. This patch changes svm.c's internal functions to pass "struct vcpu_svm" instead of "struct kvm_vcpu" and using container_of. Signed-off-by:
-
Rusty Russell authored
There are several places where hardcoded numbers are used in place of the easily-available constant, which is poor form. Signed-off-by:
-
Rusty Russell authored
container_of is wonderful, but not casting at all is better. This patch changes vmx.c's internal functions to pass "struct vcpu_vmx" instead of "struct kvm_vcpu" and using container_of. Signed-off-by:
-
Rusty Russell authored
Now that kvm generally runs with preemption enabled, we need to protect the fpu intialization sequence. Signed-off-by:
-
Shaohua Li authored
This allows the kvm mmu to perform sleepy operations, such as memory allocation. Signed-off-by:
Shaohua Li <shaohua.li@intel.com> Signed-off-by:
-
Avi Kivity authored
Current kvm disables preemption while the new virtualization registers are in use. This of course is not very good for latency sensitive workloads (one use of virtualization is to offload user interface and other latency insensitive stuff to a container, so that it is easier to analyze the remaining workload). This patch re-enables preemption for kvm; preemption is now only disabled when switching the registers in and out, and during the switch to guest mode and back. Contains fixes from Shaohua Li <shaohua.li@intel.com>. Signed-off-by: -
Jeff Dike authored
Add the hypercall number to kvm_run and initialize it. This changes the ABI, but as this particular ABI was unusable before this no users are affected. Signed-off-by:
Jeff Dike <jdike@linux.intel.com> Signed-off-by:
-
Yang, Sheng authored
Put cpu feature detecting part in hardware_setup, and stored the vmcs condition in global variable for further check. [glommer: fix for some i386-only machines not supporting CR8 load/store exiting] Signed-off-by:
Glauber de Oliveira Costa <gcosta@redhat.com> Signed-off-by:
-
Rusty Russell authored
This patch converts the vcpus array in "struct kvm" to a pointer array, and changes the "vcpu_create" and "vcpu_setup" hooks into one "vcpu_create" call which does the allocation and initialization of the vcpu (calling back into the kvm_vcpu_init core helper). Signed-off-by:
-
Gregory Haskins authored
struct kvm_vcpu has vmx-specific members; remove them to a private structure. Signed-off-by:
Gregory Haskins <ghaskins@novell.com> Signed-off-by:
-
Rusty Russell authored
load_pdptrs can be handed an invalid cr3, and it should not oops. This can happen because we injected #gp in set_cr3() after we set vcpu->cr3 to the invalid value, or from kvm_vcpu_ioctl_set_sregs(), or memory configuration changes after the guest did set_cr3(). We should also copy the pdpte array once, before checking and assigning, otherwise an SMP guest can potentially alter the values between the check and the set. Finally one nitpick: ret = 1 should be done as late as possible: this allows GCC to check for unset "ret" should the function change in future. Signed-off-by:
-
Aurelien Jarno authored
The writeback fixes (02c03a32) let some dead code in the cmpxchg instruction emulation. Remove it. Signed-off-by:
Aurelien Jarno <aurelien@aurel32.net> Signed-off-by:
-
Yang, Sheng authored
This patch mainly imports some constants and rename two exist constants of vmcs according to IA32 SDM. It also adds two constants to indicate Lock bit and Enable bit in MSR_IA32_FEATURE_CONTROL, and replace the hardcode _5_ with these two bits. Signed-off-by:
-
Shaohua Li authored
gfn_to_page might sleep with swap support. Move it out of the kmap calls. Signed-off-by:
-
Shaohua Li authored
vmx_cpu_run doesn't handle error correctly and kvm_mmu_reload might sleep with mutex changes, so I move it above. Signed-off-by:
-
Rusty Russell authored
Don't fall through and turn on PAE in this case. Signed-off-by:
-
Avi Kivity authored
Right now, the bug is harmless as we never emulate one-byte 0xb6 or 0xb7. But things may change. Noted by the mysterious Gabriel C. Signed-off-by: -
Avi Kivity authored
The writeback fixes (02c03a32) broke cmov emulation. Fix. Signed-off-by:
-
Rusty Russell authored
Intel manual (and KVM definition) say the TPR is 4 bits wide. Also fix CR8_RESEVED_BITS typo. Signed-off-by:
H. Peter Anvin <hpa@zytor.com> Signed-off-by:
-
Jeff Dike authored
Signed-off-by:
-
